Skip to contentSkip to conversation

net: openvswitch: Check vport netdev name

PATCH Applied Jun Gu 3 participants 4 messages Apr 19, 2024 – Apr 23, 2024

Subsystems (3)
lore
Share & tools
lore

Jun Gu

author
#0 lore raw

PATCH v4 1/1 net: openvswitch: Check vport netdev name

Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd.

---
 net/openvswitch/vport-netdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
net/openvswitch/vport-netdev.c +4 -1
index 903537a5da22..618edc346c0f 100644
@@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
 	int err;
 
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
-	if (!vport->dev) {
+	/* Ensure that the device exists and that the provided
+	 * name is not one of its aliases.
+	 */
+	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
 		goto error_free_vport;
 	}
Signature · 1 line
2.25.1
maintainer
#1 lore raw

net/openvswitch/vport-netdev.c struct vport *ovs_netdev_link(struct vport *vport, const char *name) · line 87

Quoted 9 lines · On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
net/openvswitch/vport-netdev.c +4 -1
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
-	if (!vport->dev) {
+	/* Ensure that the device exists and that the provided
+	 * name is not one of its aliases.
+	 */
+	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
 		goto error_free_vport;
 	}

Sorry I applied this before I realised that it's buggy. dev_get_by_name() will give you a reference on the device. You must free it, so the error handling is different. Please follow up ASAP to fix that.

#3 lore raw
In reply to Jun Gu
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 19 Apr 2024 14:14:25 +0800 you wrote:

Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd.

[...]

Here is the summary with links:
- [net-next,v4] net: openvswitch: Check vport netdev name

    https://git.kernel.org/netdev/net-next/c/2540088b836f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
author
#2 lore raw
In reply to Jakub Kicinski

My mistake, I'm wondering that I need to submit a new patch or a v5 version based on this patch?

Quoted 16 lines · Jakub Kicinski

net/openvswitch/vport-netdev.c struct vport *ovs_netdev_link(struct vport *vport, const char *name) · line 87

Quoted 9 lines · On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
  	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
net/openvswitch/vport-netdev.c +4 -1
-	if (!vport->dev) {
+	/* Ensure that the device exists and that the provided
+	 * name is not one of its aliases.
+	 */
+	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
  		err = -ENODEV;
  		goto error_free_vport;
  	}

Sorry I applied this before I realised that it's buggy. dev_get_by_name() will give you a reference on the device. You must free it, so the error handling is different. Please follow up ASAP to fix that.