tty: serial: bcm63xx: allow building on ARM64
PATCH 1/1 tty: serial: bcm63xx: allow building on ARM64
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TEST + default ARCH_BCM4908 help This enables the driver for the onchip UART core found on the following chipsets:
Signature · 1 line
2.26.2
Greg Kroah-Hartman
maintainerQuoted 15 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/tty/serial/Kconfig +0
-0
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 5 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TEST
Why do we have an arch dependancy at all now?
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908
Really? I thought we were getting rid of these "ARCH_platform_type" of things. That's what a defconfig file is for, right?
thanks,
greg k-h
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.
As for testing driver compilation on unused arch-s I thought that's what COMPILE_TEST is for.
Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
Quoted 4 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" of things. That's what a defconfig file is for, right?
I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/
There are also no platform defconfigs in arch/arm64/ at all. Should I handle it with arch/arm64/Kconfig.platforms and "select SERIAL_BCM63XX"?
Greg Kroah-Hartman
maintainerQuoted 29 lines · Rafał Miłecki
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 12 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.
Quoted 5 lines
As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If COMPILE_TEST is working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)
Quoted 11 lines
Quoted 4 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" of things. That's what a defconfig file is for, right?I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?
I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
thanks,
greg k-h
Quoted 50 lines · Greg Kroah-Hartman
Quoted 29 lines · Rafał Miłecki
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 12 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to
applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.Quoted 5 lines
As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If
COMPILE_TESTis working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)Quoted 9 lines
Quoted 4 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" of things. That's what a defconfig file is for, right?I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/
Quoted 5 lines
Quoted 2 lines
There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
I find it useful for getting working kernel config for buildoot. It's simpler to look in arch/ than either:
1. Getting list of all required drivers manually (by looking at DT?)
2. Checking for config used by OpenWrt
3. Checking for config used by Linaro
4. Checking for config used by Foo
Hi Greg,
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Rafał Miłecki
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TEST
Why not s/ARM64/ARCH_BCM4908/?
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
Why do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.
As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.
Quoted 11 lines
Quoted 2 lines
Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If
COMPILE_TESTis working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)Quoted 3 lines
Quoted 3 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" of
No we are not.
Quoted 1 line
Quoted 1 line
Quoted 1 line
things. That's what a defconfig file is for, right?
FWIW, the arm64 defconfig file enables about everything, for all arm64 platforms.
Quoted 9 lines
Quoted 6 lines
I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
To prevent asking the user about a driver that is completely useless for the system(s) the user is compiling a kernel for.
Do you want to let distros compile all arm/arm64-only SoC drivers for x86, too?
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
[Scroll down]
Quoted 64 lines · Geert Uytterhoeven
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Rafał Miłecki
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy not s/ARM64/ARCH_BCM4908/?
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
Why do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to
applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.Quoted 11 lines
Quoted 2 lines
Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If
COMPILE_TESTis working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)Quoted 3 lines
Quoted 3 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" ofNo we are not.
Quoted 1 line
Quoted 1 line
Quoted 1 line
things. That's what a defconfig file is for, right?
FWIW, the arm64 defconfig file enables about everything, for all arm64 platforms.
Quoted 7 lines
Quoted 6 lines
I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?
Quoted 7 lines
Quoted 2 lines
I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
To prevent asking the user about a driver that is completely useless for the system(s) the user is compiling a kernel for.
Do you want to let distros compile all arm/arm64-only SoC drivers for x86, too?
Could you suggest & send some Documentation on that so we have a global rule instead of per-tree / per-maintainer preferences, please? I'd really appreciate that.
Hi Rafał,
Quoted 3 lines · Rafał Miłecki
Could you suggest & send some Documentation on that so we have a global rule instead of per-tree / per-maintainer preferences, please? I'd really appreciate that.
Thanks, good idea!
[PATCH 0/2] Documentation/kbuild: Document COMPILE_TEST and platform dependencies
https://lore.kernel.org/r/[email protected]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Greg Kroah-Hartman
maintainerQuoted 48 lines · Geert Uytterhoeven
Hi Greg,
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Rafał Miłecki
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 10 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy not s/ARM64/ARCH_BCM4908/?
Quoted 18 lines
Quoted 7 lines
Quoted 2 lines
Why do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.
Quoted 5 lines
As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If
COMPILE_TESTis working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" ofNo we are not.
Ok, I keep getting mixed signals here.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
things. That's what a defconfig file is for, right?
FWIW, the arm64 defconfig file enables about everything, for all arm64 platforms.
Then why are there ARCH_platforms for arm64 systems?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
To prevent asking the user about a driver that is completely useless for the system(s) the user is compiling a kernel for.
How do you "know" that given the huge number of different ip blocks in SoC systems these days?
Quoted 1 line
Do you want to let distros compile all arm/arm64-only SoC drivers for x86, too?
Sure, many have crossed over over the years and shown up there.
But distro config owners are smarter than that, give them some credit :)
thanks,
greg k-h
Hi Greg,
Quoted 48 lines · Greg Kroah-Hartman
Quoted 41 lines · Geert Uytterhoeven
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Rafał Miłecki
Quoted 7 lines · Greg Kroah-Hartman
Quoted 6 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1136
Quoted 8 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on MIPS || ARM || ARM64 || COMPILE_TESTWhy not s/ARM64/ARCH_BCM4908/?
Quoted 18 lines
Quoted 7 lines
Quoted 2 lines
Why do we have an arch dependancy at all now?
From my experience "depends" is often used to limit symbol visibility to applicable platforms only. I don't think Broadcom has any x86, risc, etc. platforms so it's useless there.
Quoted 5 lines
As for testing driver compilation on unused arch-s I thought that's what
COMPILE_TESTis for.Am I wrong there? I'm afraid we don't have clear Documentation on that. Please kindly point me to some info if I'm wrong.
If
COMPILE_TESTis working for this driver, then trying to restrict it to a specific arch is usually pointless and the arch dependency can be removed, keeping patches like this from having to be made over time to add it to new arches :)Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1137
Quoted 1 line
drivers/tty/serial/Kconfig +1
-0+ default ARCH_BCM4908Really? I thought we were getting rid of these "
ARCH_platform_type" ofNo we are not.
Quoted 8 lines
Ok, I keep getting mixed signals here.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
things. That's what a defconfig file is for, right?
FWIW, the arm64 defconfig file enables about everything, for all arm64 platforms.
Then why are there
ARCH_platformsfor arm64 systems?
To enable core infrastructure or quirks for a certain SoC or SoC family, and to have a symbol for individual drivers to depend on?
To make it easier to configure a kernel suited for a specific system? Mostly, you can take arm64/defconfig, disable the ARCH_* guards for SoC families you're not interested in, and have a suitable kernel for your system.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
I had to miss something, last time I checked Linus called defconfigs a garbage and wanted to get rid of them:
https://lwn.net/Articles/391372/There are also no platform defconfigs in
arch/arm64/at all. Should I handle it witharch/arm64/Kconfig.platformsand "selectSERIAL_BCM63XX"?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I thought we were trying to get rid of arm64 "platforms" as well. My point being, why is this needed at all?
To prevent asking the user about a driver that is completely useless for the system(s) the user is compiling a kernel for.
How do you "know" that given the huge number of different ip blocks in SoC systems these days?
E.g. by looking at which .dtsi files contain device nodes that have a compatible value that matches the list of compatible values in the driver. Most IP cores are only present on a fairly limited set of SoCs and SoC families. Designware IPs are the major exception. And I hope the driver author/maintainer has some knowledge here.
Quoted 5 lines
Quoted 1 line
Do you want to let distros compile all arm/arm64-only SoC drivers for x86, too?
Sure, many have crossed over over the years and shown up there.
But distro config owners are smarter than that, give them some credit :)
Let's repeat your question above: "How do they know that...?". I guess the driver developer knows better (read: needs much less investigation time) than the distro config owner.
It's not just for distros. If we can make life easier for every single developer or user who configures a kernel, by just storing that information in the dependency system, I think that's a justification for doing that. And in fact we're already doing that in most subsystems. Serial seems to be the only one that wants to move in the other direction...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH v2 1/1 tty: serial: bcm63xx: lower driver dependencies
In reply to Rafał MiłeckiFrom: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64. In future more architectures may need it as well. There is nothing arch specific breaking compilation so just stick to requiring COMMON_CLK.
---
V2: Just drop all ARCH_* dependencies. Thanks Greg!
--- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
@@ -1133,7 +1133,7 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on COMMON_CLK help This enables the driver for the onchip UART core found on the following chipsets:
Signature · 1 line
2.26.2
Re: [PATCH V2] tty: serial: bcm63xx: lower driver dependencies
Quoted 8 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64. In future more architectures may need it as well. There is nothing arch specific breaking compilation so just stick to requiring
COMMON_CLK.Signed-off-by Rafał Miłecki <[email protected]>
Signature · 1 line
Florian
Re: [PATCH V2] tty: serial: bcm63xx: lower driver dependencies
In reply to Rafał MiłeckiQuoted 8 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64. In future more architectures may need it as well. There is nothing arch specific breaking compilation so just stick to requiring
COMMON_CLK.Signed-off-by Rafał Miłecki <[email protected]>
Quoted 2 lines
---
V2: Just drop all ARCH_* dependencies. Thanks Greg!
Greg, please stop suggesting to make the user's life harder.
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1139
Quoted 11 lines
drivers/tty/serial/Kconfig +1
-1@@ -1133,7 +1133,7 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on MIPS || ARM || COMPILE_TEST + depends on COMMON_CLK help This enables the driver for the onchip UART core found on the following chipsets:
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH V2] tty: serial: bcm63xx: lower driver dependencies
Quoted 11 lines · Geert Uytterhoeven
Quoted 8 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64. In future more architectures may need it as well. There is nothing arch specific breaking compilation so just stick to requiring
COMMON_CLK.Signed-off-by Rafał Miłecki <[email protected]>
I'm happy to fix that once maintainers agree on how to handle deps like that and ideally we have if officially documented.
Quoted 6 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Hardware supported by bcm63xx is also used by BCM4908 SoCs family that is ARM64.
Signed-off-by Rafał Miłecki <[email protected]>
If this ends up being the approach chosen:
--
Florian