Skip to contentSkip to conversation

Intel(R) MEI Driver

RFC PATCH In review Oren Weil 2 participants 2 messages Feb 10, 2011 Char and misc drivers

lore
Share & tools
lore

Oren Weil

author
#0 lore raw

RFC PATCH 2/13 Intel(R) MEI Driver

drivers/char/Makefile +1 -0
index 5bc765d..e43ea27 100644
@@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
 obj-$(CONFIG_RAMOOPS)		+= ramoops.o
 
 obj-$(CONFIG_JS_RTC)		+= js-rtc.o
+obj-$(CONFIG_INTEL_MEI)		+= mei/
 js-rtc-y = rtc.o

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#1 lore raw

drivers/char/Makefile

Quoted 1 line · Oren Weil
drivers/char/Makefile +0 -0

No description, or signed-off-by lines. Have you read how to properly create and submit a patch? If so, why did you ignore those rules?

drivers/char/Makefile obj-$(CONFIG_PS3_FLASH) += ps3flash.o · line 87

Quoted 8 lines

index 5bc765d..e43ea27 100644

drivers/char/Makefile +1 -0
@@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
 obj-$(CONFIG_RAMOOPS)		+= ramoops.o
 
 obj-$(CONFIG_JS_RTC)		+= js-rtc.o
+obj-$(CONFIG_INTEL_MEI)		+= mei/

You just broke the build.

I'm not going to review farther, it's a waste of my, and every one else's time.

greg k-h