arm: Enable VIDEO_BPP32 on pinebook.
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
Video output on the pinebook LCD screen was broken by:
commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional").
Enable VIDEO_BPP32 which was previously enabled by default when DM_VIDEO was set.
---
configs/pinebook_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/pinebook_defconfig +1 -0
@@ -22,3 +22,4 @@ CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y # CONFIG_USB_GADGET is not set CONFIG_VIDEO_BRIDGE=y CONFIG_VIDEO_BRIDGE_ANALOGIX_ANX6345=y +CONFIG_VIDEO_BPP32=y
Signature · 1 line
2.20.1
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
On Sat, 18 Jan 2020 03:15:15 -0800
Vagrant Cascadian vagrant at debian.org wrote:
...
Quoted 2 lines
configs/pinebook_defconfig | 1 + 1 file changed, 1 insertion(+)
Applied to u-boot-video/master, thanks!
--
Anatolij
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
In reply to Vagrant CascadianHi,
Quoted 8 lines · Vagrant Cascadian
Video output on the pinebook LCD screen was broken by:
commit
2cc393f32fd9("video: make BPP and ANSI configs optional").Enable
VIDEO_BPP32which was previously enabled by default whenDM_VIDEOwas set.Signed-off-by Vagrant Cascadian <[email protected]>
There's nothing really specific about the pinebook here, but it's needed for pretty much all the boards using DM_VIDEO (on Allwinner at least).
You should add a kconfig select / default instead
Maxime
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
Quoted 8 lines · Maxime Ripard
Quoted 7 lines · Vagrant Cascadian
Video output on the pinebook LCD screen was broken by:
commit
2cc393f32fd9("video: make BPP and ANSI configs optional").Enable
VIDEO_BPP32which was previously enabled by default whenDM_VIDEOwas set.
Quoted 7 lines
Quoted 1 line
Signed-off-by Vagrant Cascadian <[email protected]>There's nothing really specific about the pinebook here, but it's needed for pretty much all the boards using
DM_VIDEO(on Allwinner at least).You should add a kconfig select / default instead
That would basically revert 2cc393f32fd9, and I figured there was a reason for it...
It wouldn't surprise me that other systems are affected, but I only notice this issue on the pinebook (most of the systems I use are headless), where it definitely needed to be fixed somehow.
If there's a correct and more general fix, please propose it!
live well,
vagrant
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
Quoted 17 lines · Vagrant Cascadian
Quoted 8 lines · Maxime Ripard
Quoted 7 lines · Vagrant Cascadian
Video output on the pinebook LCD screen was broken by:
commit
2cc393f32fd9("video: make BPP and ANSI configs optional").Enable
VIDEO_BPP32which was previously enabled by default whenDM_VIDEOwas set.Quoted 7 lines
Quoted 1 line
Signed-off-by Vagrant Cascadian <[email protected]>There's nothing really specific about the pinebook here, but it's needed for pretty much all the boards using
DM_VIDEO(on Allwinner at least).You should add a kconfig select / default instead
Quoted 8 lines
That would basically revert
2cc393f32fd9, and I figured there was a reason for it...It wouldn't surprise me that other systems are affected, but I only notice this issue on the pinebook (most of the systems I use are headless), where it definitely needed to be fixed somehow.
If there's a correct and more general fix, please propose it!
Well, looking at 2cc393f32fd9 there are a number of platforms that enable more than one mode. But maybe we should always have at least one mode?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200118/337687df/attachment.sig>
PATCH 1/1 arm: Enable VIDEO_BPP32 on pinebook.
Quoted 25 lines · Tom Rini
Quoted 24 lines · Vagrant Cascadian
Quoted 8 lines · Maxime Ripard
Quoted 7 lines · Vagrant Cascadian
Video output on the pinebook LCD screen was broken by:
commit
2cc393f32fd9("video: make BPP and ANSI configs optional").Enable
VIDEO_BPP32which was previously enabled by default whenDM_VIDEOwas set.Quoted 7 lines
Quoted 1 line
Signed-off-by Vagrant Cascadian <[email protected]>There's nothing really specific about the pinebook here, but it's needed for pretty much all the boards using
DM_VIDEO(on Allwinner at least).You should add a kconfig select / default instead
That would basically revert
2cc393f32fd9, and I figured there was a reason for it...It wouldn't surprise me that other systems are affected, but I only notice this issue on the pinebook (most of the systems I use are headless), where it definitely needed to be fixed somehow.
Quoted 5 lines
Quoted 1 line
If there's a correct and more general fix, please propose it!
Well, looking at
2cc393f32fd9there are a number of platforms that enable more than one mode. But maybe we should always have at least one mode?
Yeah, I guess that would make the most sense. My suggestions was actually to enable it platform by platform, which wouldn't be a revert and would fix all the sunxi boards at once.
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200122/02e543a8/attachment.sig>