Skip to contentSkip to conversation

OMAP4: Intialize IVA Device in addition to DSP device.

PATCH New Shweta Gulati 3 participants 3 messages Mar 12, 2011 – Mar 16, 2011

Subsystems (4)
Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP power management support
lore
Share & tools
lore

Shweta Gulati

author
#0 lore raw

PATCH v2 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

OMAP4 has two different Devices IVA and DSP. DSP is bound with IVA for DVFS. The registration of IVA dev in API 'omap2_init_processor_devices' was missing. Init dev for 'iva_dev' is added.

This also fixes the following error seen during boot as omap2_set_init_voltage can now find the iva device

omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Signed-off-by Shweta Gulati <[email protected]>

---

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core

V2:
Rephrased the Commit log.

 arch/arm/mach-omap2/pm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/pm.c +1 -0
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 	if (cpu_is_omap44xx()) {
 		_init_omap_device("l3_main_1", &l3_dev);
 		_init_omap_device("dsp", &dsp_dev);
+		_init_omap_device("iva", &iva_dev);
 	} else {
 		_init_omap_device("l3_main", &l3_dev);
 	}
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v2 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

Quoted 30 lines · Shweta Gulati

OMAP4 has two different Devices IVA and DSP. DSP is bound with IVA for DVFS. The registration of IVA dev in API 'omap2_init_processor_devices' was missing. Init dev for 'iva_dev' is added.

This also fixes the following error seen during boot as omap2_set_init_voltage can now find the iva device

? ? ? ?omap2_set_init_voltage: Invalid parameters!
? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Signed-off-by Shweta Gulati <[email protected]>

---

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core

V2:
Rephrased the Commit log.

?arch/arm/mach-omap2/pm.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/pm.c +0 -0
index 30af335..49486f5 100644

arch/arm/mach-omap2/pm.c static void omap2_init_processor_devices(void)

Quoted 8 lines
arch/arm/mach-omap2/pm.c +1 -1
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 ? ? ? ?if (cpu_is_omap44xx()) {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev);
 ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev);
+ ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev);
 ? ? ? ?} else {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev);
 ? ? ? ?}
--

Looks fine to me.

Regards,
Nishanth Menon

#2 lore raw

PATCH v2 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

Quoted 26 lines · Nishanth
Quoted 25 lines · Shweta Gulati

OMAP4 has two different Devices IVA and DSP. DSP is bound with IVA for DVFS. The registration of IVA dev in API 'omap2_init_processor_devices' was missing. Init dev for 'iva_dev' is added.

This also fixes the following error seen during boot as omap2_set_init_voltage can now find the iva device

? ? ? ?omap2_set_init_voltage: Invalid parameters!
? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Signed-off-by Shweta Gulati <[email protected]>

---

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core

V2:
Rephrased the Commit log.

?arch/arm/mach-omap2/pm.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)

Quoted 14 lines

arch/arm/mach-omap2/pm.c static void omap2_init_processor_devices(void)

Quoted 13 lines
arch/arm/mach-omap2/pm.c +1 -1
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 ? ? ? ?if (cpu_is_omap44xx()) {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev);
 ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev);
+ ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev);
 ? ? ? ?} else {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev);
 ? ? ? ?}
--

Looks fine to me.

Thanks, I'll take this as an ack.

Will queue as a fix for the .39-rc fixes cycle.

Kevin