Skip to contentSkip to conversation

Fix fallouts from LINUX_BUILD_CMDS simplification

PATCH New Thomas Petazzoni 3 participants 18 messages Apr 22, 2019 – Apr 26, 2019

lore
Share & tools
lore
#0 lore raw

cover Fix fallouts from LINUX_BUILD_CMDS simplification

Hello,

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed, a patch of mine changed LINUX_BUILD_CMDS to do "make all $(LINUX_TARGET_NAME)" instead of "make $(LINUX_TARGET_NAME)" and "make modules".

This has caused a number of build issues in our defconfigs:

- A number of kernel configurations apparently don't build well when the "all" target is built concurrently with $(LINUX_TARGET_NAME), with weird file not found errors.

   We fix this by doing "make all" and "make $(LINUX_TARGET_NAME)"
   separately (first patch)

- Due to calling "make all", a little bit more might get built, and sometimes this "little bit more" needs mkimage, so we add host-uboot-tools to the defconfig. This is enough as linux/linux.mk automatically adds host-uboot-tools to its dependency if it's enabled. I hesitated with adding an explicit BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this sounds better or if the proposed solution in this patch series is good enough.

Thanks,

Thomas

Thomas Petazzoni (5):
linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets configs/beaglebone: kernel build needs mkimage configs/qemu_nios2_10m50: kernel build needs mkimage configs/qemu_ppc_mpc8544ds: kernel build needs mkimage configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

 configs/beaglebone_defconfig            | 2 ++
 configs/qemu_nios2_10m50_defconfig      | 3 +++
 configs/qemu_ppc_mpc8544ds_defconfig    | 3 +++
 configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
 linux/linux.mk                          | 3 ++-
 5 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/5 linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:

  make all $(LINUX_TARGET_NAME)

Unfortunately, it turns out that it breaks the build of a number of defconfigs, with errors such as:

fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory

Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations avoids this problem, and fixes the build of several defconfigs.

Fixes:

ts7680_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339583

qemu_xtensa_lx60_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339553

roseapplepi_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339564

qemu_xtensa_lx60_nommu_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339554

qemu_ppc64_e5500_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339539

freescale_t2080_qds_rdb_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339455

arcturus_ucp1020_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339399

Cc "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 linux/linux.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
linux/linux.mk +2 -1
index 1eac3287ab..dca3d63cd9 100644
@@ -444,7 +444,8 @@ define LINUX_BUILD_CMDS
 	$(foreach dts,$(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)), \
 		cp -f $(dts) $(LINUX_ARCH_PATH)/boot/dts/
 	)
-	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all $(LINUX_TARGET_NAME)
+	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all
+	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_TARGET_NAME)
 	$(LINUX_BUILD_DTB)
 	$(LINUX_APPEND_DTB)
 endef
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/5 linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 5 lines

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:

  make all $(LINUX_TARGET_NAME)
Quoted 7 lines

Unfortunately, it turns out that it breaks the build of a number of defconfigs, with errors such as:

fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory

Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations avoids this problem, and fixes the build of several defconfigs.

[--SNIP--]

linux/linux.mk define LINUX_BUILD_CMDS · line 447

Quoted 10 lines
linux/linux.mk +1 -1
index 1eac3287ab..dca3d63cd9 100644
@@ -444,7 +444,8 @@ define LINUX_BUILD_CMDS
 	$(foreach dts,$(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)), \
 		cp -f $(dts) $(LINUX_ARCH_PATH)/boot/dts/
 	)
-	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all $(LINUX_TARGET_NAME)
+	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all

Usually, it is not necessary to specify the 'all' target, as this is the default. So, I would just drop it.

I don't have a striong feeling either way, though, and I can see value in aving an explicit 'all' call.

However, What I'd like to see added is a comment that states we can't have a single call:

    # Having 'all' and '$(LINUX_TARGET_NAME)' in the same call is not parallel-safe

(so that we do not try to "simplify" it back in the future.)

Otherwise:

    Reviewed-by: "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 7 lines
linux/linux.mk +1 -0
+	$(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_TARGET_NAME)
 	$(LINUX_BUILD_DTB)
 	$(LINUX_APPEND_DTB)
 endef
Signature · 1 line
2.20.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/5 linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets

In reply to Thomas Petazzoni
Quoted 35 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:

  make all $(LINUX_TARGET_NAME)

Unfortunately, it turns out that it breaks the build of a number of defconfigs, with errors such as:

fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory

Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations avoids this problem, and fixes the build of several defconfigs.

Fixes:

ts7680_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339583

qemu_xtensa_lx60_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339553

roseapplepi_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339564

qemu_xtensa_lx60_nommu_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339554

qemu_ppc64_e5500_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339539

freescale_t2080_qds_rdb_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339455

Quoted 7 lines

arcturus_ucp1020_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339399

Cc "Yann E. MORIN" <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 2/5 configs/beaglebone: kernel build needs mkimage

In reply to Thomas Petazzoni

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig builds more things, including some .itb files, which require mkimage with FIT support.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433

---
 configs/beaglebone_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/beaglebone_defconfig +2 -0
index 2d9fba57dd..b4f152fd69 100644
@@ -26,3 +26,5 @@ BR2_TARGET_UBOOT_SPL_NAME="MLO"
 BR2_PACKAGE_HOST_DOSFSTOOLS=y
 BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
Signature · 1 line
2.20.1
#5 lore raw

PATCH 2/5 configs/beaglebone: kernel build needs mkimage

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig builds more things, including some .itb files, which require mkimage with FIT support.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433

Regards,
Yann E. MORIN.

Quoted 17 lines
---
 configs/beaglebone_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/beaglebone_defconfig +2 -0
index 2d9fba57dd..b4f152fd69 100644
@@ -26,3 +26,5 @@ BR2_TARGET_UBOOT_SPL_NAME="MLO"
 BR2_PACKAGE_HOST_DOSFSTOOLS=y
 BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
Signature · 1 line
2.20.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH 2/5 configs/beaglebone: kernel build needs mkimage

In reply to Thomas Petazzoni
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig builds more things, including some .itb files, which require mkimage with FIT support.

Quoted 5 lines

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 3/5 configs/qemu_nios2_10m50: kernel build needs mkimage

In reply to Thomas Petazzoni

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_nios2_10m50_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537

---
 configs/qemu_nios2_10m50_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_nios2_10m50_defconfig +3 -0
index d7e7c335a3..c07abc3715 100644
@@ -8,3 +8,6 @@ BR2_TARGET_ROOTFS_INITRAMFS=y
 
 # Linux headers same as kernel, a 4.19 series
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
#8 lore raw

PATCH 3/5 configs/qemu_nios2_10m50: kernel build needs mkimage

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 9 lines

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_nios2_10m50_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537

Regards,
Yann E. MORIN.

Quoted 18 lines
---
 configs/qemu_nios2_10m50_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_nios2_10m50_defconfig +3 -0
index d7e7c335a3..c07abc3715 100644
@@ -8,3 +8,6 @@ BR2_TARGET_ROOTFS_INITRAMFS=y
 
 # Linux headers same as kernel, a 4.19 series
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#9 lore raw

PATCH 3/5 configs/qemu_nios2_10m50: kernel build needs mkimage

In reply to Thomas Petazzoni
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_nios2_10m50_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 4/5 configs/qemu_ppc_mpc8544ds: kernel build needs mkimage

In reply to Thomas Petazzoni

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_mpc8544ds_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543

---
 configs/qemu_ppc_mpc8544ds_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_ppc_mpc8544ds_defconfig +3 -0
index d6ebef7561..98985b7b76 100644
@@ -23,3 +23,6 @@ BR2_LINUX_KERNEL_VMLINUX=y
 # Serial port config
 BR2_TARGET_GENERIC_GETTY=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
#11 lore raw

PATCH 4/5 configs/qemu_ppc_mpc8544ds: kernel build needs mkimage

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_mpc8544ds_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543

Regards,
Yann E. MORIN.

Quoted 18 lines
---
 configs/qemu_ppc_mpc8544ds_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_ppc_mpc8544ds_defconfig +3 -0
index d6ebef7561..98985b7b76 100644
@@ -23,3 +23,6 @@ BR2_LINUX_KERNEL_VMLINUX=y
 # Serial port config
 BR2_TARGET_GENERIC_GETTY=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#12 lore raw

PATCH 4/5 configs/qemu_ppc_mpc8544ds: kernel build needs mkimage

In reply to Thomas Petazzoni
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_mpc8544ds_defconfig builds an image format that needs mkimage.

Quoted 5 lines

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#13 lore raw

PATCH 5/5 configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

In reply to Thomas Petazzoni

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_virtex_ml507_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544

---
 configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_ppc_virtex_ml507_defconfig +3 -0
index c71465dd56..eddaf3558a 100644
@@ -21,3 +21,6 @@ BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-virtex-ml507/linux.config"
 BR2_LINUX_KERNEL_VMLINUX=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="virtex440-ml507"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
#14 lore raw

PATCH 5/5 configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_virtex_ml507_defconfig builds an image format that needs mkimage.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544

Regards,
Yann E. MORIN.

Quoted 18 lines
---
 configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/qemu_ppc_virtex_ml507_defconfig +3 -0
index c71465dd56..eddaf3558a 100644
@@ -21,3 +21,6 @@ BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-virtex-ml507/linux.config"
 BR2_LINUX_KERNEL_VMLINUX=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="virtex440-ml507"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#15 lore raw

PATCH 5/5 configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

In reply to Thomas Petazzoni
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify LINUX_BUILD_CMDS"), the Linux kernel build for qemu_ppc_virtex_ml507_defconfig builds an image format that needs mkimage.

Quoted 5 lines

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#16 lore raw

cover Fix fallouts from LINUX_BUILD_CMDS simplification

In reply to Thomas Petazzoni

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 8 lines

- Due to calling "make all", a little bit more might get built, and sometimes this "little bit more" needs mkimage, so we add host-uboot-tools to the defconfig. This is enough as linux/linux.mk automatically adds host-uboot-tools to its dependency if it's enabled. I hesitated with adding an explicit BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this sounds better or if the proposed solution in this patch series is good enough.

Ithink the NEEDS_FOO options are only interesting when the host package does not have a kconfig option of its own.

In this case, I think it is correct to do as you did.

If linux did not have a conditional dependency on host-uboot-tools, then it should be added, rather than add a NEEDS_HOST_UBOOT_TOOLS.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#17 lore raw

cover Fix fallouts from LINUX_BUILD_CMDS simplification

In reply to Thomas Petazzoni
Quoted 6 lines · On Mon, 22 Apr 2019 22:08:24 +0200 Thomas Petazzoni…

Thomas Petazzoni (5):
linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets configs/beaglebone: kernel build needs mkimage configs/qemu_nios2_10m50: kernel build needs mkimage configs/qemu_ppc_mpc8544ds: kernel build needs mkimage configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

I've applied the series, after adding a comment in linux.mk in PATCH 1/5, as suggested by Yann.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com