Skip to contentSkip to conversation

mxs-bootloader: Barebox entry point symbol changed in 2012.08

PATCH New Maxime Ripard 4 participants 8 messages Oct 18, 2012 – Nov 17, 2012 Arm i.MX and Layerscape

lore
Share & tools
lore

Maxime Ripard

author
#0 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

Signed-off-by Maxime Ripard <[email protected]>
---
 boot/mxs-bootlets/barebox_ivt.bd |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/mxs-bootlets/barebox_ivt.bd +1 -1
index e02ddd6..0c67e9c 100644
@@ -28,7 +28,7 @@ section (0) {
 	//----------------------------------------------------------
 
         load barebox;
-        load ivt (entry = barebox:exception_vectors) > 0x8000;
+        load ivt (entry = barebox:start) > 0x8000;
 	hab call 0x8000;
 
 }
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

Quoted 10 lines · Maxime Ripard
Signed-off-by Maxime Ripard<[email protected]>
---
  boot/mxs-bootlets/barebox_ivt.bd |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
boot/mxs-bootlets/barebox_ivt.bd +0 -0
index e02ddd6..0c67e9c 100644

boot/mxs-bootlets/barebox_ivt.bd section (0) { · line 34

Quoted 8 lines
boot/mxs-bootlets/barebox_ivt.bd +1 -1
@@ -28,7 +28,7 @@ section (0) {
  	//----------------------------------------------------------
 
          load barebox;
-        load ivt (entry = barebox:exception_vectors)>  0x8000;
+        load ivt (entry = barebox:start)>  0x8000;
  	hab call 0x8000;
 
  }

Shouldn't this somehow depend on the selected barebox version then?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#2 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

Hi Arnout,

Le 18/10/2012 21:53, Arnout Vandecappelle a ?crit :

Quoted 14 lines · Maxime Ripard
Quoted 13 lines
Signed-off-by Maxime Ripard<[email protected]>
---
  boot/mxs-bootlets/barebox_ivt.bd |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
boot/mxs-bootlets/barebox_ivt.bd +0 -0
index e02ddd6..0c67e9c 100644
@@ -28,7 +28,7 @@ section (0) {
      //----------------------------------------------------------
Quoted 8 lines

boot/mxs-bootlets/barebox_ivt.bd section (0) { · line 34

Quoted 6 lines
boot/mxs-bootlets/barebox_ivt.bd +1 -1
          load barebox;
-        load ivt (entry = barebox:exception_vectors)>  0x8000;
+        load ivt (entry = barebox:start)>  0x8000;
      hab call 0x8000;
 
  }

Shouldn't this somehow depend on the selected barebox version then?

Well, I thought so at first, but since the next barebox release is in less than two weeks now, and the 2012.07 (the only one we support that is still using exception_vectors symbol) will be removed at that time, so I finally gave up to write that code, just to have it removed/be irrelevant in two weeks.

Maxime

Signature · 4 lines
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

In reply to Arnout Vandecappelle
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

load barebox;

(quoted diff) +1 -1
-        load ivt (entry = barebox:exception_vectors)>  0x8000;
+        load ivt (entry = barebox:start)>  0x8000;

hab call 0x8000;

}

Arnout> Shouldn't this somehow depend on the selected barebox version then?

Indeed. What happens if people use <2012.08?

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

Le 19/10/2012 11:00, Peter Korsgaard a ?crit :

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

load barebox;

(quoted diff) +1 -1
-        load ivt (entry = barebox:exception_vectors)>  0x8000;
+        load ivt (entry = barebox:start)>  0x8000;

hab call 0x8000;

Quoted 5 lines
Quoted 1 line
Quoted 1 line

}

Arnout> Shouldn't this somehow depend on the selected barebox version then?

Indeed. What happens if people use <2012.08?

It will fail to execute barebox, and will loop trying to execute it. But once again, if things go as usual, this is only a matter of two weeks...

I can resubmit in two weeks if you prefer.

Signature · 4 lines
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#5 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

In reply to Maxime Ripard

Hi Peter,

Le 18/10/2012 10:02, Maxime Ripard a ?crit :

Quoted 10 lines
Signed-off-by Maxime Ripard <[email protected]>
---
 boot/mxs-bootlets/barebox_ivt.bd |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/mxs-bootlets/barebox_ivt.bd +0 -0
index e02ddd6..0c67e9c 100644

boot/mxs-bootlets/barebox_ivt.bd section (0) { · line 34

Quoted 8 lines
boot/mxs-bootlets/barebox_ivt.bd +1 -1
@@ -28,7 +28,7 @@ section (0) {
 	//----------------------------------------------------------
 
         load barebox;
-        load ivt (entry = barebox:exception_vectors) > 0x8000;
+        load ivt (entry = barebox:start) > 0x8000;
 	hab call 0x8000;
 
 }

Can we apply this patch now that all supported barebox versions have this entry point ?

Thanks,
Maxime

Signature · 4 lines
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 mxs-bootloader: Barebox entry point symbol changed in 2012.08

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Ripard <[email protected]> writes:

load barebox;

boot/mxs-bootlets/barebox_ivt.bd +1 -1
-        load ivt (entry = barebox:exception_vectors) > 0x8000;
+        load ivt (entry = barebox:start) > 0x8000;

hab call 0x8000;

}

Maxime> Can we apply this patch now that all supported barebox versions have Maxime> this entry point ?

Yes, will do so now. Thanks for reminding me.

Signature · 1 line
Bye, Peter Korsgaard