Skip to contentSkip to conversation

arm64: dts: mediatek: mt7986: drop "#clock-cells" from PWM

PATCH In review Rafał Miłecki 2 participants 3 messages Jan 1, 2024 – Jan 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: mediatek: mt7986: drop "#clock-cells" from PWM

From: Rafał Miłecki <[email protected]>

PWM is not a clock provider and its binding doesn't specify "#clock-cells" property.

This fixes:
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm@10048000: '#clock-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pwm/mediatek,mt2712-pwm.yaml#

Fixes eabb04df46c6 ("arm64: dts: mt7986: add PWM")
Cc Daniel Golle <[email protected]>
---
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7986a.dtsi +0 -1
index 6caac6ebede4..8a64d1027c46 100644
@@ -196,7 +196,6 @@ pio: pinctrl@1001f000 {
 		pwm: pwm@10048000 {
 			compatible = "mediatek,mt7986-pwm";
 			reg = <0 0x10048000 0 0x1000>;
-			#clock-cells = <1>;
 			#pwm-cells = <2>;
 			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&topckgen CLK_TOP_PWM_SEL>,
Signature · 1 line
2.35.3
#1 lore raw

PATCH 2/2 arm64: dts: mediatek: mt7986: add "#reset-cells" to infracfg

From: Rafał Miłecki <[email protected]>

MT7986's Infrastructure System Configuration Controller includes reset controller. It can reset blocks as specified in the include/dt-bindings/reset/mt7986-resets.h . Add #reset-cells so it can be referenced properly.

This fixes:
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: infracfg@10001000: '#reset-cells' is a required property
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,infracfg.yaml#

Fixes 1f9986b258c2 ("arm64: dts: mediatek: add clock support for mt7986a")
Cc Sam Shih <[email protected]>
---
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/mediatek/mt7986a.dtsi +1 -0
index 8a64d1027c46..b3f416b9a7a4 100644
@@ -144,6 +144,7 @@ infracfg: infracfg@10001000 {
 			compatible = "mediatek,mt7986-infracfg", "syscon";
 			reg = <0 0x10001000 0 0x1000>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		wed_pcie: wed-pcie@10003000 {
Signature · 1 line
2.35.3
maintainer
#2 lore raw
In reply to Rafał Miłecki
Quoted 5 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

PWM is not a clock provider and its binding doesn't specify "#clock-cells" property.

Quoted 7 lines

This fixes:
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm@10048000: '#clock-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pwm/mediatek,mt2712-pwm.yaml#

Fixes eabb04df46c6 ("arm64: dts: mt7986: add PWM")
Cc Daniel Golle <[email protected]>

Both patches applied, thanks!

Quoted 16 lines
---
  arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 -
  1 file changed, 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7986a.dtsi +0 -1
index 6caac6ebede4..8a64d1027c46 100644
@@ -196,7 +196,6 @@ pio: pinctrl@1001f000 {
  		pwm: pwm@10048000 {
  			compatible = "mediatek,mt7986-pwm";
  			reg = <0 0x10048000 0 0x1000>;
-			#clock-cells = <1>;
  			#pwm-cells = <2>;
  			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
  			clocks = <&topckgen CLK_TOP_PWM_SEL>,