package/android-tools: host-android-tools need pkg-conf
PATCH 1/1 package/android-tools: host-android-tools need pkg-conf
Host version of this package needs pkg-conf the same way as target
package: for Makefiles library dependencies retrieving.
Set HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES) to provide host-pkg-conf.
Fixes:
http://autobuild.buildroot.net/results/854/8543eb3815a67747349a2e60654d19b9804a3a89/
--- package/android-tools/android-tools.mk | 1 + 1 file changed, 1 insertion(+)
package/android-tools/android-tools.mk +1 -0
@@ -12,6 +12,7 @@ HOST_ANDROID_TOOLS_EXTRA_DOWNLOADS = $(ANDROID_TOOLS_EXTRA_DOWNLOADS) ANDROID_TOOLS_LICENSE = Apache-2.0 ANDROID_TOOLS_LICENSE_FILES = debian/copyright ANDROID_TOOLS_DEPENDENCIES = host-pkgconf +HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES) # Extract the Debian tarball inside the sources define ANDROID_TOOLS_DEBIAN_EXTRACT
Signature · 1 line
2.17.1
PATCH 1/1 package/android-tools: host-android-tools need pkg-conf
Hello,
Quoted 2 lines · On Tue, 9 Apr 2019 15:17:54 +0200 Giulio Benetti…
ANDROID_TOOLS_DEPENDENCIES= host-pkgconf
+HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES)
We don't typically re-use the target dependencies variable for the host dependencies. So I changed this to = host-pkgconf and applied.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/android-tools: host-android-tools need pkg-conf
Quoted 2 lines · On Thu, 11 Apr 2019 08:22:18 +0200 Thomas Petazzoni…
We don't typically re-use the target dependencies variable for the host dependencies. So I changed this to = host-pkgconf and applied.
An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't do what you think it does:
$ cat foo.mk FOO_DEPENDENCIES = host-pkgconf HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES)
FOO_DEPENDENCIES += zlibHOST_FOO_DEPENDENCIES += host-zlib
all:
@echo $(FOO_DEPENDENCIES) @echo $(HOST_FOO_DEPENDENCIES) $ make -f foo.mk host-pkgconf zlib host-pkgconf zlib host-zlib
See how HOST_FOO_DEPENDENCIES contains "zlib" ?
= assignments are evaluated at the time of use, not at the time of assignment (contrary to := assignments).
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/android-tools: host-android-tools need pkg-conf
Hello Thomas,
Il 11/04/2019 08:25, Thomas Petazzoni ha scritto:
Quoted 23 lines
Quoted 2 lines · On Thu, 11 Apr 2019 08:22:18 +0200 Thomas Petazzoni…
We don't typically re-use the target dependencies variable for the host dependencies. So I changed this to = host-pkgconf and applied.
An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't do what you think it does:
$ cat foo.mk FOO_DEPENDENCIES = host-pkgconf HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES)
FOO_DEPENDENCIES+= zlibHOST_FOO_DEPENDENCIES+= host-zliball:
@echo $(FOO_DEPENDENCIES) @echo $(HOST_FOO_DEPENDENCIES) $ make -f foo.mk host-pkgconf zlib host-pkgconf zlib host-zlib
Quoted 4 lines
See how
HOST_FOO_DEPENDENCIEScontains "zlib" ?= assignments are evaluated at the time of use, not at the time of assignment (contrary to := assignments).
Aah, this is why, '=' vs ':='. Thank you for the explanation.
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/1 package/android-tools: host-android-tools need pkg-conf
In reply to Giulio BenettiQuoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
Host version of this package needs pkg-conf the same way as target
package: for Makefiles library dependencies retrieving.
Quoted 7 lines
Set
HOST_ANDROID_TOOLS_DEPENDENCIES= $(ANDROID_TOOLS_DEPENDENCIES) to provide host-pkg-conf.Fixes:
http://autobuild.buildroot.net/results/854/8543eb3815a67747349a2e60654d19b9804a3a89/Signed-off-by Giulio Benetti <[email protected]>
Committed to 2019.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard