Skip to contentSkip to conversation

fix build regression in qxl-render.c caused by ac86048

PATCH In review Igor Mammedov 4 participants 4 messages Dec 10, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix build regression in qxl-render.c caused by ac86048

fixes regression caused by commit
ac86048 trace: Remove trace.h from console.h (less dependencies)
which makes build fail with:

hw/display/qxl-render.c: In function ‘qxl_blit’:
hw/display/qxl-render.c:34:5: error: implicit declaration of function ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration]

     trace_qxl_render_blit(qxl->guest_primary.qxl_stride,
---
 hw/display/qxl-render.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/qxl-render.c +1 -0
index d34b0c4..84f1367 100644
@@ -20,6 +20,7 @@
  */
 
 #include "qxl.h"
+#include "trace.h"
 
 static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
 {
Signature · 1 line
1.8.3.1
#1 lore raw

I‘m wondering why can't I build qemu successful, I have found the first bad commit with git bisect.
I'm a novice to qemu, I hope I will help you to fix some bugs. Who can introduce some documents to me for the preparing.

Faithfully yours
Kewei Yu

Address : Room 4-308, Building FIT of Tsinghua University
Tel : 13552980886
Msn : [email protected]

2013/12/10 Igor Mammedov <[email protected]>

Quoted 31 lines

fixes regression caused by commit
ac86048 trace: Remove trace.h from console.h (less dependencies)
which makes build fail with:

hw/display/qxl-render.c: In function ‘qxl_blit’:
hw/display/qxl-render.c:34:5: error: implicit declaration of function ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration]

     trace_qxl_render_blit(qxl->guest_primary.qxl_stride,
---
 hw/display/qxl-render.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/qxl-render.c +1 -1
index d34b0c4..84f1367 100644
@@ -20,6 +20,7 @@
  */
 
 #include "qxl.h"
+#include "trace.h"
 
 static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
 {
--

1.8.3.1

#2 lore raw
In reply to Igor Mammedov
Quoted 18 lines · Igor Mammedov

fixes regression caused by commit
ac86048 trace: Remove trace.h from console.h (less dependencies)
which makes build fail with:

hw/display/qxl-render.c: In function ‘qxl_blit’:
hw/display/qxl-render.c:34:5: error: implicit declaration of function ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration]

     trace_qxl_render_blit(qxl->guest_primary.qxl_stride,
---
 hw/display/qxl-render.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/qxl-render.c +0 -0
index d34b0c4..84f1367 100644

hw/display/qxl-render.c line 26

Quoted 7 lines
hw/display/qxl-render.c +1 -0
@@ -20,6 +20,7 @@
  */
 
 #include "qxl.h"
+#include "trace.h"
 
 static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
 {

Fix is pending already:
https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg01314.html

#3 lore raw

I'll commit in a few hours

Regards,

Anthony Liguori

Quoted 33 lines · Markus Armbruster
Quoted 6 lines · Igor Mammedov

fixes regression caused by commit
ac86048 trace: Remove trace.h from console.h (less dependencies)
which makes build fail with:

hw/display/qxl-render.c: In function ‘qxl_blit’:
hw/display/qxl-render.c:34:5: error: implicit declaration of function

‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration]

Quoted 12 lines
     trace_qxl_render_blit(qxl->guest_primary.qxl_stride,
---
 hw/display/qxl-render.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/qxl-render.c +0 -0
index d34b0c4..84f1367 100644

hw/display/qxl-render.c line 26

Quoted 7 lines
hw/display/qxl-render.c +1 -0
@@ -20,6 +20,7 @@
  */
 
 #include "qxl.h"
+#include "trace.h"
 
 static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
 {

Fix is pending already:
https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg01314.html