Odd no-op in sound/pci/hda/patch_sigmatel.c
Hi Takashi
The "spec->gpio_mask &= spec->gpio_mask" on line 571 of sound/pci/hda/patch_sigmatel.c is obviously a no-op. Is that on purpose, or was it supposed to be something else?
Rasmus
At Mon, 05 Jan 2015 13:21:17 +0100,
Quoted 6 lines · Rasmus Villemoes
Hi Takashi
The "
spec->gpio_mask&=spec->gpio_mask" on line 571 ofsound/pci/hda/patch_sigmatel.cis obviously a no-op. Is that on purpose, or was it supposed to be something else?
It's obviously a copy&paste error. The correct code would be:
sound/pci/hda/patch_sigmatel.c +2 -2
@@ -568,9 +568,9 @@ static void stac_store_hints(struct hda_codec *codec) spec->gpio_mask; }if (get_int_hint (codec,"gpio_dir" , &spec->gpio_dir)) - spec->gpio_mask &= spec->gpio_mask; -if (get_int_hint (codec,"gpio_data" , &spec->gpio_data)) spec->gpio_dir &= spec->gpio_mask; +if (get_int_hint (codec,"gpio_data" , &spec->gpio_data)) + spec->gpio_data &= spec->gpio_mask;if (get_int_hint (codec,"eapd_mask" , &spec->eapd_mask)) spec->eapd_mask &= spec->gpio_mask;if (get_int_hint (codec,"gpio_mute" , &spec->gpio_mute))
I'll fix this with your reported-by credit.
thanks,
Takashi