Skip to contentSkip to conversation

Revert "package/systemd: disable portabled"

PATCH Superseded Francois Gervais 4 participants 6 messages Nov 25, 2020 – Nov 26, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

We depend on this feature to dynamically extend the capabilities of our embedded devices.

Also if it makes any difference, portablectl is now in /usr/bin.

This reverts commit b37fa74380557689f2309370c5bc1e770a1831eb.

---
 package/systemd/systemd.mk | 1 -
 1 file changed, 1 deletion(-)
package/systemd/systemd.mk +0 -1
index cb12f667d6..e24c357ccf 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
 	-Dman=false \
 	-Dmount-path=/usr/bin/mount \
 	-Dnss-systemd=true \
-	-Dportabled=false \
 	-Dquotacheck-path=/usr/sbin/quotacheck \
 	-Dquotaon-path=/usr/sbin/quotaon \
 	-Drootlibdir='/usr/lib' \
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

Am Mi., 25. Nov. 2020 um 16:28 Uhr schrieb Francois Gervais <[email protected]>:

Quoted 26 lines

We depend on this feature to dynamically extend the capabilities of our embedded devices.

Also if it makes any difference, portablectl is now in /usr/bin.

This reverts commit b37fa74380557689f2309370c5bc1e770a1831eb.

---
 package/systemd/systemd.mk | 1 -
 1 file changed, 1 deletion(-)
package/systemd/systemd.mk +0 -2
index cb12f667d6..e24c357ccf 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
        -Dman=false \
        -Dmount-path=/usr/bin/mount \
        -Dnss-systemd=true \
-       -Dportabled=false \
        -Dquotacheck-path=/usr/sbin/quotacheck \
        -Dquotaon-path=/usr/sbin/quotaon \
        -Drootlibdir='/usr/lib' \
--
Quoted 2 lines

2.17.1

Better than blindly enabling it, please add an option for doing so. Also, it's still in libexec as of 246 (current release) so the comment is wrong.

Norbert

#2 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

I'm not sure, it's been stated as moved in
https://github.com/systemd/systemd/blob/master/NEWS:

* portablectl is now officially supported and has thus moved to /usr/bin/.

At least since version v240 from what I can see.

Other than that, I'm not against the option to enable it but I mean, it was blindly disabled in the first place right?

From: Norbert Lange <[email protected]>
Sent: November 25, 2020 11:25 AM
To: Gervais, Francois <[email protected]>
Cc: buildroot <[email protected]>; Maxime Hadjinlian <[email protected]>; Yann E . MORIN <[email protected]>
Subject: Re: [PATCH 1/1] Revert "package/systemd: disable portabled"
?
Am Mi., 25. Nov. 2020 um 16:28 Uhr schrieb Francois Gervais
<[email protected]>:

Quoted 26 lines

We depend on this feature to dynamically extend the capabilities of our embedded devices.

Also if it makes any difference, portablectl is now in /usr/bin.

This reverts commit b37fa74380557689f2309370c5bc1e770a1831eb.

---
? package/systemd/systemd.mk | 1 -
? 1 file changed, 1 deletion(-)

package/systemd/systemd.mk +0 -2
index cb12f667d6..e24c357ccf 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
 ???????? -Dman=false \
 ???????? -Dmount-path=/usr/bin/mount \
 ???????? -Dnss-systemd=true \
-?????? -Dportabled=false \
 ???????? -Dquotacheck-path=/usr/sbin/quotacheck \
 ???????? -Dquotaon-path=/usr/sbin/quotaon \
 ???????? -Drootlibdir='/usr/lib' \
--
Quoted 2 lines

2.17.1

Better than blindly enabling it, please add an option for doing so. Also, it's still in libexec as of 246 (current release) so the comment is wrong.

Norbert

#3 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

Am Mi., 25. Nov. 2020 um 18:05 Uhr schrieb Gervais, Francois <[email protected]>:

Quoted 11 lines

I'm not sure, it's been stated as moved in
https://github.com/systemd/systemd/blob/master/NEWS:

* portablectl is now officially supported and has thus moved to /usr/bin/.

At least since version v240 from what I can see.

Other than that, I'm not against the option to enable it but I mean, it was blindly disabled in the first place right?

You are right, I mixed up systemd-portabled and portablectl. The reasons I disabled portabled was that

-   its still labeled as preview at https://systemd.io/PORTABLE_SERVICES/
-   buildroot should attempt to be minimalistic by default
-   no one objected

Norbert

#4 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

I sent a new version of the patch which adds the menu entry.

This patch however has not been marked as Superseded in patchwork.

Is this something manually done by the admins or it there something I should have done differently?

From: Norbert Lange <[email protected]>
Sent: November 25, 2020 1:14 PM
To: Gervais, Francois <[email protected]>
Cc: buildroot <[email protected]>; Maxime Hadjinlian <[email protected]>; Yann E . MORIN <[email protected]>
Subject: Re: [PATCH 1/1] Revert "package/systemd: disable portabled"
?
Am Mi., 25. Nov. 2020 um 18:05 Uhr schrieb Gervais, Francois
<[email protected]>:

You are right, I mixed up systemd-portabled and portablectl. The reasons I disabled portabled was that

-?? its still labeled as preview at https://systemd.io/PORTABLE_SERVICES/
-?? buildroot should attempt to be minimalistic by default -?? no one objected

Norbert

#5 lore raw

PATCH 1/1 Revert "package/systemd: disable portabled"

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gervais," == Gervais, Francois via buildroot <[email protected]> writes:

I sent a new version of the patch which adds the menu entry.

Thanks.

Quoted 4 lines

This patch however has not been marked as Superseded in patchwork.

Is this something manually done by the admins or it there something I should have done differently?

You can create an account yourself:

https://patchwork.ozlabs.org/register/

And update the state of your patches, but I have done it for this patch already.

Signature · 1 line
Bye, Peter Korsgaard