Skip to contentSkip to conversation

VBT "generic DTD" block

PATCH Superseded Matt Roper 5 participants 11 messages Nov 14, 2019 – Nov 15, 2019

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

v4 cover VBT "generic DTD" block

VBT revision 229 introduces a new "Generic DTD" block to define monitor timing information and deprecates the old LFP panel mode data we've been using until now.

v4: Rebase & resend; patchwork got a bit confused by the threading when
v3 was sent and it fell through the cracks.

Matt Roper (2):
drm/i915/vbt: Parse panel options separately from timing data drm/i915/vbt: Handle generic DTD block

 drivers/gpu/drm/i915/display/intel_bios.c     | 111 ++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_vbt_defs.h |  31 +++++
 2 files changed, 132 insertions(+), 10 deletions(-)
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH v4 1/2 drm/i915/vbt: Parse panel options separately from timing data

Newer VBT versions will add an alternate way to read panel DTD information, so let's split parsing of the general panel information from the timing data in preparation.

---
 drivers/gpu/drm/i915/display/intel_bios.c | 27 +++++++++++++++--------
 1 file changed, 18 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +18 -9
index 6d7b1a83cb07..d13ce0b7db8b 100644
@@ -208,17 +208,12 @@ get_lvds_fp_timing(const struct bdb_header *bdb,
 	return (const struct lvds_fp_timing *)((const u8 *)bdb + ofs);
 }
 
-/* Try to find integrated panel data */
+/* Parse general panel options */
 static void
-parse_lfp_panel_data(struct drm_i915_private *dev_priv,
-		     const struct bdb_header *bdb)
+parse_panel_options(struct drm_i915_private *dev_priv,
+		    const struct bdb_header *bdb)
 {
 	const struct bdb_lvds_options *lvds_options;
-	const struct bdb_lvds_lfp_data *lvds_lfp_data;
-	const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
-	const struct lvds_dvo_timing *panel_dvo_timing;
-	const struct lvds_fp_timing *fp_timing;
-	struct drm_display_mode *panel_fixed_mode;
 	int panel_type;
 	int drrs_mode;
 	int ret;
@@ -267,6 +262,19 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
 		DRM_DEBUG_KMS("DRRS not supported (VBT input)\n");
 		break;
 	}
+}
+
+/* Try to find integrated panel timing data */
+static void
+parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
+		    const struct bdb_header *bdb)
+{
+	const struct bdb_lvds_lfp_data *lvds_lfp_data;
+	const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
+	const struct lvds_dvo_timing *panel_dvo_timing;
+	const struct lvds_fp_timing *fp_timing;
+	struct drm_display_mode *panel_fixed_mode;
+	int panel_type = dev_priv->vbt.panel_type;
 
 	lvds_lfp_data = find_section(bdb, BDB_LVDS_LFP_DATA);
 	if (!lvds_lfp_data)
@@ -1868,7 +1876,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 	/* Grab useful general definitions */
 	parse_general_features(dev_priv, bdb);
 	parse_general_definitions(dev_priv, bdb);
-	parse_lfp_panel_data(dev_priv, bdb);
+	parse_panel_options(dev_priv, bdb);
+	parse_lfp_panel_dtd(dev_priv, bdb);
 	parse_lfp_backlight(dev_priv, bdb);
 	parse_sdvo_panel_data(dev_priv, bdb);
 	parse_driver_features(dev_priv, bdb);
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] drm/i915/vbt: Parse panel options separately from timing data

LGTM.

Quoted 69 lines · Matt Roper

Newer VBT versions will add an alternate way to read panel DTD information, so let's split parsing of the general panel information from the timing data in preparation.

---
 drivers/gpu/drm/i915/display/intel_bios.c | 27 +++++++++++++++--------
 1 file changed, 18 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +18 -10
index 6d7b1a83cb07..d13ce0b7db8b 100644
@@ -208,17 +208,12 @@ get_lvds_fp_timing(const struct bdb_header *bdb,
        return (const struct lvds_fp_timing *)((const u8 *)bdb + ofs);
 }
 
-/* Try to find integrated panel data */
+/* Parse general panel options */
 static void
-parse_lfp_panel_data(struct drm_i915_private *dev_priv,
-                    const struct bdb_header *bdb)
+parse_panel_options(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb)
 {
        const struct bdb_lvds_options *lvds_options;
-       const struct bdb_lvds_lfp_data *lvds_lfp_data;
-       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
-       const struct lvds_dvo_timing *panel_dvo_timing;
-       const struct lvds_fp_timing *fp_timing;
-       struct drm_display_mode *panel_fixed_mode;
        int panel_type;
        int drrs_mode;
        int ret;
@@ -267,6 +262,19 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
                DRM_DEBUG_KMS("DRRS not supported (VBT input)\n");
                break;
        }
+}
+
+/* Try to find integrated panel timing data */
+static void
+parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb)
+{
+       const struct bdb_lvds_lfp_data *lvds_lfp_data;
+       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
+       const struct lvds_dvo_timing *panel_dvo_timing;
+       const struct lvds_fp_timing *fp_timing;
+       struct drm_display_mode *panel_fixed_mode;
+       int panel_type = dev_priv->vbt.panel_type;
 
        lvds_lfp_data = find_section(bdb, BDB_LVDS_LFP_DATA);
        if (!lvds_lfp_data)
@@ -1868,7 +1876,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
        /* Grab useful general definitions */
        parse_general_features(dev_priv, bdb);
        parse_general_definitions(dev_priv, bdb);
-       parse_lfp_panel_data(dev_priv, bdb);
+       parse_panel_options(dev_priv, bdb);
+       parse_lfp_panel_dtd(dev_priv, bdb);
        parse_lfp_backlight(dev_priv, bdb);
        parse_sdvo_panel_data(dev_priv, bdb);
        parse_driver_features(dev_priv, bdb);
--

2.21.0

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: [PATCH v4 1/2] drm/i915/vbt: Parse panel options separately from timing data

HI,

Quoted 9 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Jesse Barnes
Sent: perjantai 15. marraskuuta 2019 2.05
To: Roper, Matthew D <[email protected]>
Cc: Nikula, Jani <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/vbt: Parse panel options separately from timing data

Quoted 3 lines

LGTM.

Thanks Jesse 😉

Quoted 74 lines

drivers/gpu/drm/i915/display/intel_bios.c parse_lfp_panel_data(struct drm_i915_private

Quoted 39 lines · Matt Roper

Newer VBT versions will add an alternate way to read panel DTD information, so let's split parsing of the general panel information from the timing data in preparation.

---
 drivers/gpu/drm/i915/display/intel_bios.c | 27
+++++++++++++++--------
 1 file changed, 18 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +3 -8
index 6d7b1a83cb07..d13ce0b7db8b 100644
@@ -208,17 +208,12 @@ get_lvds_fp_timing(const struct bdb_header *bdb,
        return (const struct lvds_fp_timing *)((const u8 *)bdb + ofs);
 }
 
-/* Try to find integrated panel data */
+/* Parse general panel options */
 static void
-parse_lfp_panel_data(struct drm_i915_private *dev_priv,
-                    const struct bdb_header *bdb)
+parse_panel_options(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb)
 {
        const struct bdb_lvds_options *lvds_options;
-       const struct bdb_lvds_lfp_data *lvds_lfp_data;
-       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
-       const struct lvds_dvo_timing *panel_dvo_timing;
-       const struct lvds_fp_timing *fp_timing;
-       struct drm_display_mode *panel_fixed_mode;
        int panel_type;
        int drrs_mode;
        int ret;
@@ -267,6 +262,19 @@ parse_lfp_panel_data(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_bios.c void intel_bios_init(struct drm_i915_private

Quoted 18 lines
drivers/gpu/drm/i915/display/intel_bios.c +11 -0
                DRM_DEBUG_KMS("DRRS not supported (VBT input)\n");
                break;
        }
+}
+
+/* Try to find integrated panel timing data */ static void
+parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb) {
+       const struct bdb_lvds_lfp_data *lvds_lfp_data;
+       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
+       const struct lvds_dvo_timing *panel_dvo_timing;
+       const struct lvds_fp_timing *fp_timing;
+       struct drm_display_mode *panel_fixed_mode;
+       int panel_type = dev_priv->vbt.panel_type;
 
        lvds_lfp_data = find_section(bdb, BDB_LVDS_LFP_DATA);
        if (!lvds_lfp_data)
@@ -1868,7 +1876,8 @@ void intel_bios_init(struct drm_i915_private

*dev_priv)

Quoted 12 lines
drivers/gpu/drm/i915/display/intel_bios.c +2 -2
        /* Grab useful general definitions */
        parse_general_features(dev_priv, bdb);
        parse_general_definitions(dev_priv, bdb);
-       parse_lfp_panel_data(dev_priv, bdb);
+       parse_panel_options(dev_priv, bdb);
+       parse_lfp_panel_dtd(dev_priv, bdb);
        parse_lfp_backlight(dev_priv, bdb);
        parse_sdvo_panel_data(dev_priv, bdb);
        parse_driver_features(dev_priv, bdb);
--

2.21.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [PATCH v4 1/2] drm/i915/vbt: Parse panel options separately from timing data

In reply to Jesse Barnes
Quoted 3 lines · Jesse Barnes

LGTM.

Yay!

LGTM too.

Quoted 79 lines · Matt Roper
Quoted 69 lines

Newer VBT versions will add an alternate way to read panel DTD information, so let's split parsing of the general panel information from the timing data in preparation.

---
 drivers/gpu/drm/i915/display/intel_bios.c | 27 +++++++++++++++--------
 1 file changed, 18 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +18 -10
index 6d7b1a83cb07..d13ce0b7db8b 100644
@@ -208,17 +208,12 @@ get_lvds_fp_timing(const struct bdb_header *bdb,
        return (const struct lvds_fp_timing *)((const u8 *)bdb + ofs);
 }
 
-/* Try to find integrated panel data */
+/* Parse general panel options */
 static void
-parse_lfp_panel_data(struct drm_i915_private *dev_priv,
-                    const struct bdb_header *bdb)
+parse_panel_options(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb)
 {
        const struct bdb_lvds_options *lvds_options;
-       const struct bdb_lvds_lfp_data *lvds_lfp_data;
-       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
-       const struct lvds_dvo_timing *panel_dvo_timing;
-       const struct lvds_fp_timing *fp_timing;
-       struct drm_display_mode *panel_fixed_mode;
        int panel_type;
        int drrs_mode;
        int ret;
@@ -267,6 +262,19 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
                DRM_DEBUG_KMS("DRRS not supported (VBT input)\n");
                break;
        }
+}
+
+/* Try to find integrated panel timing data */
+static void
+parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
+                   const struct bdb_header *bdb)
+{
+       const struct bdb_lvds_lfp_data *lvds_lfp_data;
+       const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
+       const struct lvds_dvo_timing *panel_dvo_timing;
+       const struct lvds_fp_timing *fp_timing;
+       struct drm_display_mode *panel_fixed_mode;
+       int panel_type = dev_priv->vbt.panel_type;
 
        lvds_lfp_data = find_section(bdb, BDB_LVDS_LFP_DATA);
        if (!lvds_lfp_data)
@@ -1868,7 +1876,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
        /* Grab useful general definitions */
        parse_general_features(dev_priv, bdb);
        parse_general_definitions(dev_priv, bdb);
-       parse_lfp_panel_data(dev_priv, bdb);
+       parse_panel_options(dev_priv, bdb);
+       parse_lfp_panel_dtd(dev_priv, bdb);
        parse_lfp_backlight(dev_priv, bdb);
        parse_sdvo_panel_data(dev_priv, bdb);
        parse_driver_features(dev_priv, bdb);
--

2.21.0

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#5 lore raw

PATCH v4 2/2 drm/i915/vbt: Handle generic DTD block

In reply to Matt Roper

VBT revision 229 adds a new "Generic DTD" block 58 and deprecates the old LFP panel mode data in block 42. Let's start parsing this block to fill in the panel fixed mode on devices with a >=229 VBT.

v2:
* Update according to the recent updates:
- DTD size is now 16 bits instead of 24
- polarity is now just a single bit for hsync and vsync and is properly documented
* Minor checkpatch fix

v3:
* Now that panel options are parsed separately from the previous patch, move generic DTD parsing into a function parallel to parse_lfp_panel_dtd. We'll still fall back to looking at the legacy LVDS timing block if the generic DTD fails. (Jani)
* Don't forget to actually set lfp_lvds_vbt_mode! (Jani)
* Drop "bdb_" prefix from dtd entry structure. (Jani)
* Follow C99 standard for structure's flexible array member. (Jani)

Bspec: 54751
Bspec: 20148

---
 drivers/gpu/drm/i915/display/intel_bios.c     | 86 ++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 31 +++++++
 2 files changed, 115 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +84 -2
index d13ce0b7db8b..3b66160fd3c4 100644
@@ -296,7 +296,7 @@ parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
 
 	dev_priv->vbt.lfp_lvds_vbt_mode = panel_fixed_mode;
 
-	DRM_DEBUG_KMS("Found panel mode in BIOS VBT tables:\n");
+	DRM_DEBUG_KMS("Found panel mode in BIOS VBT legacy lfp table:\n");
 	drm_mode_debug_printmodeline(panel_fixed_mode);
 
 	fp_timing = get_lvds_fp_timing(bdb, lvds_lfp_data,
@@ -313,6 +313,81 @@ parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
 	}
 }
 
+static void
+parse_generic_dtd(struct drm_i915_private *dev_priv,
+		  const struct bdb_header *bdb)
+{
+	const struct bdb_generic_dtd *generic_dtd;
+	const struct generic_dtd_entry *dtd;
+	struct drm_display_mode *panel_fixed_mode;
+	int num_dtd;
+
+	generic_dtd = find_section(bdb, BDB_GENERIC_DTD);
+	if (!generic_dtd)
+		return;
+
+	if (generic_dtd->gdtd_size < sizeof(struct generic_dtd_entry)) {
+		DRM_ERROR("GDTD size %u is too small.\n",
+			  generic_dtd->gdtd_size);
+		return;
+	} else if (generic_dtd->gdtd_size !=
+		   sizeof(struct generic_dtd_entry)) {
+		DRM_ERROR("Unexpected GDTD size %u\n", generic_dtd->gdtd_size);
+		/* DTD has unknown fields, but keep going */
+	}
+
+	num_dtd = (get_blocksize(generic_dtd) -
+		   sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
+	if (dev_priv->vbt.panel_type > num_dtd) {
+		DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
+			  dev_priv->vbt.panel_type, num_dtd);
+		return;
+	}
+
+	dtd = &generic_dtd->dtd[dev_priv->vbt.panel_type];
+
+	panel_fixed_mode = kzalloc(sizeof(*panel_fixed_mode), GFP_KERNEL);
+	if (!panel_fixed_mode)
+		return;
+
+	panel_fixed_mode->hdisplay = dtd->hactive;
+	panel_fixed_mode->hsync_start =
+		panel_fixed_mode->hdisplay + dtd->hfront_porch;
+	panel_fixed_mode->hsync_end =
+		panel_fixed_mode->hsync_start + dtd->hsync;
+	panel_fixed_mode->htotal = panel_fixed_mode->hsync_end;
+
+	panel_fixed_mode->vdisplay = dtd->vactive;
+	panel_fixed_mode->vsync_start =
+		panel_fixed_mode->vdisplay + dtd->vfront_porch;
+	panel_fixed_mode->vsync_end =
+		panel_fixed_mode->vsync_start + dtd->vsync;
+	panel_fixed_mode->vtotal = panel_fixed_mode->vsync_end;
+
+	panel_fixed_mode->clock = dtd->pixel_clock;
+	panel_fixed_mode->width_mm = dtd->width_mm;
+	panel_fixed_mode->height_mm = dtd->height_mm;
+
+	panel_fixed_mode->type = DRM_MODE_TYPE_PREFERRED;
+	drm_mode_set_name(panel_fixed_mode);
+
+	if (dtd->hsync_polarity)
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_PHSYNC;
+	else
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_NHSYNC;
+
+	if (dtd->vsync_polarity)
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_PVSYNC;
+	else
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_NVSYNC;
+
+	DRM_DEBUG_KMS("Found panel mode in BIOS VBT generic dtd table:\n");
+	drm_mode_debug_printmodeline(panel_fixed_mode);
+
+	dev_priv->vbt.lfp_lvds_vbt_mode = panel_fixed_mode;
+}
+
+
 static void
 parse_lfp_backlight(struct drm_i915_private *dev_priv,
 		    const struct bdb_header *bdb)
@@ -1877,7 +1952,14 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 	parse_general_features(dev_priv, bdb);
 	parse_general_definitions(dev_priv, bdb);
 	parse_panel_options(dev_priv, bdb);
-	parse_lfp_panel_dtd(dev_priv, bdb);
+	if (bdb->version >= 229)
+		/*
+		 * If this fails, we'll fall back to trying to parse the
+		 * legacy LVDS block below.
+		 */
+		parse_generic_dtd(dev_priv, bdb);
+	if (!dev_priv->vbt.lfp_lvds_vbt_mode)
+		parse_lfp_panel_dtd(dev_priv, bdb);
 	parse_lfp_backlight(dev_priv, bdb);
 	parse_sdvo_panel_data(dev_priv, bdb);
 	parse_driver_features(dev_priv, bdb);
drivers/gpu/drm/i915/display/intel_vbt_defs.h +31 -0
index 69a7cb1fa121..41eff2eae211 100644
@@ -115,6 +115,7 @@ enum bdb_block_id {
 	BDB_MIPI_CONFIG			= 52,
 	BDB_MIPI_SEQUENCE		= 53,
 	BDB_COMPRESSION_PARAMETERS	= 56,
+	BDB_GENERIC_DTD			= 58,
 	BDB_SKIP			= 254, /* VBIOS private block, ignore */
 };
 
@@ -863,4 +864,34 @@ struct bdb_compression_parameters {
 	struct dsc_compression_parameters_entry data[16];
 } __packed;
 
+/*
+ * Block 58 - Generic DTD Block
+ */
+
+struct generic_dtd_entry {
+	u32 pixel_clock;
+	u16 hactive;
+	u16 hblank;
+	u16 hfront_porch;
+	u16 hsync;
+	u16 vactive;
+	u16 vblank;
+	u16 vfront_porch;
+	u16 vsync;
+	u16 width_mm;
+	u16 height_mm;
+
+	/* Flags */
+	u8 rsvd_flags:6;
+	u8 vsync_polarity:1;
+	u8 hsync_polarity:1;
+
+	u32 rsvd:24;
+} __packed;
+
+struct bdb_generic_dtd {
+	u16 gdtd_size;
+	struct generic_dtd_entry dtd[];	/* up to 24 DTD's */
+} __packed;
+
 #endif /* _INTEL_VBT_DEFS_H_ */
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v4 2/2
#6 lore raw

Re: [PATCH v4 2/2] drm/i915/vbt: Handle generic DTD block

Quoted 66 lines · Matt Roper

VBT revision 229 adds a new "Generic DTD" block 58 and deprecates the old LFP panel mode data in block 42. Let's start parsing this block to fill in the panel fixed mode on devices with a >=229 VBT.

v2:
* Update according to the recent updates:
- DTD size is now 16 bits instead of 24
- polarity is now just a single bit for hsync and vsync and is properly documented
* Minor checkpatch fix

v3:
* Now that panel options are parsed separately from the previous patch, move generic DTD parsing into a function parallel to parse_lfp_panel_dtd. We'll still fall back to looking at the legacy LVDS timing block if the generic DTD fails. (Jani)
* Don't forget to actually set lfp_lvds_vbt_mode! (Jani)
* Drop "bdb_" prefix from dtd entry structure. (Jani)
* Follow C99 standard for structure's flexible array member. (Jani)

Bspec: 54751
Bspec: 20148

---
 drivers/gpu/drm/i915/display/intel_bios.c     | 86 ++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 31 +++++++
 2 files changed, 115 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +21 -1
index d13ce0b7db8b..3b66160fd3c4 100644
@@ -296,7 +296,7 @@ parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
 
 	dev_priv->vbt.lfp_lvds_vbt_mode = panel_fixed_mode;
 
-	DRM_DEBUG_KMS("Found panel mode in BIOS VBT tables:\n");
+	DRM_DEBUG_KMS("Found panel mode in BIOS VBT legacy lfp table:\n");
 	drm_mode_debug_printmodeline(panel_fixed_mode);
 
 	fp_timing = get_lvds_fp_timing(bdb, lvds_lfp_data,
@@ -313,6 +313,81 @@ parse_lfp_panel_dtd(struct drm_i915_private *dev_priv,
 	}
 }
 
+static void
+parse_generic_dtd(struct drm_i915_private *dev_priv,
+		  const struct bdb_header *bdb)
+{
+	const struct bdb_generic_dtd *generic_dtd;
+	const struct generic_dtd_entry *dtd;
+	struct drm_display_mode *panel_fixed_mode;
+	int num_dtd;
+
+	generic_dtd = find_section(bdb, BDB_GENERIC_DTD);
+	if (!generic_dtd)
+		return;
+
+	if (generic_dtd->gdtd_size < sizeof(struct generic_dtd_entry)) {
+		DRM_ERROR("GDTD size %u is too small.\n",
+			  generic_dtd->gdtd_size);
+		return;
+	} else if (generic_dtd->gdtd_size !=
+		   sizeof(struct generic_dtd_entry)) {
+		DRM_ERROR("Unexpected GDTD size %u\n", generic_dtd->gdtd_size);

drivers/gpu/drm/i915/display/intel_bios.c parse_lfp_panel_dtd(struct drm_i915_private *dev_priv, · line 345

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10 -0
+		/* DTD has unknown fields, but keep going */
+	}
+
+	num_dtd = (get_blocksize(generic_dtd) -
+		   sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
+	if (dev_priv->vbt.panel_type > num_dtd) {
+		DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
+			  dev_priv->vbt.panel_type, num_dtd);
+		return;
+	}

I wonder how many times we've duplicated a version of the dozen or so lines above... Not part of this patch, but we'll need to address this one of these days.

Quoted 19 lines
drivers/gpu/drm/i915/display/intel_bios.c +19 -0
+
+	dtd = &generic_dtd->dtd[dev_priv->vbt.panel_type];
+
+	panel_fixed_mode = kzalloc(sizeof(*panel_fixed_mode), GFP_KERNEL);
+	if (!panel_fixed_mode)
+		return;
+
+	panel_fixed_mode->hdisplay = dtd->hactive;
+	panel_fixed_mode->hsync_start =
+		panel_fixed_mode->hdisplay + dtd->hfront_porch;
+	panel_fixed_mode->hsync_end =
+		panel_fixed_mode->hsync_start + dtd->hsync;
+	panel_fixed_mode->htotal = panel_fixed_mode->hsync_end;
+
+	panel_fixed_mode->vdisplay = dtd->vactive;
+	panel_fixed_mode->vsync_start =
+		panel_fixed_mode->vdisplay + dtd->vfront_porch;
+	panel_fixed_mode->vsync_end =
+		panel_fixed_mode->vsync_start + dtd->vsync;

drivers/gpu/drm/i915/display/intel_bios.c parse_lfp_panel_dtd(struct drm_i915_private *dev_priv, · line 374

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10 -0
+	panel_fixed_mode->vtotal = panel_fixed_mode->vsync_end;
+
+	panel_fixed_mode->clock = dtd->pixel_clock;
+	panel_fixed_mode->width_mm = dtd->width_mm;
+	panel_fixed_mode->height_mm = dtd->height_mm;
+
+	panel_fixed_mode->type = DRM_MODE_TYPE_PREFERRED;
+	drm_mode_set_name(panel_fixed_mode);
+
+	if (dtd->hsync_polarity)

Nitpick, I tend to like bit flags names that say what the value means, i.e. have "positive" in there to indicate the flag set means positive. But we already have the same thing in the old struct. *shrug*

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +6 -0
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_PHSYNC;
+	else
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_NHSYNC;
+
+	if (dtd->vsync_polarity)
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_PVSYNC;

drivers/gpu/drm/i915/display/intel_bios.c parse_lfp_panel_dtd(struct drm_i915_private *dev_priv, · line 390

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +10 -0
+	else
+		panel_fixed_mode->flags |= DRM_MODE_FLAG_NVSYNC;
+
+	DRM_DEBUG_KMS("Found panel mode in BIOS VBT generic dtd table:\n");
+	drm_mode_debug_printmodeline(panel_fixed_mode);
+
+	dev_priv->vbt.lfp_lvds_vbt_mode = panel_fixed_mode;
+}
+
+

Nitpick, double newlines.

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +0 -0
 static void
 parse_lfp_backlight(struct drm_i915_private *dev_priv,
 		    const struct bdb_header *bdb)
@@ -1877,7 +1952,14 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 	parse_general_features(dev_priv, bdb);
 	parse_general_definitions(dev_priv, bdb);

drivers/gpu/drm/i915/display/intel_bios.c void intel_bios_init(struct drm_i915_private *dev_priv) · line 1962

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bios.c +8 -1
 	parse_panel_options(dev_priv, bdb);
-	parse_lfp_panel_dtd(dev_priv, bdb);
+	if (bdb->version >= 229)
+		/*
+		 * If this fails, we'll fall back to trying to parse the
+		 * legacy LVDS block below.
+		 */
+		parse_generic_dtd(dev_priv, bdb);
+	if (!dev_priv->vbt.lfp_lvds_vbt_mode)
+		parse_lfp_panel_dtd(dev_priv, bdb);

Maybe we should abstract that to a helper that branches out to hide it from the top level. Can be left for follow-up.

Quoted 32 lines
drivers/gpu/drm/i915/display/intel_bios.c +0 -0
 	parse_lfp_backlight(dev_priv, bdb);
 	parse_sdvo_panel_data(dev_priv, bdb);
 	parse_driver_features(dev_priv, bdb);
drivers/gpu/drm/i915/display/intel_vbt_defs.h +14 -0
index 69a7cb1fa121..41eff2eae211 100644
@@ -115,6 +115,7 @@ enum bdb_block_id {
 	BDB_MIPI_CONFIG			= 52,
 	BDB_MIPI_SEQUENCE		= 53,
 	BDB_COMPRESSION_PARAMETERS	= 56,
+	BDB_GENERIC_DTD			= 58,
 	BDB_SKIP			= 254, /* VBIOS private block, ignore */
 };
 
@@ -863,4 +864,34 @@ struct bdb_compression_parameters {
 	struct dsc_compression_parameters_entry data[16];
 } __packed;
 
+/*
+ * Block 58 - Generic DTD Block
+ */
+
+struct generic_dtd_entry {
+	u32 pixel_clock;
+	u16 hactive;
+	u16 hblank;
+	u16 hfront_porch;
+	u16 hsync;
+	u16 vactive;
+	u16 vblank;
+	u16 vfront_porch;

drivers/gpu/drm/i915/display/intel_vbt_defs.h struct bdb_compression_parameters { · line 889

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_vbt_defs.h +10 -0
+	u16 vsync;
+	u16 width_mm;
+	u16 height_mm;
+
+	/* Flags */
+	u8 rsvd_flags:6;
+	u8 vsync_polarity:1;
+	u8 hsync_polarity:1;
+
+	u32 rsvd:24;

This does seem to work (and I had to try to believe), but for packed structs I think I'd feel more comfortable grouping bitfields such that the bits fill up the type. Now this depends on the u8 and 24 bits of the u32 to form 4 bytes. Having u32 rsvd:24 does not work independently, and I don't want to risk anyone picking that up and cargo culting incorrectly.

So maybe just u8 rsvd[3] for clarity?

This one I'd like fixed, I'll leave the other nitpicks to your discretion or maybe follow-up patches, and with that,

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_vbt_defs.h +7 -0
+} __packed;
+
+struct bdb_generic_dtd {
+	u16 gdtd_size;
+	struct generic_dtd_entry dtd[];	/* up to 24 DTD's */
+} __packed;
+
 #endif /* _INTEL_VBT_DEFS_H_ */
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

✗ Fi.CI.CHECKPATCH: warning for VBT "generic DTD" block

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: VBT "generic DTD" block
URL : https://patchwork.freedesktop.org/series/69481/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e8777a419776 drm/i915/vbt: Parse panel options separately from timing data
74d6904f889c drm/i915/vbt: Handle generic DTD block
-:122: CHECK:LINE_SPACING: Please don't use multiple blank lines
#122: FILE: drivers/gpu/drm/i915/display/intel_bios.c:390:
+
+

total: 0 errors, 0 warnings, 1 checks, 145 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.BAT: success for VBT "generic DTD" block

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: VBT "generic DTD" block
URL : https://patchwork.freedesktop.org/series/69481/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7345 -> Patchwork_15264
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/index.html

Known issues
------------

Here are the changes found in Patchwork_15264 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6770hq: [PASS][1] -> [WARN][2] ([fdo#112252])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-skl-6770hq/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live_blt:
- fi-hsw-peppy: [DMESG-FAIL][3] ([fdo#112147]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-hsw-peppy/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-hsw-peppy/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][5] ([fdo# 111542]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
- fi-bsw-n3050: [INCOMPLETE][7] ([fdo# 111542]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_hangcheck:
- fi-hsw-4770r: [DMESG-FAIL][9] ([fdo#111991]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html

* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [DMESG-WARN][11] ([fdo#105541]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-skl-6770hq/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-skl-6770hq/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][13] ([fdo#108511]) -> [DMESG-WARN][14] ([fdo#112261])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/fi-skl-6770hq/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/fi-skl-6770hq/igt@[email protected]

[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
[fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147
[fdo#112252]: https://bugs.freedesktop.org/show_bug.cgi?id=112252
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261

Participating hosts (48 -> 45)
------------------------------

Missing (3): fi-byt-clapper fi-bsw-cyan fi-hsw-4200u

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7345 -> Patchwork_15264

CI-20190529: 20190529
CI_DRM_7345: 1f1985fea3361fc4cb461292bd71e3ada311a82b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5284: b28d801e4c010942d05821fada6dd9d2d67d6e4d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15264: 74d6904f889c0408b1281bee7ff57d80929aa534 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

74d6904f889c drm/i915/vbt: Handle generic DTD block e8777a419776 drm/i915/vbt: Parse panel options separately from timing data

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✗ Fi.CI.IGT: failure for VBT "generic DTD" block

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: VBT "generic DTD" block
URL : https://patchwork.freedesktop.org/series/69481/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7345_full -> Patchwork_15264_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15264_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15264_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15264_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_pread@bench:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl3/igt@[email protected]

* igt@syncobj_basic@bad-pad-fd-to-handle:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb5/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_15264_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +11 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@smoketest-all:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111855])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-hsw: [PASS][13] -> [INCOMPLETE][14] ([fdo#103540] / [fdo#112068 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw2/igt@[email protected]

* igt@gem_sync@basic-store-all:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111647])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb6/igt@[email protected]

* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111747]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb9/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb4/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [PASS][21] -> [DMESG-WARN][22] ([fdo#111870])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw6/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111747] / [fdo#111850])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#103232])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([fdo#106107])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend:
- shard-hsw: [PASS][29] -> [INCOMPLETE][30] ([fdo#103540])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][31] -> [INCOMPLETE][32] ([fdo#105411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [PASS][37] -> [INCOMPLETE][38] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb5/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][39] -> [DMESG-WARN][40] ([fdo#108566]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-kbl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-kbl4/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#110038])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][45] -> [FAIL][46] ([fdo#108145] / [fdo#110403])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl9/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109642] / [fdo#111068])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@kms_psr2_su@page_flip.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][51] -> [SKIP][52] ([fdo#109441]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb3/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-iclb: [PASS][53] -> [DMESG-WARN][54] ([fdo#111764])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb3/igt@[email protected]

* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][55] -> [SKIP][56] ([fdo#109276]) +16 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][57] ([fdo#109276] / [fdo#112080]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd:
- shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +6 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-chain-render:
- shard-tglb: [INCOMPLETE][63] ([fdo#111606] / [fdo#111677]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-vebox:
- shard-tglb: [INCOMPLETE][65] ([fdo#111677]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb8/igt@[email protected]

* igt@gem_exec_suspend@basic:
- shard-tglb: [INCOMPLETE][67] ([fdo#111850]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-apl: [TIMEOUT][69] ([fdo#112113]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][71] ([fdo#112037]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-apl: [TIMEOUT][73] ([fdo#112068 ] / [fdo#112113]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl8/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][75] ([fdo#111870]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb2/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-devices:
- shard-tglb: [INCOMPLETE][77] ([fdo#111832] / [fdo#111850]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb9/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][79] ([fdo#104108] / [fdo#107807]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl10/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl10/igt@[email protected]

* igt@kms_color@pipe-a-degamma:
- shard-skl: [FAIL][81] ([fdo#104782] / [fdo#108145]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl5/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][83] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][85] ([fdo#105363]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-glk5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-glk7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][87] ([fdo#108566]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][89] ([fdo#103167]) -> [PASS][90] +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][91] ([fdo#103167]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][93] ([fdo#108566]) -> [PASS][94] +6 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-kbl7/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][95] ([fdo#108145]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl5/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][97] ([fdo#109441]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][99] ([fdo#112080]) -> [PASS][100] +5 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][101] ([fdo#109349]) -> [DMESG-WARN][102] ([fdo#107724])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb3/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#10 lore raw

Re: ✗ Fi.CI.IGT: failure for VBT "generic DTD" block

Quoted 30 lines · Patchwork

== Series Details ==

Series: VBT "generic DTD" block
URL : https://patchwork.freedesktop.org/series/69481/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7345_full -> Patchwork_15264_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15264_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15264_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15264_full:

Quoted 8 lines

### IGT changes ###

#### Possible regressions ####

* igt@gem_pread@bench:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl3/igt@[email protected]

Not sure why this was incomplete, but it was well past the point where the VBT patch would impact anything.

Quoted 5 lines

* igt@syncobj_basic@bad-pad-fd-to-handle:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb5/igt@[email protected]

<4> [1236.243631] This is power.sh, remotely rebooting this machine

Neither of these incompletes are caused by my series. Hitting the re-test button again.

Matt

Quoted 268 lines

Known issues
------------

Here are the changes found in Patchwork_15264_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +11 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@smoketest-all:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111855])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-hsw: [PASS][13] -> [INCOMPLETE][14] ([fdo#103540] / [fdo#112068 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw2/igt@[email protected]

* igt@gem_sync@basic-store-all:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111647])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb6/igt@[email protected]

* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111747]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb9/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb4/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [PASS][21] -> [DMESG-WARN][22] ([fdo#111870])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw6/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111747] / [fdo#111850])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#103232])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([fdo#106107])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend:
- shard-hsw: [PASS][29] -> [INCOMPLETE][30] ([fdo#103540])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-hsw2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-hsw2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][31] -> [INCOMPLETE][32] ([fdo#105411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [PASS][37] -> [INCOMPLETE][38] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb5/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][39] -> [DMESG-WARN][40] ([fdo#108566]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-kbl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-kbl4/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#110038])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][45] -> [FAIL][46] ([fdo#108145] / [fdo#110403])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl9/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109642] / [fdo#111068])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@kms_psr2_su@page_flip.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][51] -> [SKIP][52] ([fdo#109441]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb3/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-iclb: [PASS][53] -> [DMESG-WARN][54] ([fdo#111764])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb3/igt@[email protected]

* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][55] -> [SKIP][56] ([fdo#109276]) +16 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb8/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][57] ([fdo#109276] / [fdo#112080]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd:
- shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +6 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-chain-render:
- shard-tglb: [INCOMPLETE][63] ([fdo#111606] / [fdo#111677]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-vebox:
- shard-tglb: [INCOMPLETE][65] ([fdo#111677]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb8/igt@[email protected]

* igt@gem_exec_suspend@basic:
- shard-tglb: [INCOMPLETE][67] ([fdo#111850]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-apl: [TIMEOUT][69] ([fdo#112113]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][71] ([fdo#112037]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-apl: [TIMEOUT][73] ([fdo#112068 ] / [fdo#112113]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl8/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][75] ([fdo#111870]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-snb4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-snb2/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-devices:
- shard-tglb: [INCOMPLETE][77] ([fdo#111832] / [fdo#111850]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb9/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][79] ([fdo#104108] / [fdo#107807]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl10/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl10/igt@[email protected]

* igt@kms_color@pipe-a-degamma:
- shard-skl: [FAIL][81] ([fdo#104782] / [fdo#108145]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl5/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl6/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][83] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][85] ([fdo#105363]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-glk5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-glk7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][87] ([fdo#108566]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-apl4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][89] ([fdo#103167]) -> [PASS][90] +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][91] ([fdo#103167]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][93] ([fdo#108566]) -> [PASS][94] +6 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-kbl7/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][95] ([fdo#108145]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-skl5/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][97] ([fdo#109441]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][99] ([fdo#112080]) -> [PASS][100] +5 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb5/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][101] ([fdo#109349]) -> [DMESG-WARN][102] ([fdo#107724])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7345/shard-iclb3/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/shard-iclb2/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15264/index.html

Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx