Skip to contentSkip to conversation

ARM: mvebu: Add Netgear ReadyNAS 2120 board

PATCH Superseded Arnaud Ebalard 2 participants 7 messages Nov 12, 2013 – Nov 24, 2013

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports, USB 2.0 front port, Gigabit controller and PHYs for the two rear ports, serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan controllers, G751 temperature sensor) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi,

Initial message:

This one is intended for v3.14. This depends on the recent fix I pushed for mv78230 PCIe and also on a small patch Guenter Roeck just accepted to have lm75 driver support GMT G751 Temperature sensor (see
https://lkml.org/lkml/2013/11/9/273).

Regarding the SATA presence and power pin definitions under pinctrl node if you wonder, I thought it would not harm to have them for reference even though they are currently not used. FWIW, I am currently looking if a GPIO regulator can make any use of those.

Note changed since v2 (i.e. kept for later cleanup session):
- move clocks = <&coreclk 0> in serial node to armada-370-xp.dtsi
- add a label to most SoC nodes to avoid replaying the whole node hierarchy
- see if g762 dt binding can be fixed (no remarks done during review)

Changes since v2:

After Sebastian's comments:
- fixed order of includes (global before local)
- fixed *all* node names to use '-' instead of '_'
- Added Sebastian's Acked-by

Changes since v1:

After Andrew's comment:
- Added comment about G751 function

After Sebastian's comments:
- Changed clock frequency for a clock provider for serial line
- Added compatible string for PHY (marvell,mv88e1318s)
- Removed useless properties in clocks and gpio_keys nodes
- Made G762 clock node name unique by including g762 in it
- Changed values for macros for GPIO voltage level
- Removed comments after GPIOs
- Changed buttons and button pins names

After Jason's comment:
- Changed values for macros for input keys, removed comments

After more documenation reading:
- changed i2c compatible string to marvell,mv78230-i2c

Comments welcome,

Cheers,

a+

 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 288 +++++++++++++++++++++++++
 2 files changed, 289 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
arch/arm/boot/dts/Makefile +1 -0
index 802720e..c6dd4de 100644
@@ -112,6 +112,7 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-xp-axpwifiap.dtb \
 	armada-xp-db.dtb \
 	armada-xp-gp.dtb \
+	armada-xp-netgear-rn2120.dtb \
 	armada-xp-openblocks-ax3-4.dtb
 dtb-$(CONFIG_ARCH_MXC) += \
 	imx25-karo-tx25.dtb \
arch/arm/boot/dts/armada-xp-netgear-rn2120.dts new file +288 -0

288 lines not on this page · raw message

Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

Quoted 25 lines · Arnaud Ebalard

All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports, USB 2.0 front port, Gigabit controller and PHYs for the two rear ports, serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan controllers, G751 temperature sensor) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi,

Initial message:

This one is intended for v3.14. This depends on the recent fix I pushed for mv78230 PCIe and also on a small patch Guenter Roeck just accepted to have lm75 driver support GMT G751 Temperature sensor (see
https://lkml.org/lkml/2013/11/9/273).

Quoted 7 lines

Regarding the SATA presence and power pin definitions under pinctrl node if you wonder, I thought it would not harm to have them for reference even though they are currently not used. FWIW, I am currently looking if a GPIO regulator can make any use of those.

Note changed since v2 (i.e. kept for later cleanup session):

I presume s/Note/Not/ ? Otherwise, I'm really confused. :)

Quoted 3 lines

- move clocks = <&coreclk 0> in serial node to armada-370-xp.dtsi
- add a label to most SoC nodes to avoid replaying the whole node hierarchy
- see if g762 dt binding can be fixed (no remarks done during review)

thx,

Jason.

#2 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

Quoted 3 lines · Jason Cooper
Quoted 1 line

Note changed since v2 (i.e. kept for later cleanup session):

I presume s/Note/Not/ ? Otherwise, I'm really confused. :)

Yep, and the subject of my email would also deserve a s/v2/v3/ ;-)

a+

Applied
#3 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

In reply to Arnaud Ebalard
Quoted 16 lines · Arnaud Ebalard

All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports, USB 2.0 front port, Gigabit controller and PHYs for the two rear ports, serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan controllers, G751 temperature sensor) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---

...

Quoted 4 lines
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 288 +++++++++++++++++++++++++
 2 files changed, 289 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts

Applied to mvebu/dt

thx,

Jason.

#4 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

Hi,

Quoted 17 lines · Jason Cooper
Quoted 10 lines · Arnaud Ebalard

All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports, USB 2.0 front port, Gigabit controller and PHYs for the two rear ports, serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan controllers, G751 temperature sensor) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Quoted 6 lines

Support for both of those is currently work in progress and does not prevent boot.

---

Quoted 7 lines

...

Quoted 4 lines
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 288 +++++++++++++++++++++++++
 2 files changed, 289 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts

Applied to mvebu/dt

Thanks, Jason. Based on the response to the question raised by Jason Gunthorpe regarding PHY compatible string [1], I'll keep in mind to send you a patch at some point (.dts file for RN2120 also has compatible = "marvell,88e1318s") if needed.

Cheers,

a+

[1]: http://www.spinics.net/lists/arm-kernel/msg288496.html

#5 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

Quoted 27 lines · Arnaud Ebalard

Hi,

Quoted 23 lines · Jason Cooper
Quoted 16 lines · Arnaud Ebalard

All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports, USB 2.0 front port, Gigabit controller and PHYs for the two rear ports, serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan controllers, G751 temperature sensor) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---

...

Quoted 4 lines
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 288 +++++++++++++++++++++++++
 2 files changed, 289 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
Quoted 6 lines
Quoted 1 line

Applied to mvebu/dt

Thanks, Jason. Based on the response to the question raised by Jason Gunthorpe regarding PHY compatible string [1], I'll keep in mind to send you a patch at some point (.dts file for RN2120 also has compatible = "marvell,88e1318s") if needed.

d*mn. You're right. I missed that. I'll drop this from mvebu/dt until that's resolved. I don't want to inadvertently force supporting a compatible string we don't want.

Please resend this once that's resolved.

thx,

Jason.

#6 lore raw

PATCH v2 1/1 ARM: mvebu: Add Netgear ReadyNAS 2120 board

Quoted 7 lines · Jason Cooper
Quoted 6 lines
Quoted 1 line

Applied to mvebu/dt

Thanks, Jason. Based on the response to the question raised by Jason Gunthorpe regarding PHY compatible string [1], I'll keep in mind to send you a patch at some point (.dts file for RN2120 also has compatible = "marvell,88e1318s") if needed.

Quoted 5 lines

d*mn. You're right. I missed that. I'll drop this from mvebu/dt until that's resolved. I don't want to inadvertently force supporting a compatible string we don't want.

Please resend this once that's resolved.

Ack.