KVM: Drop unused kvm_dirty_gfn_harvested()
PATCH 1/1 KVM: Drop unused kvm_dirty_gfn_harvested()
Drop the unused function as reported by test bot.
--- virt/kvm/dirty_ring.c | 5 ----- 1 file changed, 5 deletions(-)
virt/kvm/dirty_ring.c +0 -5
@@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn) gfn->flags =KVM_DIRTY_GFN_F_DIRTY ; } -static inline bool kvm_dirty_gfn_invalid (struct kvm_dirty_gfn *gfn) -{ -return gfn->flags ==0 ; -} -static inline bool kvm_dirty_gfn_harvested (struct kvm_dirty_gfn *gfn) {return gfn->flags &KVM_DIRTY_GFN_F_RESET ;
Signature · 1 line
2.31.1
Quoted 1 line · Peter Xu
Drop the unused function as reported by test bot.
Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".
Quoted 23 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Peter Xu <[email protected]>--- virt/kvm/dirty_ring.c | 5 ----- 1 file changed, 5 deletions(-)virt/kvm/dirty_ring.c +0
-5@@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn) gfn->flags =KVM_DIRTY_GFN_F_DIRTY ; } -static inline bool kvm_dirty_gfn_invalid (struct kvm_dirty_gfn *gfn) -{ -return gfn->flags ==0 ; -} -static inline bool kvm_dirty_gfn_harvested (struct kvm_dirty_gfn *gfn) {return gfn->flags &KVM_DIRTY_GFN_F_RESET ;
Signature · 1 line
Vitaly
Sean Christopherson
reviewerQuoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu
Drop the unused function as reported by test bot.
Your subject line says "Drop unused
kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".
Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.
Quoted 5 lines · Sean Christopherson
Quoted 4 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu
Drop the unused function as reported by test bot.
Quoted 8 lines
Quoted 2 lines
Your subject line says "Drop unused
kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.
Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)
Signature · 1 line
Vitaly
Quoted 10 lines · Vitaly Kuznetsov
Quoted 8 lines · Sean Christopherson
Quoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu
Drop the unused function as reported by test bot.
Your subject line says "Drop unused
kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".
Quoted 8 lines
Quoted 5 lines
Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.
Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)
It should really be a queue, to be fair. :)
I normally glance all the emails before looking into the details. But that's not an excuse for sure, I should have NACKed that one. Sorry about that.
Signature · 1 line
Peter Xu
Sean Christopherson
reviewerQuoted 17 lines · Peter Xu
Quoted 16 lines · Vitaly Kuznetsov
Quoted 13 lines · Sean Christopherson
Quoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu
Drop the unused function as reported by test bot.
Your subject line says "Drop unused
kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.
Quoted 4 lines
Quoted 2 lines
Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)
It should really be a queue, to be fair. :)
Ya, a queue plus a deferred work queue for things that can't be handled in interrupt context ;-)