Skip to contentSkip to conversation

KVM: Drop unused kvm_dirty_gfn_harvested()

PATCH Superseded Peter Xu 3 participants 6 messages Sep 1, 2021 – Sep 2, 2021 KVM

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Peter Xu

author
#0 lore raw

PATCH 1/1 KVM: Drop unused kvm_dirty_gfn_harvested()

Drop the unused function as reported by test bot.

---
 virt/kvm/dirty_ring.c | 5 -----
 1 file changed, 5 deletions(-)
virt/kvm/dirty_ring.c +0 -5
index 7aafefc50aa7..88f4683198ea 100644
@@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
 	gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
 }
 
-static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
-{
-	return gfn->flags == 0;
-}
-
 static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
 {
 	return gfn->flags & KVM_DIRTY_GFN_F_RESET;
Signature · 1 line
2.31.1
#1 lore raw
Quoted 1 line · Peter Xu

Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".

Quoted 23 lines
---
 virt/kvm/dirty_ring.c | 5 -----
 1 file changed, 5 deletions(-)
virt/kvm/dirty_ring.c +0 -5
index 7aafefc50aa7..88f4683198ea 100644
@@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
 	gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
 }
 
-static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
-{
-	return gfn->flags == 0;
-}
-
 static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
 {
 	return gfn->flags & KVM_DIRTY_GFN_F_RESET;
Signature · 1 line
Vitaly
#2 lore raw
Quoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu

Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".

Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.

https://lkml.kernel.org/r/[email protected]

#3 lore raw
Quoted 5 lines · Sean Christopherson
Quoted 4 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu

Drop the unused function as reported by test bot.

Quoted 8 lines
Quoted 2 lines

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".

Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.

Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)

Signature · 1 line
Vitaly
author
#4 lore raw
Quoted 10 lines · Vitaly Kuznetsov
Quoted 8 lines · Sean Christopherson
Quoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu

Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".

Quoted 8 lines
Quoted 5 lines

Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.

Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)

It should really be a queue, to be fair. :)

I normally glance all the emails before looking into the details. But that's not an excuse for sure, I should have NACKed that one. Sorry about that.

Signature · 1 line
Peter Xu
#5 lore raw
Quoted 17 lines · Peter Xu
Quoted 16 lines · Vitaly Kuznetsov
Quoted 13 lines · Sean Christopherson
Quoted 6 lines · Vitaly Kuznetsov
Quoted 1 line · Peter Xu

Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in reallity you drop "kvm_dirty_gfn_invalid()".

Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time.

Quoted 4 lines
Quoted 2 lines

Indeed. It's also a good reminder for reviewers that inbox is best treated like a stack and not like a queue :-)

It should really be a queue, to be fair. :)

Ya, a queue plus a deferred work queue for things that can't be handled in interrupt context ;-)