Skip to contentSkip to conversation

hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet

PATCH Applied Thomas Huth 4 participants 4 messages Feb 8, 2017 – Feb 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet

The "qemu,register" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet.

---
v3: Another update to the patch description and comment

 hw/core/register.c | 9 +++++++++
 1 file changed, 9 insertions(+)
hw/core/register.c +9 -0
index 4bfbc50..be170dc 100644
@@ -274,9 +274,18 @@ void register_finalize_block(RegisterInfoArray *r_array)
     g_free(r_array);
 }
 
+static void register_class_init(ObjectClass *oc, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(oc);
+
+    /* Reason: needs to be wired up to work */
+    dc->cannot_instantiate_with_device_add_yet = true;
+}
+
 static const TypeInfo register_info = {
     .name  = TYPE_REGISTER,
     .parent = TYPE_DEVICE,
+    .class_init = register_class_init,
 };
 
 static void register_register_types(void)
Signature · 1 line
1.8.3.1
#3 lore raw
In reply to Thomas Huth
Quoted 3 lines · Thomas Huth

The "qemu,register" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet.

Applied both v3 patches to -trivial, thank you!

/mjt