Skip to contentSkip to conversation

dmaengine: idxd: Fix refcount and cleanup issues on module unload

PATCH RESEND Applied Yi Sun 5 participants 8 messages Jul 29, 2025 – Aug 20, 2025

Subsystems (2)
lore
Share & tools
lore

Yi Sun

author
#0 lore raw

v3 cover dmaengine: idxd: Fix refcount and cleanup issues on module unload

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

---
Changes in V3:
- Removed function idxd_disable_sva which got removed recently (Vinicius) Changes in v2:
- Reworded commit messages supplementing the call traces (Vinicius)
- Explain why the put_device are unnecessary. (Vinicius)

Yi Sun (2):
dmaengine: idxd: Remove improper idxd_free
dmaengine: idxd: Fix refcount underflow on module unload

 drivers/dma/idxd/init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH RESEND v3 1/2 dmaengine: idxd: Remove improper idxd_free

The call to idxd_free() introduces a duplicate put_device() leading to a reference count underflow:
refcount_t: underflow; use-after-free.

WARNING: CPU: 15 PID: 4428 at lib/refcount.c:28 refcount_warn_saturate+0xbe/0x110
...
Call Trace:
 <TASK>
  idxd_remove+0xe4/0x120 [idxd]
  pci_device_remove+0x3f/0xb0
  device_release_driver_internal+0x197/0x200
  driver_detach+0x48/0x90
  bus_remove_driver+0x74/0xf0
  pci_unregister_driver+0x2e/0xb0
  idxd_exit_module+0x34/0x7a0 [idxd]
  __do_sys_delete_module.constprop.0+0x183/0x280
  do_syscall_64+0x54/0xd70
  entry_SYSCALL_64_after_hwframe+0x76/0x7e

The idxd_unregister_devices() which is invoked at the very beginning of idxd_remove(), already takes care of the necessary put_device() through the following call path:
idxd_unregister_devices() -> device_unregister() -> put_device()

In addition, when CONFIG_DEBUG_KOBJECT_RELEASE is enabled, put_device() may trigger asynchronous cleanup via schedule_delayed_work(). If idxd_free() is called immediately after, it can result in a use-after-free.

Remove the improper idxd_free() to avoid both the refcount underflow and potential memory corruption during module unload.

Fixes d5449ff1b04d ("dmaengine: idxd: Add missing idxd cleanup to fix memory leak in remove call")
drivers/dma/idxd/init.c +0 -1
index 80355d03004d..40cc9c070081 100644
@@ -1295,7 +1295,6 @@ static void idxd_remove(struct pci_dev *pdev)
 	idxd_cleanup(idxd);
 	pci_iounmap(pdev, idxd->reg_base);
 	put_device(idxd_confdev(idxd));
-	idxd_free(idxd);
 	pci_disable_device(pdev);
 }
 
Signature · 1 line
2.43.0
author
#2 lore raw

PATCH RESEND v3 2/2 dmaengine: idxd: Fix refcount underflow on module unload

In reply to Yi Sun

A recent refactor introduced a misplaced put_device() call, resulting in a reference count underflow during module unload.

There is no need to add additional put_device() calls for idxd groups, engines, or workqueues. Although the commit claims: "Note, this also fixes the missing put_device() for idxd groups, engines, and wqs."

It appears no such omission actually existed. The required cleanup is already handled by the call chain:
idxd_unregister_devices() -> device_unregister() -> put_device()

Extend idxd_cleanup() to handle the remaining necessary cleanup and remove idxd_cleanup_internals(), which duplicates deallocation logic for idxd, engines, groups, and workqueues. Memory management is also properly handled through the Linux device model.

Fixes a409e919ca32 ("dmaengine: idxd: Refactor remove call with idxd_cleanup() helper")
drivers/dma/idxd/init.c +4 -1
index 40cc9c070081..40f4bf446763 100644
@@ -1292,7 +1292,10 @@ static void idxd_remove(struct pci_dev *pdev)
 	device_unregister(idxd_confdev(idxd));
 	idxd_shutdown(pdev);
 	idxd_device_remove_debugfs(idxd);
-	idxd_cleanup(idxd);
+	perfmon_pmu_remove(idxd);
+	idxd_cleanup_interrupts(idxd);
+	if (device_pasid_enabled(idxd))
+		idxd_disable_system_pasid(idxd);
 	pci_iounmap(pdev, idxd->reg_base);
 	put_device(idxd_confdev(idxd));
 	pci_disable_device(pdev);
Signature · 1 line
2.43.0
reviewer Reviewed-by on the v3 series
#3 lore raw
In reply to Yi Sun
Quoted 17 lines · Yi Sun

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Quoted 5 lines

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

for the series

Quoted 15 lines

---
Changes in V3:
- Removed function idxd_disable_sva which got removed recently (Vinicius) Changes in v2:
- Reworded commit messages supplementing the call traces (Vinicius)
- Explain why the put_device are unnecessary. (Vinicius)

Yi Sun (2):
dmaengine: idxd: Remove improper idxd_free
dmaengine: idxd: Fix refcount underflow on module unload

 drivers/dma/idxd/init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
maintainer Acked-by on the v3 series
#4 lore raw
In reply to Yi Sun
Quoted 17 lines · Yi Sun

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Quoted 7 lines

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

---

For the series:

Cheers,

Signature · 1 line
Vinicius
author
#5 lore raw
Quoted 25 lines · Vinicius Costa Gomes
Quoted 23 lines · Yi Sun

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

Quoted 10 lines
Quoted 1 line

---

For the series:

Cheers,

Signature · 1 line
Vinicius

Hi Vinod,

Gentle ping.
This is another series of bug fixes.

Thanks
--Sun, Yi

#6 lore raw
In reply to Yi Sun
Quoted 30 lines · Yi Sun

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

---
Changes in V3:
- Removed function idxd_disable_sva which got removed recently (Vinicius) Changes in v2:
- Reworded commit messages supplementing the call traces (Vinicius)
- Explain why the put_device are unnecessary. (Vinicius)

Quoted 7 lines

Yi Sun (2):
dmaengine: idxd: Remove improper idxd_free
dmaengine: idxd: Fix refcount underflow on module unload

 drivers/dma/idxd/init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Applied patch series on top of v6.17-rc1 kernel. Issue is fixed.

Please help add Tested-by: Yi Lai <[email protected]>

Regards,
Yi Lai

Quoted 2 lines
Signature · 1 line
2.43.0
maintainer Applied
#7 lore raw
In reply to Yi Sun
Quoted 8 lines · Yi Sun

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

[...]

Applied, thanks!

[1/2] dmaengine: idxd: Remove improper idxd_free

      commit: f41c538881eec4dcf5961a242097d447f848cda6
[2/2] dmaengine: idxd: Fix refcount underflow on module unload
      commit: b7cb9a034305d52222433fad10c3de10204f29e7

Best regards,

Signature · 1 line
~Vinod