Skip to content

dmaengine: idxd: Fix refcount and cleanup issues on module unload

Yi Sun dmaengine lkml 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/22 patches 5 repliesApplied
  2. v3 posting 1/22 patches 12 repliesSuperseded
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches8 repliesSuperseded

Changes in v3 from the cover letter

- Removed function idxd_disable_sva which got removed recently (Vinicius) Changes in v2:
- Reworded commit messages supplementing the call traces (Vinicius)
- Explain why the put_device are unnecessary. (Vinicius)

Patches in v3 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2dmaengine: idxd: Remove improper idxd_freedrivers/dma/idxd/init.c+0 -10 replies
2/2dmaengine: idxd: Fix refcount underflow on module unloaddrivers/dma/idxd/init.c+4 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchShuai XueDave JiangVinicius Costa Gomes
SeriesR-b A-b
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH RESEND v3 0/2] dmaengine: idxd: Fix refcount and cleanup issues on module unload

This patch series addresses two issues related to the device reference counting and cleanup path in the idxd driver.

Recent changes introduced improper put_device() calls and duplicated cleanup logic, leading to refcount underflow and potential use-after-free during module unload.

Patch 1 removes an unnecessary call to idxd_free(), which could result in a use-after-free, because the function idxd_conf_device_release already covers everything done in idxd_free. The newly added idxd_free in commit 90022b3 doesn't resolve any memory leaks, but introduces several duplicated cleanup.

Patch 2 refactors the cleanup to avoid redundant put_device() calls introduced in commit a409e919ca3. The existing idxd_unregister_devices() already handles proper device reference release.

Both patches have been verified on hardware platform.

Both patches have been run through checkpatch.pl. Patch 2 gets 1 error and 1 warning. But these appear to be limitations in the checkpatch script itself, not reflect issues with the patches.

---
Changes in V3:
- Removed function idxd_disable_sva which got removed recently (Vinicius) Changes in v2:
- Reworded commit messages supplementing the call traces (Vinicius)
- Explain why the put_device are unnecessary. (Vinicius)

Yi Sun (2):
dmaengine: idxd: Remove improper idxd_free
dmaengine: idxd: Fix refcount underflow on module unload

 drivers/dma/idxd/init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0