Skip to contentSkip to conversation

MAINTAINERS: Add Python library stanza

PATCH In review John Snow 4 participants 11 messages Sep 22, 2020 – Oct 1, 2020

lore
Share & tools
lore

John Snow

author
#0 lore raw

v2 cover MAINTAINERS: Add Python library stanza

John Snow (1):
MAINTAINERS: Add Python library stanza

 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH v2 1/1 MAINTAINERS: Add Python library stanza

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -1
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py
 
Signature · 1 line
2.26.2
#2 lore raw
Quoted 5 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

^ Can you drop that line from the description when applying please?

Quoted 36 lines
---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -1
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py
 
author
#3 lore raw
Quoted 9 lines · Philippe Mathieu-Daudé
Quoted 5 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

^ Can you drop that line from the description when applying please?

Yup, forgot to put below the dashed line, oops.

Quoted 37 lines
Quoted 36 lines
---
  MAINTAINERS | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -1
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
  F: include/sysemu/cryptodev*.h
  F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
  Python scripts
  M: Eduardo Habkost <[email protected]>
  M: Cleber Rosa <[email protected]>
  S: Odd fixes
-F: python/qemu/*py
  F: scripts/*.py
  F: tests/*.py
 
#4 lore raw
In reply to John Snow
Quoted 29 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +5 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained

MAINTAINERS S: Maintained · line 2371

Quoted 10 lines
MAINTAINERS +3 -1
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

author
#5 lore raw
Quoted 36 lines · Markus Armbruster
Quoted 34 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
  MAINTAINERS | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
  F: include/sysemu/cryptodev*.h
  F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
  Python scripts
  M: Eduardo Habkost <[email protected]>
Quoted 9 lines

MAINTAINERS S: Maintained · line 2371

Quoted 5 lines
MAINTAINERS +0 -1
  M: Cleber Rosa <[email protected]>
  S: Odd fixes
-F: python/qemu/*py
  F: scripts/*.py
  F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

--js

#6 lore raw
Quoted 46 lines · John Snow
Quoted 35 lines · Markus Armbruster
Quoted 33 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
  MAINTAINERS | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
  F: include/sysemu/cryptodev*.h
  F: backends/cryptodev*.c
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
  Python scripts
  M: Eduardo Habkost <[email protected]>
Quoted 9 lines

MAINTAINERS S: Maintained · line 2371

Quoted 5 lines
MAINTAINERS +0 -1
  M: Cleber Rosa <[email protected]>
  S: Odd fixes
-F: python/qemu/*py
  F: scripts/*.py
  F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

Quoted 7 lines

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

Also, the actual owners for most scripts in ./scripts are already listed elsewhere. I believe we shouldn't really have M: lines for the scripts/*.py section, just R:.

Signature · 1 line
Eduardo
#7 lore raw
Quoted 52 lines · Eduardo Habkost
Quoted 51 lines · John Snow
Quoted 35 lines · Markus Armbruster
Quoted 33 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
  MAINTAINERS | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
  F: include/sysemu/cryptodev*.h
  F: backends/cryptodev*.c
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
  Python scripts
  M: Eduardo Habkost <[email protected]>
Quoted 9 lines

MAINTAINERS S: Maintained · line 2371

Quoted 5 lines
MAINTAINERS +0 -1
  M: Cleber Rosa <[email protected]>
  S: Odd fixes
-F: python/qemu/*py
  F: scripts/*.py
  F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Quoted 6 lines
Quoted 2 lines

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

Also, the actual owners for most scripts in ./scripts are already listed elsewhere. I believe we shouldn't really have M: lines for the scripts/*.py section, just R:.

Agreed. Maybe worth a comment in the section although.

#8 lore raw
Quoted 53 lines · Philippe Mathieu-Daudé
Quoted 52 lines · Eduardo Habkost
Quoted 51 lines · John Snow
Quoted 35 lines · Markus Armbruster
Quoted 33 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
  MAINTAINERS | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
  F: include/sysemu/cryptodev*.h
  F: backends/cryptodev*.c
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
  Python scripts
  M: Eduardo Habkost <[email protected]>
Quoted 9 lines

MAINTAINERS S: Maintained · line 2371

Quoted 5 lines
MAINTAINERS +0 -1
  M: Cleber Rosa <[email protected]>
  S: Odd fixes
-F: python/qemu/*py
  F: scripts/*.py
  F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

Also, the actual owners for most scripts in ./scripts are already listed elsewhere. I believe we shouldn't really have M: lines for the scripts/*.py section, just R:.

Good point.

Quoted 1 line

Agreed. Maybe worth a comment in the section although.

Let's do it.

author
#9 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 53 lines · Philippe Mathieu-Daudé
Quoted 52 lines · Eduardo Habkost
Quoted 51 lines · John Snow
Quoted 35 lines · Markus Armbruster
Quoted 33 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
   MAINTAINERS | 9 ++++++++-
   1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained
   F: include/sysemu/cryptodev*.h
   F: backends/cryptodev*.c
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
   Python scripts
   M: Eduardo Habkost <[email protected]>
Quoted 9 lines

MAINTAINERS S: Maintained · line 2371

Quoted 5 lines
MAINTAINERS +0 -1
   M: Cleber Rosa <[email protected]>
   S: Odd fixes
-F: python/qemu/*py
   F: scripts/*.py
   F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a deeper logic behind the split?

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

Also, the actual owners for most scripts in ./scripts are already listed elsewhere. I believe we shouldn't really have M: lines for the scripts/*.py section, just R:.

Agreed. Maybe worth a comment in the section although.

*in* the section? There is no precedent for that. Is this really so important?

I'll give you a commit message blurb.

--js

#10 lore raw
Quoted 63 lines · John Snow
Quoted 62 lines · Philippe Mathieu-Daudé
Quoted 60 lines · Eduardo Habkost
Quoted 48 lines · John Snow
Quoted 37 lines · Markus Armbruster
Quoted 35 lines · John Snow

I'm proposing that I split the actual Python library off from the other
miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

v2: change python/* to python/, thanks Alex.

---
   MAINTAINERS | 9 ++++++++-

   1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 3d17cad19a..c0222ee645 100644
@@ -2355,11 +2355,18 @@ S: Maintained

   F: include/sysemu/cryptodev*.h
   F: backends/cryptodev*.c

MAINTAINERS +8 -0
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+

   Python scripts
   M: Eduardo Habkost <[email protected]>
   M: Cleber Rosa <[email protected]>

Quoted 9 lines
Quoted 4 lines

   S: Odd fixes
-F: python/qemu/*py
   F: scripts/*.py
   F: tests/*.py

Separate sections just so you can have the appropriate S:, or is there a
deeper logic behind the split?

Quoted 7 lines

Yes, different intended levels of support. I don't currently have the bandwidth to promise support for the miscellaneous Python scripts in ./scripts, but I do promise to support to a higher level the code in ./python.

Over time, I intend to migrate things into ./python, but there are some series that need to happen first before I start doing that.

Also, the actual owners for most scripts in ./scripts are already listed elsewhere.  I believe we shouldn't really have M: lines for the scripts/*.py section, just R:.

Quoted 5 lines
Quoted 2 lines

Agreed. Maybe worth a comment in the section although.

*in* the section? There is no precedent for that. Is this really so important?

Well if this file is only consumed by scripts, and no human reads it, then it is pointless indeed.

Quoted 2 lines

I'll give you a commit message blurb.

That sometime works, thanks.

Quoted 3 lines

--js