Skip to contentSkip to conversation

qapi/migration.json: Clean up for COLOStatus

PATCH Applied Zhang Chen 2 participants 2 messages Apr 2, 2019

lore
Share & tools
lore

Zhang Chen

author
#0 lore raw

PATCH 1/1 qapi/migration.json: Clean up for COLOStatus

From: Zhang Chen <[email protected]>

Address Markus's comments change the 'last_mode' to 'last-mode'.

---
 qapi/migration.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
qapi/migration.json +2 -2
index cfde29acf8..9217886c80 100644
@@ -1380,7 +1380,7 @@
 # @mode: COLO running mode. If COLO is running, this field will return
 #        'primary' or 'secondary'.
 #
-# @last_mode: COLO last running mode. If COLO is running, this field
+# @last-mode: COLO last running mode. If COLO is running, this field
 #             will return same like mode field, after failover we can
 #             use this field to get last colo mode. (since 4.1)
 #
@@ -1389,7 +1389,7 @@
 # Since: 3.1
 ##
 { 'struct': 'COLOStatus',
-  'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
+  'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
             'reason': 'COLOExitReason' } }
 
 ##
Signature · 1 line
2.17.GIT
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 23 lines · Zhang Chen

From: Zhang Chen <[email protected]>

Address Markus's comments change the 'last_mode' to 'last-mode'.

---
 qapi/migration.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
qapi/migration.json +1 -1
index cfde29acf8..9217886c80 100644
@@ -1380,7 +1380,7 @@
 # @mode: COLO running mode. If COLO is running, this field will return
 #        'primary' or 'secondary'.
 #
-# @last_mode: COLO last running mode. If COLO is running, this field
+# @last-mode: COLO last running mode. If COLO is running, this field
 #             will return same like mode field, after failover we can
 #             use this field to get last colo mode. (since 4.1)
 #

qapi/migration.json line 1395

Quoted 8 lines
qapi/migration.json +1 -1
@@ -1389,7 +1389,7 @@
 # Since: 3.1
 ##
 { 'struct': 'COLOStatus',
-  'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
+  'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
             'reason': 'COLOExitReason' } }
 
 ##

Queued for 4.0 with the commit message tweaked to just

qapi/migration.json: Rename COLOStatus last_mode to last-mode

Hope that's okay. Thank you!