dmaengine: tegra210-adma: fix pm_runtime_get_sync failure
Subsystems (3)
PATCH 1/1 dmaengine: tegra210-adma: fix pm_runtime_get_sync failure
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails.
--- drivers/dma/tegra210-adma.c | 1 + 1 file changed, 1 insertion(+)
drivers/dma/tegra210-adma.c +1 -0
@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret =pm_runtime_get_sync (tdc2dev (tdc));if (ret <0 ) {free_irq (tdc->irq, tdc); +pm_runtime_put (tdc2dev (tdc));return ret; }
Signature · 1 line
2.17.1
Jon Hunter
maintainerQuoted 14 lines · Navid Emamdoost
Calling
pm_runtime_get_syncincrements the counter even in case of failure, causing incorrect ref count. Callpm_runtime_putifpm_runtime_get_syncfails.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/dma/tegra210-adma.c | 1 + 1 file changed, 1 insertion(+)drivers/dma/tegra210-adma.c +0
-0
drivers/dma/tegra210-adma.c static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) · line 664
Quoted 6 lines
drivers/dma/tegra210-adma.c +1
-0@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret =pm_runtime_get_sync (tdc2dev (tdc));if (ret <0 ) {free_irq (tdc->irq, tdc); +pm_runtime_put (tdc2dev (tdc));return ret; }
Please do not send two patches with the same $subject that are fixing two different areas of the driver. In fact, please squash these two patches into a single fix and resend because they are fixing the same issue.
Jon
Signature · 1 line
nvpublic
Quoted 12 lines · Jon Hunter
Quoted 9 lines · Navid Emamdoost
Calling
pm_runtime_get_syncincrements the counter even in case of failure, causing incorrect ref count. Callpm_runtime_putifpm_runtime_get_syncfails.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/dma/tegra210-adma.c | 1 + 1 file changed, 1 insertion(+)
Quoted 16 lines
drivers/dma/tegra210-adma.c static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) · line 664
Quoted 11 lines
drivers/dma/tegra210-adma.c +1
-0@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret =pm_runtime_get_sync (tdc2dev (tdc));if (ret <0 ) {free_irq (tdc->irq, tdc); +pm_runtime_put (tdc2dev (tdc));return ret; }Please do not send two patches with the same $subject that are fixing two different areas of the driver. In fact, please squash these two patches into a single fix and resend because they are fixing the same issue.
Sure, I will prepare a version 2 with your suggestions.
Quoted 5 lines
Jon
--
nvpublic
Signature · 1 line
Navid.