NTB: Fix an error code in ntb_msit_probe()
PATCH v2 1/1 NTB: Fix an error code in ntb_msit_probe()
When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error.
Clean up smatch warning:drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
---
Change in v2:
--revise typo
drivers/ntb/test/ntb_msi_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/ntb/test/ntb_msi_test.c +3 -1
@@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)if (ret) goto remove_dbgfs; -if (!nm->isr_ctx) +if (!nm->isr_ctx) { + ret = -ENOMEM ; goto remove_dbgfs; + }ntb_link_enable (ntb,NTB_SPEED_AUTO ,NTB_WIDTH_AUTO );
Signature · 1 line
1.8.3.1
Quoted 9 lines · Yang Li
When the value of
nm->isr_ctxis false, the value of ret is 0. So, we set ret to-ENOMEMto indicate this error.Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373ntb_msit_probe()warn: missing error code 'ret'.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Thanks!
Reviewed-by Logan Gunthorpe <[email protected]>
Quoted 25 lines
---
Change in v2:
--revise typodrivers/ntb/test/ntb_msi_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/ntb/test/ntb_msi_test.c +3
-1@@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)if (ret) goto remove_dbgfs; -if (!nm->isr_ctx) +if (!nm->isr_ctx) { + ret = -ENOMEM ; goto remove_dbgfs; + }ntb_link_enable (ntb,NTB_SPEED_AUTO ,NTB_WIDTH_AUTO );