arm64: dts: qcom: Add dual-channel LVDS support on QCS615 Talos EVK
cover arm64: dts: qcom: Add dual-channel LVDS support on QCS615 Talos EVK
Hi all,
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (talos-evk-lvds.dts) is based on the existing talos-evk.dts and extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.
In this setup:
- LVDS Channel A carries odd pixels.
- LVDS Channel B carries even pixels.
This patch only adds the new DTS and corresponding Makefile entry.
Thanks,
Sudarshan
---
Sudarshan Shetty (1):
arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dts
Signature · 1 line
2.34.1
PATCH 1/1 arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (talos-evk-lvds.dts) is based on the existing talos-evk.dts and extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.
where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +128 -0
128 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 12 lines · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>---
[...]
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 16
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +7
-0+ backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en {
Use hyphens instead of underscores in node names
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 19
Quoted 3 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +3
-0+ compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>;
I think your intention was to use pwm-backlight and wire this node up to that
Konrad
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 16 lines · Konrad Dybcio
Quoted 12 lines · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>---
[...]
Quoted 9 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 16
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +7
-0+ backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en {Use hyphens instead of underscores in node names
Okay, will update in next patch.
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 19
Quoted 4 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +3
-0+ compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>;I think your intention was to use pwm-backlight and wire this node up to that
Soc does not support the PWM interface hence we are using gpio as "pwm-gpio" by setting the duty cycle to 100%(i.e. "no pwm")
Quoted 2 lines
Konrad
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 38 lines · Tessolve Upstream
Quoted 16 lines · Konrad Dybcio
Quoted 12 lines · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>---
[...]
Quoted 9 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 16
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +7
-0+ backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en {Use hyphens instead of underscores in node names
Okay, will update in next patch.
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 19
Quoted 4 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +3
-0+ compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>;I think your intention was to use pwm-backlight and wire this node up to that
Quoted 2 lines
Soc does not support the PWM interface hence we are using gpio as "pwm-gpio" by setting the duty cycle to 100%(i.e. "no pwm")
Why do you mention PWM here at all? It's perfectly fine to use gpio-backlight. That looks extremely suspicious since you are not referecing the pwm-gpio device at all.
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 39 lines · Dmitry Baryshkov
Quoted 38 lines · Tessolve Upstream
Quoted 16 lines · Konrad Dybcio
Quoted 12 lines · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>---
[...]
Quoted 9 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 16
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +7
-0+ backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en {Use hyphens instead of underscores in node names
Okay, will update in next patch.
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 19
Quoted 4 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +3
-0+ compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>;I think your intention was to use pwm-backlight and wire this node up to that
Quoted 6 lines
Quoted 2 lines
Soc does not support the PWM interface hence we are using gpio as "pwm-gpio" by setting the duty cycle to 100%(i.e. "no pwm")
Why do you mention PWM here at all? It's perfectly fine to use gpio-backlight. That looks extremely suspicious since you are not referecing the pwm-gpio device at all.
Thanks for the feedback.
GPIO59 (LED_PWM) connected to the panel’s dimming input.
Since we can only drive the LED_PWM pin high (100% duty), it does not provide true PWM control.
I’ll remove the non-standard "pwm-gpio" node and model both lines using the standard gpio-backlight binding, like this:
backlight: backlight {
compatible = "gpio-backlight";
gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>, <&tlmm 59 GPIO_ACTIVE_HIGH>;
default-on;
pinctrl-0 = <&lcd0_bklt_en>, <&lcd0_bklt_pwm>;
pinctrl-names = "default";
};&tlmm {
lcd0_bklt_en: lcd0-bklt-en-state {
pins = "gpio115";
function = "gpio";
bias-disable;
};
lcd0_bklt_pwm: lcd0-bklt-pwm-state {
pins = "gpio59";
function = "gpio";
bias-disable;
};
};Let me know your opinion here,
Thanks in advance.
Quoted 1 line
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 55 lines · Tessolve Upstream
Quoted 39 lines · Dmitry Baryshkov
Quoted 38 lines · Tessolve Upstream
Quoted 16 lines · Konrad Dybcio
Quoted 12 lines · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>---
[...]
Quoted 9 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 16
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +7
-0+ backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en {Use hyphens instead of underscores in node names
Okay, will update in next patch.
Quoted 7 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 19
Quoted 4 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +3
-0+ compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>;I think your intention was to use pwm-backlight and wire this node up to that
Quoted 6 lines
Quoted 2 lines
Soc does not support the PWM interface hence we are using gpio as "pwm-gpio" by setting the duty cycle to 100%(i.e. "no pwm")
Why do you mention PWM here at all? It's perfectly fine to use gpio-backlight. That looks extremely suspicious since you are not referecing the pwm-gpio device at all.
Thanks for the feedback.
GPIO59 (LED_PWM) connected to the panel’s dimming input.Since we can only drive the
LED_PWMpin high (100% duty), it does not provide true PWM control.
Quoted 6 lines
I’ll remove the non-standard "pwm-gpio" node and model both lines using the standard gpio-backlight binding, like this:
backlight: backlight { compatible = "gpio-backlight"; gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>, <&tlmm 59 GPIO_ACTIVE_HIGH>;
You will have to adapt the gpio-backlight bindings and driver to handle multiple entries here.
Quoted 23 lines
default-on; pinctrl-0 = <&lcd0_bklt_en>, <&lcd0_bklt_pwm>; pinctrl-names = "default"; };&tlmm { lcd0_bklt_en: lcd0-bklt-en-state { pins = "gpio115"; function = "gpio"; bias-disable; }; lcd0_bklt_pwm: lcd0-bklt-pwm-state { pins = "gpio59"; function = "gpio"; bias-disable; }; };Let me know your opinion here,
Thanks in advance.Quoted 1 line
Signature · 2 lines
With best wishes Dmitry
Bjorn Andersson
maintainerRe: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
In reply to Sudarshan ShettyQuoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Quoted 34 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"
We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Regards,
Bjorn
Quoted 125 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +122
-0+ +/ { + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en { + compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>; + pinctrl-names = "default"; + #pwm-cells = <3>; + }; + + panel-lvds { + compatible = "auo,g133han01"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* LVDS A (Odd pixels) */ + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + lvds_panel_out_a: endpoint { + remote-endpoint = <&sn65dsi84_out_a>; + }; + }; + + /* LVDS B (Even pixels) */ + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + lvds_panel_out_b: endpoint { + remote-endpoint = <&sn65dsi84_out_b>; + }; + }; + }; + }; +}; + +&adv7535 { + status = "disabled"; +}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + sn65dsi84: sn65dsi84@2c { + compatible = "ti,sn65dsi84"; + reg = <0x2c>; + enable-gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>; + ti,dsi-lanes = <4>; + ti,lvds-format = "jeida-24"; + ti,lvds-bpp = <24>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + sn65dsi84_in: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@2 { + reg = <2>; + + sn65dsi84_out_a: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_a>; + }; + }; + + port@3 { + reg = <3>; + + sn65dsi84_out_b: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_b>; + }; + }; + }; + }; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&sn65dsi84_in>; + data-lanes = <0 1 2 3>; +}; + +&tlmm { + lcd0_bklt_en: lcd0-bklt-en-state { + pins = "gpio115"; + function = "gpio"; + bias-disable; + }; + + lcd0_bklt_pwm: lcd0-bklt-pwm-state { + pins = "gpio59"; + function = "gpio"; + bias-disable; + }; +};Signature · 1 line
2.34.1
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 10 lines · Bjorn Andersson
Quoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Okay, will update in next patch.
Quoted 46 lines
Quoted 35 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
Quoted 8 lines
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Regards,
Bjorn
Thanks for the feedback.
Currently, the Talos device tree hierarchy is organized as follows:
talos-som.dtsi — defines SoM-specific interfaces talos-evk.dts — adds carrier board (CB) interfaces such as MicroSD, power button, and HDMItalos-evk-lvds.dts — enables the LVDS display (includes SoM + CB + LVDS + disables HDMI)
The LVDS and HDMI displays share a common DSI output, so only one interface can be active at a time. At present, talos-evk-lvds.dts includes talos-evk.dts directly so that the base SoM and carrier interfaces (e.g., MicroSD, power button) remain available.
However, as you pointed out, including a .dts file directly is not recommended upstream. To address this, I am considering the following restructuring options:
Option 1: Introduce a talos-cb.dtsi
talos-som.dtsi: SoM-specific interfacestalos-cb.dtsi: common carrier board interfaces (MicroSD, power button, etc.) talos-evk.dts: includes talos-som.dtsi + talos-cb.dtsi + HDMI talos-evk-lvds.dts: includes talos-som.dtsi + talos-cb.dtsi + LVDS
This approach avoids including .dts files directly and keeps the carrier board interfaces centralized and reusable.It also cleanly separates SoM and CB content and is consistent with how other Qualcomm platforms structure their EVK variants.
Option 2: Move CB interfaces to talos-som.dtsi (disabled by default)
Move MicroSD, power button, etc., to talos-som.dtsi with status = "disabled"; Enable these interfaces in each top-level DTS (e.g., talos-evk.dts, talos-evk-lvds.dts)
While this also avoids .dts inclusion, it may make the SoM DTS unnecessarily complex and less reusable, as those CB-specific peripherals don’t belong to the SoM hardware.
Let me know your prepared approach here.
Quoted 125 lines
Quoted 125 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +122
-0+ +/ { + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en { + compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>; + pinctrl-names = "default"; + #pwm-cells = <3>; + }; + + panel-lvds { + compatible = "auo,g133han01"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* LVDS A (Odd pixels) */ + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + lvds_panel_out_a: endpoint { + remote-endpoint = <&sn65dsi84_out_a>; + }; + }; + + /* LVDS B (Even pixels) */ + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + lvds_panel_out_b: endpoint { + remote-endpoint = <&sn65dsi84_out_b>; + }; + }; + }; + }; +}; + +&adv7535 { + status = "disabled"; +}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + sn65dsi84: sn65dsi84@2c { + compatible = "ti,sn65dsi84"; + reg = <0x2c>; + enable-gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>; + ti,dsi-lanes = <4>; + ti,lvds-format = "jeida-24"; + ti,lvds-bpp = <24>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + sn65dsi84_in: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@2 { + reg = <2>; + + sn65dsi84_out_a: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_a>; + }; + }; + + port@3 { + reg = <3>; + + sn65dsi84_out_b: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_b>; + }; + }; + }; + }; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&sn65dsi84_in>; + data-lanes = <0 1 2 3>; +}; + +&tlmm { + lcd0_bklt_en: lcd0-bklt-en-state { + pins = "gpio115"; + function = "gpio"; + bias-disable; + }; + + lcd0_bklt_pwm: lcd0-bklt-pwm-state { + pins = "gpio59"; + function = "gpio"; + bias-disable; + }; +};Signature · 1 line
2.34.1
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 61 lines · Tessolve Upstream
Quoted 10 lines · Bjorn Andersson
Quoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Okay, will update in next patch.
Quoted 46 lines
Quoted 35 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
Quoted 6 lines
Quoted 4 lines
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Thanks for the feedback.
You didn't answer the question. It was about the hardware, not about DTs.
Quoted 7 lines
Currently, the Talos device tree hierarchy is organized as follows:
talos-som.dtsi— defines SoM-specific interfacestalos-evk.dts— adds carrier board (CB) interfaces such as MicroSD, power button, and HDMItalos-evk-lvds.dts— enables the LVDS display (includes SoM + CB + LVDS + disables HDMI)
So, is LVDS a part of the standard board or is it a mezzanine?
Quoted 17 lines
The LVDS and HDMI displays share a common DSI output, so only one interface can be active at a time. At present,
talos-evk-lvds.dtsincludestalos-evk.dtsdirectly so that the base SoM and carrier interfaces (e.g., MicroSD, power button) remain available.However, as you pointed out, including a .dts file directly is not recommended upstream. To address this, I am considering the following restructuring options:
Option 1: Introduce a
talos-cb.dtsi
talos-som.dtsi: SoM-specific interfacestalos-cb.dtsi: common carrier board interfaces (MicroSD, power button, etc.)talos-evk.dts: includestalos-som.dtsi+talos-cb.dtsi+ HDMItalos-evk-lvds.dts: includestalos-som.dtsi+talos-cb.dtsi+ LVDS
Quoted 4 lines
This approach avoids including .dts files directly and keeps the carrier board interfaces centralized and reusable.It also cleanly separates SoM and CB content and is consistent with how other Qualcomm platforms structure their EVK variants.
This sounds okay, but please respond to previous questions.
Quoted 2 lines
Option 2: Move CB interfaces to
talos-som.dtsi(disabled by default)
Why? What happens when somebody reuses the SoM with some other base board?
Quoted 9 lines
Move MicroSD, power button, etc., to
talos-som.dtsiwith status = "disabled"; Enable these interfaces in each top-level DTS (e.g.,talos-evk.dts,talos-evk-lvds.dts)
While this also avoids .dts inclusion, it may make the SoM DTS unnecessarily complex and less reusable, as those CB-specific peripherals don’t belong to the SoM hardware.Let me know your prepared approach here.
If you yourself don't like the second option, why do you propose it?
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 74 lines · Dmitry Baryshkov
Quoted 61 lines · Tessolve Upstream
Quoted 10 lines · Bjorn Andersson
Quoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Okay, will update in next patch.
Quoted 46 lines
Quoted 35 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
Quoted 6 lines
Quoted 4 lines
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Thanks for the feedback.
You didn't answer the question. It was about the hardware, not about DTs.
Quoted 2 lines
Currently, the Talos device tree hierarchy is organized as follows:
Quoted 7 lines
Quoted 5 lines
talos-som.dtsi— defines SoM-specific interfacestalos-evk.dts— adds carrier board (CB) interfaces such as MicroSD, power button, and HDMItalos-evk-lvds.dts— enables the LVDS display (includes SoM + CB + LVDS + disables HDMI)So, is LVDS a part of the standard board or is it a mezzanine?
Yes, The LVDS SN65DSI84 bridge and panel connector, is part of the standard board.
Quoted 18 lines
Quoted 18 lines
The LVDS and HDMI displays share a common DSI output, so only one interface can be active at a time. At present,
talos-evk-lvds.dtsincludestalos-evk.dtsdirectly so that the base SoM and carrier interfaces (e.g., MicroSD, power button) remain available.However, as you pointed out, including a .dts file directly is not recommended upstream. To address this, I am considering the following restructuring options:
Option 1: Introduce a
talos-cb.dtsi
talos-som.dtsi: SoM-specific interfacestalos-cb.dtsi: common carrier board interfaces (MicroSD, power button, etc.)talos-evk.dts: includestalos-som.dtsi+talos-cb.dtsi+ HDMItalos-evk-lvds.dts: includestalos-som.dtsi+talos-cb.dtsi+ LVDS
Quoted 6 lines
Quoted 4 lines
This approach avoids including .dts files directly and keeps the carrier board interfaces centralized and reusable.It also cleanly separates SoM and CB content and is consistent with how other Qualcomm platforms structure their EVK variants.
This sounds okay, but please respond to previous questions.
I hope I addressed previous question.
I will go with this option, and update v2 patch accordingly.
Quoted 19 lines
Quoted 3 lines
Option 2: Move CB interfaces to
talos-som.dtsi(disabled by default)Why? What happens when somebody reuses the SoM with some other base board?
Quoted 9 lines
Move MicroSD, power button, etc., to
talos-som.dtsiwith status = "disabled"; Enable these interfaces in each top-level DTS (e.g.,talos-evk.dts,talos-evk-lvds.dts)
While this also avoids .dts inclusion, it may make the SoM DTS unnecessarily complex and less reusable, as those CB-specific peripherals don’t belong to the SoM hardware.Let me know your prepared approach here.
If you yourself don't like the second option, why do you propose it?
Bjorn Andersson
maintainerRe: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
In reply to Tessolve UpstreamQuoted 79 lines · Tessolve Upstream
Quoted 10 lines · Bjorn Andersson
Quoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Okay, will update in next patch.
Quoted 46 lines
Quoted 35 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
Quoted 8 lines
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Regards,
BjornThanks for the feedback.
Currently, the Talos device tree hierarchy is organized as follows:
talos-som.dtsi— defines SoM-specific interfacestalos-evk.dts— adds carrier board (CB) interfaces such as MicroSD, power button, and HDMItalos-evk-lvds.dts— enables the LVDS display (includes SoM + CB + LVDS + disables HDMI)
Quoted 5 lines
The LVDS and HDMI displays share a common DSI output, so only one interface can be active at a time. At present,
talos-evk-lvds.dtsincludestalos-evk.dtsdirectly so that the base SoM and carrier interfaces (e.g., MicroSD, power button) remain available.
Are you saying that there are 2 PCBs involved:
1) The SOM
2) The EVK
And then perhaps a DIP switch or something to disable HDMI and select LVDS?
Or are you saying there are 3 PCBs:
1) The SOM
2) The EVK
3) Something that provides LVDS - and disables HDMI on the EVK
Quoted 8 lines
However, as you pointed out, including a .dts file directly is not recommended upstream. To address this, I am considering the following restructuring options:
Option 1: Introduce a
talos-cb.dtsi
talos-som.dtsi: SoM-specific interfacestalos-cb.dtsi: common carrier board interfaces (MicroSD, power button, etc.)
I'm guessing that what you call "carrier board" most would call "EVK"?
Quoted 2 lines
talos-evk.dts: includestalos-som.dtsi+talos-cb.dtsi+ HDMItalos-evk-lvds.dts: includestalos-som.dtsi+talos-cb.dtsi+ LVDS
Is this an actual thing, or a different configuration?
Quoted 5 lines
This approach avoids including .dts files directly and keeps the carrier board interfaces centralized and reusable.It also cleanly separates SoM and CB content and is consistent with how other Qualcomm platforms structure their EVK variants.
Can you point to an example where this is done?
The examples that comes to mind is e.g. the vison board/mezzanine. Those are separate physical things that you plug on top of the other boards, that's why they are described the way they are.
Quoted 4 lines
Option 2: Move CB interfaces to
talos-som.dtsi(disabled by default)Move MicroSD, power button, etc., to
talos-som.dtsiwith status = "disabled";
If those components are physically mounted on the SOM, then that is the correct thing to do.
If you suggest moving them there to solve some other problem, then it's not the right solution.
Quoted 7 lines
Enable these interfaces in each top-level DTS (e.g.,
talos-evk.dts,talos-evk-lvds.dts)
While this also avoids .dts inclusion, it may make the SoM DTS unnecessarily complex and less reusable, as those CB-specific peripherals don’t belong to the SoM hardware.Let me know your prepared approach here.
My preferred approach is that you write DeviceTree that matches the hardware in front of you.
Regards,
Bjorn
Quoted 126 lines
Quoted 125 lines
Quoted 125 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +122
-0+ +/ { + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en { + compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>; + pinctrl-names = "default"; + #pwm-cells = <3>; + }; + + panel-lvds { + compatible = "auo,g133han01"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* LVDS A (Odd pixels) */ + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + lvds_panel_out_a: endpoint { + remote-endpoint = <&sn65dsi84_out_a>; + }; + }; + + /* LVDS B (Even pixels) */ + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + lvds_panel_out_b: endpoint { + remote-endpoint = <&sn65dsi84_out_b>; + }; + }; + }; + }; +}; + +&adv7535 { + status = "disabled"; +}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + sn65dsi84: sn65dsi84@2c { + compatible = "ti,sn65dsi84"; + reg = <0x2c>; + enable-gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>; + ti,dsi-lanes = <4>; + ti,lvds-format = "jeida-24"; + ti,lvds-bpp = <24>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + sn65dsi84_in: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@2 { + reg = <2>; + + sn65dsi84_out_a: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_a>; + }; + }; + + port@3 { + reg = <3>; + + sn65dsi84_out_b: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_b>; + }; + }; + }; + }; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&sn65dsi84_in>; + data-lanes = <0 1 2 3>; +}; + +&tlmm { + lcd0_bklt_en: lcd0-bklt-en-state { + pins = "gpio115"; + function = "gpio"; + bias-disable; + }; + + lcd0_bklt_pwm: lcd0-bklt-pwm-state { + pins = "gpio59"; + function = "gpio"; + bias-disable; + }; +};Signature · 1 line
2.34.1
Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Quoted 80 lines · Bjorn Andersson
Quoted 79 lines · Tessolve Upstream
Quoted 10 lines · Bjorn Andersson
Quoted 1 line · Sudarshan Shetty
This patch introduces a new device tree for the QCS615 Talos
"This patch" doesn't make sense when you look at the git log once the patch has been accepted, please avoid it.
Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Start your commit message with a "problem description", describe what this LVDS talos is, why it should have it's own dts file etc.
Okay, will update in next patch.
Quoted 46 lines
Quoted 35 lines
EVK platform with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.where channel-A carries odd pixel and channel-B carries even pixel on the QCS615 talos evk platform.
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -307,6 +307,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += talos-evk-dsi.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +0
-0arch/arm64/boot/dts/qcom/talos-evk-lvds.dts line 6
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +6
-0@@ -0,0 +1,128 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; +#include "talos-evk.dts"We don't include .dts files, split the existing one in a dtsi and dts file and then include the dtsi here. Or provide provide this as a dtso overlay on top of the dts.
Quoted 8 lines
It's not clear to me which is the correct way, because you didn't adequately described how the SN65DSI84 enter the picture. Is it always there, but not part of the standard dip-switch configuration? Or is this some mezzanine?
Regards,
BjornThanks for the feedback.
Currently, the Talos device tree hierarchy is organized as follows:
talos-som.dtsi— defines SoM-specific interfacestalos-evk.dts— adds carrier board (CB) interfaces such as MicroSD, power button, and HDMItalos-evk-lvds.dts— enables the LVDS display (includes SoM + CB + LVDS + disables HDMI)
Quoted 7 lines
Quoted 5 lines
The LVDS and HDMI displays share a common DSI output, so only one interface can be active at a time. At present,
talos-evk-lvds.dtsincludestalos-evk.dtsdirectly so that the base SoM and carrier interfaces (e.g., MicroSD, power button) remain available.Are you saying that there are 2 PCBs involved:
Yes, 2 PCBs involved,
Quoted 5 lines
1) The SOM
2) The EVKAnd then perhaps a DIP switch or something to disable HDMI and select LVDS?
DIP switch is used to select either HDMI or LVDS
Quoted 2 lines
Or are you saying there are 3 PCBs:
No.
Quoted 8 lines
1) The SOM
2) The EVK
3) Something that provides LVDS - and disables HDMI on the EVKQuoted 4 lines
However, as you pointed out, including a .dts file directly is not recommended upstream. To address this, I am considering the following restructuring options:
Quoted 6 lines
Quoted 4 lines
Option 1: Introduce a
talos-cb.dtsi
talos-som.dtsi: SoM-specific interfacestalos-cb.dtsi: common carrier board interfaces (MicroSD, power button, etc.)I'm guessing that what you call "carrier board" most would call "EVK"?
Yes.
Quoted 11 lines
Quoted 10 lines
talos-evk.dts: includestalos-som.dtsi+talos-cb.dtsi+ HDMItalos-evk-lvds.dts: includestalos-som.dtsi+talos-cb.dtsi+ LVDSThis approach avoids including .dts files directly and keeps the carrier board interfaces centralized and reusable.It also cleanly separates SoM and CB content and is consistent with how other Qualcomm platforms structure their EVK variants.
Quoted 5 lines
Can you point to an example where this is done?
The examples that comes to mind is e.g. the vison board/mezzanine. Those are separate physical things that you plug on top of the other boards, that's why they are described the way they are.
This example that comes to mind. Which is restructuring code that matches Device Tree and hardware.
Quoted 11 lines
Quoted 5 lines
Option 2: Move CB interfaces to
talos-som.dtsi(disabled by default)Move MicroSD, power button, etc., to
talos-som.dtsiwith status = "disabled";If those components are physically mounted on the SOM, then that is the correct thing to do.
If you suggest moving them there to solve some other problem, then it's not the right solution.
Understood.
Quoted 11 lines
Quoted 8 lines
Enable these interfaces in each top-level DTS (e.g.,
talos-evk.dts,talos-evk-lvds.dts)
While this also avoids .dts inclusion, it may make the SoM DTS unnecessarily complex and less reusable, as those CB-specific peripherals don’t belong to the SoM hardware.Let me know your prepared approach here.
My preferred approach is that you write DeviceTree that matches the hardware in front of you.
Which is taken care in v2 patch.
https://lore.kernel.org/all/[email protected]/T/#u
Quoted 130 lines
Regards,
BjornQuoted 126 lines
Quoted 125 lines
Quoted 125 lines
arch/arm64/boot/dts/qcom/talos-evk-lvds.dts new file +122
-0+ +/ { + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + default-on; + }; + + lcd0_pwm_en { + compatible = "pwm-gpio"; + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&lcd0_bklt_pwm>; + pinctrl-names = "default"; + #pwm-cells = <3>; + }; + + panel-lvds { + compatible = "auo,g133han01"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* LVDS A (Odd pixels) */ + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + lvds_panel_out_a: endpoint { + remote-endpoint = <&sn65dsi84_out_a>; + }; + }; + + /* LVDS B (Even pixels) */ + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + lvds_panel_out_b: endpoint { + remote-endpoint = <&sn65dsi84_out_b>; + }; + }; + }; + }; +}; + +&adv7535 { + status = "disabled"; +}; + +&i2c1 { + clock-frequency = <400000>; + + status = "okay"; + + sn65dsi84: sn65dsi84@2c { + compatible = "ti,sn65dsi84"; + reg = <0x2c>; + enable-gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>; + ti,dsi-lanes = <4>; + ti,lvds-format = "jeida-24"; + ti,lvds-bpp = <24>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + sn65dsi84_in: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@2 { + reg = <2>; + + sn65dsi84_out_a: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_a>; + }; + }; + + port@3 { + reg = <3>; + + sn65dsi84_out_b: endpoint { + data-lanes = <0 1 2 3>; + remote-endpoint = <&lvds_panel_out_b>; + }; + }; + }; + }; +}; + +&mdss_dsi0 { + vdda-supply = <&vreg_l11a>; + + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <&sn65dsi84_in>; + data-lanes = <0 1 2 3>; +}; + +&tlmm { + lcd0_bklt_en: lcd0-bklt-en-state { + pins = "gpio115"; + function = "gpio"; + bias-disable; + }; + + lcd0_bklt_pwm: lcd0-bklt-pwm-state { + pins = "gpio59"; + function = "gpio"; + bias-disable; + }; +};Signature · 1 line
2.34.1
Bjorn Andersson
maintainerQuoted 3 lines · Sudarshan Shetty
Hi all,
This patch introduces a new device tree for the QCS615 Talos EVK platform
"This patch"? There shouldn't be a need for a cover letter for a single patch, the patch commit message should describe itself; as any information in the cover-letter is lost in the mail archive when the patch is merged.
Also, please transition to b4, per our internal guidelines.
Regards,
Bjorn
Quoted 28 lines
with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.In this setup:
- LVDS Channel A carries odd pixels.
- LVDS Channel B carries even pixels.This patch only adds the new DTS and corresponding
Makefileentry.Thanks,
Sudarshan---
Sudarshan Shetty (1):
arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panelarch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsSignature · 1 line
2.34.1
Quoted 11 lines · Bjorn Andersson
Quoted 3 lines · Sudarshan Shetty
Hi all,
This patch introduces a new device tree for the QCS615 Talos EVK platform
"This patch"? There shouldn't be a need for a cover letter for a single patch, the patch commit message should describe itself; as any information in the cover-letter is lost in the mail archive when the patch is merged.
Quoted 4 lines
Also, please transition to b4, per our internal guidelines.
Regards,
Bjorn
Understood, will take care.
Quoted 29 lines
Quoted 29 lines
with dual-channel LVDS display support.
The new DTS file (
talos-evk-lvds.dts) is based on the existingtalos-evk.dtsand extends it to enable a dual-channel LVDS display configuration using the TI SN65DSI84 DSI-to-LVDS bridge.In this setup:
- LVDS Channel A carries odd pixels.
- LVDS Channel B carries even pixels.This patch only adds the new DTS and corresponding
Makefileentry.Thanks,
Sudarshan---
Sudarshan Shetty (1):
arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panelarch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-lvds.dts | 128 ++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds.dtsSignature · 1 line
2.34.1