Skip to contentSkip to conversation

dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property

PATCH Superseded Marek Vasut 4 participants 5 messages Dec 12, 2022 – Dec 13, 2022

Subsystems (4)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Marek Vasut

author maintainer
#0 lore raw

PATCH v3 1/1 dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example

---
 .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +17 -0
index 876015a44a1e6..1f17be501749b 100644
@@ -52,6 +52,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
   port:
     $ref: /schemas/graph.yaml#/properties/port
     description: The LCDIF output port
@@ -87,6 +90,19 @@ allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6sl-lcdif
+              - fsl,imx6sx-lcdif
+              - fsl,imx8mm-lcdif
+              - fsl,imx8mn-lcdif
+              - fsl,imx8mp-lcdif
+    then:
+      required:
+        - power-domains
 
 examples:
   - |
@@ -101,6 +117,7 @@ examples:
                  <&clks IMX6SX_CLK_LCDIF_APB>,
                  <&clks IMX6SX_CLK_DISPLAY_AXI>;
         clock-names = "pix", "axi", "disp_axi";
+        power-domains = <&pd_disp>;
 
         port {
             endpoint {
Signature · 1 line
2.35.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 22 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example

Quoted 4 lines
---
 .../devicetree/bindings/display/fsl,lcdif.yaml  | 17
+++++++++++++++++
 1 file changed, 17 insertions(+)
#2 lore raw
In reply to Marek Vasut
Quoted 32 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example

---
 .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0 -0
index 876015a44a1e6..1f17be501749b 100644

Documentation/devicetree/bindings/display/fsl,lcdif.yaml properties: · line 57

Quoted 6 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
@@ -52,6 +52,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+

This conflicts with adding 'power-domains' for i.MX8MP in my tree.

Quoted 34 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +14 -1
   port:
     $ref: /schemas/graph.yaml#/properties/port
     description: The LCDIF output port
@@ -87,6 +90,19 @@ allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6sl-lcdif
+              - fsl,imx6sx-lcdif
+              - fsl,imx8mm-lcdif
+              - fsl,imx8mn-lcdif
+              - fsl,imx8mp-lcdif
+    then:
+      required:
+        - power-domains
 
 examples:
   - |
@@ -101,6 +117,7 @@ examples:
                  <&clks IMX6SX_CLK_LCDIF_APB>,
                  <&clks IMX6SX_CLK_DISPLAY_AXI>;
         clock-names = "pix", "axi", "disp_axi";
+        power-domains = <&pd_disp>;
 
         port {
             endpoint {
--

2.35.1

#3 lore raw
Quoted 36 lines · Rob Herring
Quoted 35 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example

---
 .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0 -0
index 876015a44a1e6..1f17be501749b 100644
@@ -52,6 +52,9 @@ properties:
   interrupts:
     maxItems: 1
 
Quoted 5 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml properties: · line 57

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+  power-domains:
+    maxItems: 1
+

This conflicts with adding 'power-domains' for i.MX8MP in my tree.

Yes, this is a duplicated patch.

Please either check for already submitted works in lore (dfn:) or use linux-next as your base...

Unack.

Best regards,
Krzysztof

author maintainer
#4 lore raw
Quoted 43 lines · Krzysztof Kozlowski
Quoted 36 lines · Rob Herring
Quoted 35 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example

---
  .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0 -0
index 876015a44a1e6..1f17be501749b 100644
@@ -52,6 +52,9 @@ properties:
    interrupts:
      maxItems: 1
 
Quoted 5 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml properties: · line 57

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+  power-domains:
+    maxItems: 1
+

This conflicts with adding 'power-domains' for i.MX8MP in my tree.

Quoted 4 lines

Yes, this is a duplicated patch.

Please either check for already submitted works in lore (dfn:) or use linux-next as your base...

Understood, I only used linux-next 20221208 , which was the latest available at that point.

If I rebase on today's next-20221213 , I see the only duplicate part is

"
+ power-domains:
+ maxItems: 1
+
"

The rest of this patch is still valid.

Quoted 1 line

Unack.

I see