Skip to contentSkip to conversation

New man page corrections - windows-options.rst

PATCH In review Richard Bonhomme 2 participants 4 messages Jul 1, 2020 – Jul 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 New man page corrections - windows-options.rst

---
 doc/man-sections/windows-options.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
doc/man-sections/windows-options.rst +2 -2
index 5ae7116c..72424d6b 100644
@@ -231,7 +231,7 @@ Windows-Specific Options
   directive is not specified, OpenVPN will use the SystemRoot environment
   variable.
 
-  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
+  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
   define ``--win-sys env`` to use the SystemRoot environment variable,
   otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
   the ``env`` keyword any more, and it will just be ignored. A warning is
@@ -239,7 +239,7 @@ Windows-Specific Options
 
 --windows-driver drv
   Specifies which tun driver to use. Values are :code:`tap-windows6`
-  (default) and :code:`wintun`.  This is Windows-only option.
+  (default) and :code:`wintun`.  This is a Windows-only option.
   :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
   elevated, or be invoked using the Interactive Service.
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Improves English diction and/or grammar of man page.

Quoted 37 lines · Richard Bonhomme
---
 doc/man-sections/windows-options.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
doc/man-sections/windows-options.rst +2 -3
index 5ae7116c..72424d6b 100644
@@ -231,7 +231,7 @@ Windows-Specific Options
   directive is not specified, OpenVPN will use the SystemRoot environment
   variable.
 
-  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
+  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
   define ``--win-sys env`` to use the SystemRoot environment variable,
   otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
   the ``env`` keyword any more, and it will just be ignored. A warning is
@@ -239,7 +239,7 @@ Windows-Specific Options
 
 --windows-driver drv
   Specifies which tun driver to use. Values are :code:`tap-windows6`
-  (default) and :code:`wintun`.  This is Windows-only option.
+  (default) and :code:`wintun`.  This is a Windows-only option.
   :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
   elevated, or be invoked using the Interactive Service.
 
--

2.17.1

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#2 lore raw

Hi Jonathan,

these are going to the new manpage, see:
https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting

They don't really need an ACK because dazo will review them first anyway but thanks all the same :)

Regards

Quoted 42 lines · Jonathan K. Bullard

Improves English diction and/or grammar of man page.

Quoted 37 lines · Richard Bonhomme
---
  doc/man-sections/windows-options.rst | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
doc/man-sections/windows-options.rst +2 -3
index 5ae7116c..72424d6b 100644
@@ -231,7 +231,7 @@ Windows-Specific Options
    directive is not specified, OpenVPN will use the SystemRoot environment
    variable.
 
-  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
+  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
    define ``--win-sys env`` to use the SystemRoot environment variable,
    otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
    the ``env`` keyword any more, and it will just be ignored. A warning is
@@ -239,7 +239,7 @@ Windows-Specific Options
 
  --windows-driver drv
    Specifies which tun driver to use. Values are :code:`tap-windows6`
-  (default) and :code:`wintun`.  This is Windows-only option.
+  (default) and :code:`wintun`.  This is a Windows-only option.
    :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
    elevated, or be invoked using the Interactive Service.
 
--

2.17.1

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#3 lore raw

BTW: This is only round 1 of spelling and grammar checking. I have had to really hold off from getting nasty with commas etc. I have tried to only fix the most obvious faux-pars ... ;-)

Quoted 54 lines · tincanteksup

Hi Jonathan,

these are going to the new manpage, see:
https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting

They don't really need an ACK because dazo will review them first anyway but thanks all the same :)

Regards

Quoted 43 lines · Jonathan K. Bullard

Improves English diction and/or grammar of man page.

Quoted 38 lines · Richard Bonhomme

---
  doc/man-sections/windows-options.rst | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
doc/man-sections/windows-options.rst +0 -0
index 5ae7116c..72424d6b 100644
@@ -231,7 +231,7 @@ Windows-Specific Options

    directive is not specified, OpenVPN will use the SystemRoot environment variable.

-  This option have changed behaviour in OpenVPN 2.3. Earlier you had to +  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
    define ``--win-sys env`` to use the SystemRoot environment variable, otherwise it defaulted to :code:C:\\WINDOWS. It is not needed to use the ``env`` keyword any more, and it will just be ignored. A warning is

doc/man-sections/windows-options.rst +0 -0
@@ -239,7 +239,7 @@ Windows-Specific Options
 

  --windows-driver drv
    Specifies which tun driver to use. Values are :code:tap-windows6 -  (default) and :code:wintun.  This is Windows-only option. +  (default) and :code:wintun.  This is a Windows-only option. :code:wintun" requires ``--dev tun`` and the OpenVPN process to run elevated, or be invoked using the Interactive Service.

Signature · 8 lines
2.17.1



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel