filemap: Remove redundant folio_test_large check in filemap_free_folio
Subsystems (3)
PATCH 1/1 filemap: Remove redundant folio_test_large check in filemap_free_folio
From: Guanjun <[email protected]>
The folio_test_large check in filemap_free_folio is unnecessary because folio_nr_pages, which is called internally, already performs this check. Removing the redundant condition simplifies the code and avoids double validation.
This change improves code readability and reduces unnecessary operations in the folio freeing path.
--- mm/filemap.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
mm/filemap.c +1 -4
@@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio *folio, void *shadow)void filemap_free_folio (struct address_space *mapping,struct folio *folio) {void (*free_folio)(struct folio *); -int refs =1 ; free_folio = mapping->a_ops->free_folio;if (free_folio)free_folio (folio); -if (folio_test_large (folio)) - refs =folio_nr_pages (folio); -folio_put_refs (folio, refs); +folio_put_refs (folio,folio_nr_pages (folio)); }/**
Signature · 1 line
2.43.5
Quoted 26 lines · Guanjun
From: Guanjun <[email protected]>
The
folio_test_largecheck infilemap_free_foliois unnecessary becausefolio_nr_pages, which is called internally, already performs this check. Removing the redundant condition simplifies the code and avoids double validation.This change improves code readability and reduces unnecessary operations in the folio freeing path.
Signed-off-by Guanjun <[email protected]>--- mm/filemap.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)mm/filemap.c +0
-1@@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio *folio, void *shadow)void filemap_free_folio (struct address_space *mapping,struct folio *folio) {void (*free_folio)(struct folio *); -int refs =1 ; free_folio = mapping->a_ops->free_folio;
mm/filemap.c void __filemap_remove_folio(struct folio *folio, void *shadow) · line 238
Quoted 10 lines
mm/filemap.c +1
-3if (free_folio)free_folio (folio); -if (folio_test_large (folio)) - refs =folio_nr_pages (folio); -folio_put_refs (folio, refs); +folio_put_refs (folio,folio_nr_pages (folio)); }/**
Signature · 3 lines
Cheers, David / dhildenb