Skip to contentSkip to conversation

arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 board

PATCH In review Chaoyi Chen 5 participants 15 messages Jan 21 – Jan 31

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 board

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Some background, for RK3576, you can assume that:

        tx_delay_time(ns) = 0.0579 * delay_line_count + 0.105

For example, tx_delay = <0x20> means:

        time = 0.0579 * 0x20 + 0.105 ns = 1.9578 ns

Recently, Andrew has often mentioned the problem of phy mode in board level configuration. So let's start with the RK3576 to modify this.

Please test this series of patches, thanks.

Chaoyi Chen (3):
arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1
arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for

    roc-rk3576-pc

arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for ROCK 4D

 arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 8 ++++----
 arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dts   | 5 ++---
 arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts  | 5 ++---
 3 files changed, 8 insertions(+), 10 deletions(-)
Signature · 1 line
2.51.1
#1 lore raw

PATCH 1/3 arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Let's describe this part of the delay in the PHY and use the more reasonable "rgmii-id" mode.

---
 arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +4 -4
index c5584c26db52..3ee76bafafb5 100644
@@ -266,7 +266,7 @@ &combphy1_psu {
 
 &gmac0 {
 	clock_in_out = "output";
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	phy-handle = <&rgmii_phy0>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth0m0_miim
@@ -275,14 +275,13 @@ &eth0m0_rx_bus2
 		     &eth0m0_rgmii_clk
 		     &eth0m0_rgmii_bus
 		     &ethm0_clk0_25m_out>;
-	tx_delay = <0x21>;
 	status = "okay";
 };
 
 &gmac1 {
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy1>;
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth1m0_miim
 		     &eth1m0_tx_bus2
@@ -290,7 +289,6 @@ &eth1m0_rx_bus2
 		     &eth1m0_rgmii_clk
 		     &eth1m0_rgmii_bus
 		     &ethm0_clk1_25m_out>;
-	tx_delay = <0x20>;
 	status = "okay";
 };
 
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;
 	};
 };
 
@@ -737,6 +736,7 @@ rgmii_phy1: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;
 	};
 };
 
Signature · 1 line
2.51.1
#2 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

Quoted 32 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Let's describe this part of the delay in the PHY and use the more reasonable "rgmii-id" mode.

---
 arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -1
index c5584c26db52..3ee76bafafb5 100644
@@ -266,7 +266,7 @@ &combphy1_psu {
 
 &gmac0 {
 	clock_in_out = "output";
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	phy-handle = <&rgmii_phy0>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth0m0_miim

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts &eth0m0_rx_bus2 · line 278

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +0 -1
@@ -275,14 +275,13 @@ &eth0m0_rx_bus2
 		     &eth0m0_rgmii_clk
 		     &eth0m0_rgmii_bus
 		     &ethm0_clk0_25m_out>;
-	tx_delay = <0x21>;

This being '0x21' (not '0x20') ...

Quoted 20 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -2
 	status = "okay";
 };
 
 &gmac1 {
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy1>;
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth1m0_miim
 		     &eth1m0_tx_bus2
@@ -290,7 +289,6 @@ &eth1m0_rx_bus2
 		     &eth1m0_rgmii_clk
 		     &eth1m0_rgmii_bus
 		     &ethm0_clk1_25m_out>;
-	tx_delay = <0x20>;
 	status = "okay";
 };
 

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

... shouldn't this be higher?
0.0579 * 0x21 + 0.105 = 2.0157 (not sure how the rounding goes)

Cheers,
Diederik

Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
 	};
 };
 
@@ -737,6 +736,7 @@ rgmii_phy1: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;
 	};
 };
 
#3 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

In reply to Chaoyi Chen

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay.

In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed.

Andrew

#4 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

Hi Andrew,

Quoted 9 lines · Andrew Lunn

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay.

Thank you for the clarification. I chose 1950 here because I find that the MotorComm yt8xxx Ethernet PHY binding only offer the options of 1950 or 2100.

Quoted 3 lines

In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed.

I suspect the ROCK 4D board might be an exception. Sebastian once reported that it wouldn't work properly under "rgmii-id". Well, I'm not sure what strategy to adopt in this case.

Signature · 2 lines
Best, 
Chaoyi
#5 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

Quoted 17 lines · Chaoyi Chen

Hi Andrew,

Quoted 9 lines · Andrew Lunn

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay.

Thank you for the clarification. I chose 1950 here because I find that the MotorComm yt8xxx Ethernet PHY binding only offer the options of 1950 or 2100.

Quoted 7 lines
Quoted 3 lines

In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed.

I suspect the ROCK 4D board might be an exception. Sebastian once reported that it wouldn't work properly under "rgmii-id". Well, I'm not sure what strategy to adopt in this case.

Please check the report. And also, check what the PHY is doing for delays if you don't specify the property. Is it defaulting to near 2000ps?

Andrew

#6 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

Hi Andrew,

Quoted 22 lines · Andrew Lunn
Quoted 21 lines · Chaoyi Chen

Hi Andrew,

Quoted 9 lines · Andrew Lunn

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay.

Thank you for the clarification. I chose 1950 here because I find that the MotorComm yt8xxx Ethernet PHY binding only offer the options of 1950 or 2100.

Quoted 3 lines

In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed.

Quoted 8 lines
Quoted 3 lines

I suspect the ROCK 4D board might be an exception. Sebastian once reported that it wouldn't work properly under "rgmii-id". Well, I'm not sure what strategy to adopt in this case.

Please check the report. And also, check what the PHY is doing for delays if you don't specify the property. Is it defaulting to near 2000ps?

It is RTL8211F PHY. The origin report is here:

https://lore.kernel.org/all/[email protected]/

The RTL8211F binding doesn't provide any indication of the default delay value. I'll checking datasheet to see if it's mentioned there.

Signature · 2 lines
Best, 
Chaoyi
#7 lore raw

Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1

Quoted 34 lines · Chaoyi Chen

Hi Andrew,

Quoted 22 lines · Andrew Lunn
Quoted 21 lines · Chaoyi Chen

Hi Andrew,

Quoted 9 lines · Andrew Lunn

arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts rgmii_phy0: ethernet-phy@1 { · line 722

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts +1 -0
@@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;

The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay.

Thank you for the clarification. I chose 1950 here because I find that the MotorComm yt8xxx Ethernet PHY binding only offer the options of 1950 or 2100.

Quoted 3 lines

In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed.

Quoted 8 lines
Quoted 3 lines

I suspect the ROCK 4D board might be an exception. Sebastian once reported that it wouldn't work properly under "rgmii-id". Well, I'm not sure what strategy to adopt in this case.

Please check the report. And also, check what the PHY is doing for delays if you don't specify the property. Is it defaulting to near 2000ps?

Quoted 7 lines

It is RTL8211F PHY. The origin report is here:

https://lore.kernel.org/all/[email protected]/

The RTL8211F binding doesn't provide any indication of the default delay value. I'll checking datasheet to see if it's mentioned there.

If "rgmii-id" is set, the RTL8211F driver adds the 2ns delay:

[0] https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/net/phy/realtek/realtek_main.c#L602

Sebastian, could you try testing how much extra delay the GMAC still needs to add for the ROCK4D to work correctly, assuming the PHY already has a 2 ns delay when "rgmii-id" is set?

Signature · 7 lines
Best, 
Chaoyi

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#8 lore raw

PATCH 2/3 arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for roc-rk3576-pc

In reply to Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Let's describe this part of the delay in the PHY and use the more reasonable "rgmii-id" mode.

---
 arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dts +2 -3
index d0ab1d1e0e11..edef483d37c4 100644
@@ -275,10 +275,8 @@ &eth0m0_rx_bus2
 		     &eth0m0_rgmii_clk
 		     &eth0m0_rgmii_bus
 		     &ethm0_clk0_25m_out>;
-	/* Use rgmii-rxid mode to disable rx delay inside Soc */
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	phy-handle = <&rgmii_phy0>;
-	tx_delay = <0x21>;
 	status = "okay";
 };
 
@@ -313,6 +311,7 @@ rgmii_phy0: phy@1 {
 		reset-delay-us = <20000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
 		reset-post-delay-us = <100000>;
+		tx-internal-delay-ps = <1950>;
 	};
 };
 
Signature · 1 line
2.51.1
#9 lore raw

PATCH 3/3 arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for ROCK 4D

In reply to Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Let's describe this part of the delay in the PHY and use the more reasonable "rgmii-id" mode.

---
 arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts +2 -3
index 3e9c294cab91..70018c34cf08 100644
@@ -329,7 +329,7 @@ &cpu_l3 {
 &gmac0 {
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii-rxid";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&eth0m0_miim
 		     &eth0m0_tx_bus2
@@ -338,8 +338,6 @@ &eth0m0_rgmii_clk
 		     &eth0m0_rgmii_bus
 		     &ethm0_clk0_25m_out>;
 	status = "okay";
-	tx_delay = <0x20>;
-	rx_delay = <0x00>;
 };
 
 &gpu {
@@ -772,6 +770,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		tx-internal-delay-ps = <1950>;
 	};
 };
 
Signature · 1 line
2.51.1
#10 lore raw
In reply to Chaoyi Chen

Hi,

Quoted 14 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Some background, for RK3576, you can assume that:

        tx_delay_time(ns) = 0.0579 * delay_line_count + 0.105
Quoted 8 lines

For example, tx_delay = <0x20> means:

        time = 0.0579 * 0x20 + 0.105 ns = 1.9578 ns

Recently, Andrew has often mentioned the problem of phy mode in board level configuration. So let's start with the RK3576 to modify this.

Please test this series of patches, thanks.

The RTL8211F PHY driver does not use the "tx-internal-delay-ps" property, which would require using phy_get_internal_delay(). Also the hardware only seems to support enabling/disabling a fixed delay of 2ns, so it cannot be implemented as far as I can tell. So unless I missed something, this series makes no sense as-is.

My suggestion would be to add support for <rx/tx>-internal-delay-ps to the Rockchip GMAC driver by introducing a new rk_gmac_ops entry to translate the standard properties into register values:

int rk3576_delay_conversion(unsigned int delay_ps) {
    return (delay_ps*10 - 1050) / 579;
}

That allows using standard properties in DT instead of vendor specific "rx_delay"/"tx_delay". This results in a much better board description and shows how far boards derive from the the standard 2ns (which can use rgmii-id without any extra delay specification).

Greetings,

-- Sebastian

#11 lore raw

Hi Sebastian, Andrew,

Quoted 36 lines · Sebastian Reichel

Hi,

Quoted 14 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Some background, for RK3576, you can assume that:

        tx_delay_time(ns) = 0.0579 * delay_line_count + 0.105
Quoted 8 lines

For example, tx_delay = <0x20> means:

        time = 0.0579 * 0x20 + 0.105 ns = 1.9578 ns

Recently, Andrew has often mentioned the problem of phy mode in board level configuration. So let's start with the RK3576 to modify this.

Please test this series of patches, thanks.

The RTL8211F PHY driver does not use the "tx-internal-delay-ps" property, which would require using phy_get_internal_delay(). Also the hardware only seems to support enabling/disabling a fixed delay of 2ns, so it cannot be implemented as far as I can tell. So unless I missed something, this series makes no sense as-is.

My suggestion would be to add support for <rx/tx>-internal-delay-ps to the Rockchip GMAC driver by introducing a new rk_gmac_ops entry to translate the standard properties into register values:

Quoted 9 lines
int rk3576_delay_conversion(unsigned int delay_ps) {
    return (delay_ps*10 - 1050) / 579;
}

That allows using standard properties in DT instead of vendor specific "rx_delay"/"tx_delay". This results in a much better board description and shows how far boards derive from the the standard 2ns (which can use rgmii-id without any extra delay specification).

Oh, your approach was also my initial thought.

I first asked whether it would be more appropriate to implement this in the PHY or in the GMAC, and Andrew told me it should preferably be done in the PHY. But I'm not sure whether all PHYs support this operation.

Andrew, would it be possible to implement this in the GMAC for cases where the PHY does not support it? Thanks.

Signature · 2 lines
Best, 
Chaoyi
#12 lore raw
Quoted 8 lines
Quoted 5 lines

That allows using standard properties in DT instead of vendor specific "rx_delay"/"tx_delay". This results in a much better board description and shows how far boards derive from the the standard 2ns (which can use rgmii-id without any extra delay specification).

Oh, your approach was also my initial thought.

Quoted 7 lines

I first asked whether it would be more appropriate to implement this in the PHY or in the GMAC, and Andrew told me it should preferably be done in the PHY. But I'm not sure whether all PHYs support this operation.

Andrew, would it be possible to implement this in the GMAC for cases where the PHY does not support it? Thanks.

As i commented to one of the patches, the PHY will be adding 2ns by default when 'rgmii-id' is used. If you read the RGMII standard, you also see there is quite a wide tolerance for these delays. So unless there is a badly designed PCB which needs something well away from 2ns, i don't think it is necessary.

Andrew

#13 lore raw
In reply to Chaoyi Chen
Quoted 6 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

Quoted 7 lines

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Some background, for RK3576, you can assume that:

        tx_delay_time(ns) = 0.0579 * delay_line_count + 0.105

Where did this formula come from? Is it in the datasheet.

Andrew

#14 lore raw

Hi Andrew,

Quoted 11 lines · Andrew Lunn
Quoted 10 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

According to the description in the net documentation, PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal to be delayed on the PCB.

The Rockchip platform has long used the above mentioned PHY modes and private delay prop to describe the internal IO delay settings of the chip, which is inconsistent with what is described in the documentation.

Quoted 6 lines
Quoted 3 lines

Some background, for RK3576, you can assume that:

        tx_delay_time(ns) = 0.0579 * delay_line_count + 0.105

Where did this formula come from? Is it in the datasheet.

These are measured values obtained from hardware signal testing. They are not documented in the TRM.

Signature · 2 lines
Best, 
Chaoyi