env: mmc: Fix offset issue for env save
PATCH 1/1 env: mmc: Fix offset issue for env save
Fix the issue in commit 46c9016 (env: mcc: Drop unnecessary #ifdefs) If CONFIG_SYS_REDUNDAND_ENVIRONMENT is not defined, the offset value becomes undetermined, so write env to unexpected offset.
Signed-off-by Ye Li <[email protected]>
--- env/mmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
env/mmc.c +4 -4
@@ -273,11 +273,11 @@ static int env_mmc_save(void)if (ret) goto fini; } + } -if (mmc_get_env_addr (mmc, copy, &offset)) { - ret =1 ; - goto fini; - } +if (mmc_get_env_addr (mmc, copy, &offset)) { + ret =1 ; + goto fini; }printf ("Writing to %sMMC(%d)... " , copy ?"redundant " :"" , dev);
Signature · 1 line
2.7.4
Quoted 5 lines · Ye Li
Fix the issue in commit 46c9016 (env: mcc: Drop unnecessary #ifdefs) If
CONFIG_SYS_REDUNDAND_ENVIRONMENTis not defined, the offset value becomes undetermined, so write env to unexpected offset.Signed-off-by Ye Li <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>
Best Regards,
Jaehoon Chung
Quoted 24 lines
--- env/mmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)env/mmc.c +4
-4@@ -273,11 +273,11 @@ static int env_mmc_save(void)if (ret) goto fini; } + } -if (mmc_get_env_addr (mmc, copy, &offset)) { - ret =1 ; - goto fini; - } +if (mmc_get_env_addr (mmc, copy, &offset)) { + ret =1 ; + goto fini; }printf ("Writing to %sMMC(%d)... " , copy ?"redundant " :"" , dev);
Quoted 6 lines · Ye Li
Fix the issue in commit 46c9016 (env: mcc: Drop unnecessary #ifdefs) If
CONFIG_SYS_REDUNDAND_ENVIRONMENTis not defined, the offset value becomes undetermined, so write env to unexpected offset.Signed-off-by Ye Li <[email protected]>Reviewed-by Jaehoon Chung <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom