thermal: imx8mm_thermal: wait for a valid measurement
Subsystems (2)
PATCH v2 1/1 thermal: imx8mm_thermal: wait for a valid measurement
Check if first measurement is still pending or if temperature is out of range.
Return and try again later if that is the case.
---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)
drivers/thermal/imx8mm_thermal.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/thermal/imx8mm_thermal.c +9 -3
@@ -62,11 +62,17 @@ static int imx8mm_tmu_get_temp(void *data, int *temp) {struct tmu_sensor *sensor = data;struct imx8mm_tmu *tmu = sensor->priv; -u32 val; +bool ready; +unsigned long val; + + val =readl_relaxed (tmu->base +TRITSR ); + ready =test_bit (probe_status_offset (1 ), &val); +if (!ready) +return -EAGAIN ; - val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + val = val &TRITSR_TEMP0_VAL_MASK ; *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) +if (*temp <VER1_TEMP_LOW_LIMIT || *temp >VER2_TEMP_HIGH_LIMIT )return -EAGAIN ;return 0 ;
Signature · 1 line
2.37.1
Peng Fan
NAKQuoted 6 lines · Marcus Folkesson
Check if first measurement is still pending or if temperature is out of range.
Return and try again later if that is the case.Fixes 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")Signed-off-by Marcus Folkesson <[email protected]>
NAK:
Please refer: https://www.nxp.com/docs/en/errata/IMX8MM_0N87W.pdf
ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
Thanks,
Peng.
Quoted 33 lines
---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)drivers/thermal/imx8mm_thermal.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)drivers/thermal/imx8mm_thermal.c +9
-3@@ -62,11 +62,17 @@ static int imx8mm_tmu_get_temp(void *data, int *temp) {struct tmu_sensor *sensor = data;struct imx8mm_tmu *tmu = sensor->priv; -u32 val; +bool ready; +unsigned long val; + + val =readl_relaxed (tmu->base +TRITSR ); + ready =test_bit (probe_status_offset (1 ), &val); +if (!ready) +return -EAGAIN ; - val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + val = val &TRITSR_TEMP0_VAL_MASK ; *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) +if (*temp <VER1_TEMP_LOW_LIMIT || *temp >VER2_TEMP_HIGH_LIMIT )return -EAGAIN ;return 0 ;
Hi Peng,
Quoted 7 lines · Peng Fan
Quoted 4 lines · Marcus Folkesson
Check if first measurement is still pending or if temperature is out of range.
Return and try again later if that is the case.
Quoted 6 lines
Quoted 2 lines
Fixes 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")Signed-off-by Marcus Folkesson <[email protected]>NAK:
Please refer: https://www.nxp.com/docs/en/errata/IMX8MM_0N87W.pdf
ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
I see, thank you.
I think it is still worth to check the upper limit though, so I will send a patch for that.
Quoted 3 lines
Thanks,
Peng.
Best regards,
Marcus Folkesson