Skip to contentSkip to conversation

speakup: remove usage of non-standard u_char

PATCH Superseded Yureka 3 participants 4 messages Oct 11, 2022 – Nov 9, 2022 1 message not in the archive Speakup console speech driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yureka

author
#0 lore raw

PATCH 1/1 speakup: remove usage of non-standard u_char

From: Yureka Lilian <[email protected]>

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

---
 drivers/accessibility/speakup/utils.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +0 -0
index 4bf2ee8ac..4ce9a12f7 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)


 static inline struct st_key *hash_name(char *name) {
-   u_char *pn = (u_char *)name;
+   unsigned char *pn = (unsigned char *)name; int hash = 0;

    while (*pn) {

Signature · 1 line
2.37.3
maintainer Reviewed-by on v1 1/1
#1 lore raw

Yureka, le mar. 11 oct. 2022 02:17:43 +0200, a ecrit:

Quoted 9 lines

From: Yureka Lilian <[email protected]>

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

Quoted 19 lines

---
 drivers/accessibility/speakup/utils.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +0 -0
index 4bf2ee8ac..4ce9a12f7 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)


 static inline struct st_key *hash_name(char *name) {
-   u_char *pn = (u_char *)name;
+   unsigned char *pn = (unsigned char *)name; int hash = 0;

    while (*pn) {

Signature · 1 line
2.37.3

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#3 lore raw
Quoted 40 lines · Greg KH
Quoted 18 lines · Yureka

From: Yureka Lilian <[email protected]>

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

---
 drivers/accessibility/speakup/utils.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +0 -0
index 4bf2ee8ac..4ce9a12f7 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
Quoted 10 lines


 static inline struct st_key *hash_name(char *name) {
-   u_char *pn = (u_char *)name;
+   unsigned char *pn = (unsigned char *)name; int hash = 0;

    while (*pn) {

Signature · 1 line
2.37.3

Hi,

This is the friendly semi-automated patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response.

Right now, the development tree you have sent a patch for is "closed" due to the timing of the merge window. Don't worry, the patch(es) you have sent are not lost, and will be looked at after the merge window is over (after the -rc1 kernel is released by Linus).

Quoted 8 lines

So thank you for your patience and your patches will be reviewed at this later time, you do not have to do anything further, this is just a short note to let you know the patch status and so you don't worry they didn't make it through.

thanks,

greg k-h's patch email bot

I noticed in hindsight this patch might be suitable for the 6.0.x stable line as well, since it is a build fix with otherwise seemingly little impact. Let me know if I should do anything to get it in the queue for stable/fix reviews.

Thanks,

Yureka

#4 lore raw
In reply to Yureka
Quoted 18 lines · Yureka

From: Yureka Lilian <[email protected]>

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

---
 drivers/accessibility/speakup/utils.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +0 -0
index 4bf2ee8ac..4ce9a12f7 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
Quoted 10 lines


 static inline struct st_key *hash_name(char *name) {
-   u_char *pn = (u_char *)name;
+   unsigned char *pn = (unsigned char *)name; int hash = 0;

    while (*pn) {

Signature · 1 line
2.37.3

This patch is corrupted and can not be applied. Please fix up and add the proper cc: stable tag when you resend it.

thanks,

greg k-h