Skip to contentSkip to conversation

add hotplug depedency info

PATCH Superseded Albert Zhou 2 participants 6 messages Nov 13, 2022 – Nov 15, 2022 PCI

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover add hotplug depedency info

v1->v2: I added comments that PCIe cards with USB4 or Thunderbolt also require the hotplug feature. I also added the "default y if USB4" line to the relevant config options, as suggested by Lukas Wunner.

Albert Zhou (2):
pci: hotplug: add dependency info to Kconfig
pci: pcie: add dependency info to Kconfig

 drivers/pci/hotplug/Kconfig | 4 +++-
 drivers/pci/pcie/Kconfig    | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d

Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 1/2 pci: hotplug: add dependency info to Kconfig

Thunderbolt and USB4 PCI cards require the hotplug feature. This is now recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is defaulted to Y if USB4 is selected.

---
 drivers/pci/hotplug/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/hotplug/Kconfig +3 -1
index 840a84bb5ee2..06cc373834f5 100644
@@ -6,10 +6,12 @@
 menuconfig HOTPLUG_PCI
 	bool "Support for PCI Hotplug"
 	depends on PCI && SYSFS
+	default y if USB4
 	help
 	  Say Y here if you have a motherboard with a PCI Hotplug controller.
 	  This allows you to add and remove PCI cards while the machine is
-	  powered up and running.
+	  powered up and running. Thunderbolt and USB4 PCI cards require
+	  Hotplug.
 
 	  When in doubt, say N.
 
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig

Quoted 14 lines · Albert Zhou

Thunderbolt and USB4 PCI cards require the hotplug feature. This is now recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is defaulted to Y if USB4 is selected.

---
 drivers/pci/hotplug/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/hotplug/Kconfig +0 -0
index 840a84bb5ee2..06cc373834f5 100644

drivers/pci/hotplug/Kconfig line 14

Quoted 10 lines
drivers/pci/hotplug/Kconfig +3 -1
@@ -6,10 +6,12 @@
 menuconfig HOTPLUG_PCI
 	bool "Support for PCI Hotplug"
 	depends on PCI && SYSFS
+	default y if USB4
 	help
 	  Say Y here if you have a motherboard with a PCI Hotplug controller.
 	  This allows you to add and remove PCI cards while the machine is
-	  powered up and running.
+	  powered up and running. Thunderbolt and USB4 PCI cards require
+	  Hotplug.

I would not say they "require" this. PCIe is completely optional in USB4 systems and it is perfectly fine to have host controllers or add-in-cards that don't have a single PCIe adapter.

Not objeting the patch, though. For Linux I guess it makes sense to have this like what you are suggesting. Just perhaps changing the wordirng ;-)

#3 lore raw

Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig

Quoted 11 lines · Mika Westerberg

drivers/pci/hotplug/Kconfig line 14

Quoted 7 lines
drivers/pci/hotplug/Kconfig +3 -1
+	default y if USB4
  	help
  	  Say Y here if you have a motherboard with a PCI Hotplug controller.
  	  This allows you to add and remove PCI cards while the machine is
-	  powered up and running.
+	  powered up and running. Thunderbolt and USB4 PCI cards require
+	  Hotplug.

I would not say they "require" this. PCIe is completely optional in USB4 systems and it is perfectly fine to have host controllers or add-in-cards that don't have a single PCIe adapter.

Quoted 3 lines

Not objeting the patch, though. For Linux I guess it makes sense to have this like what you are suggesting. Just perhaps changing the wordirng 😉

How about “Thunderbolt and USB4 use Hotplug”

Do you agree with the “default y if USB4” for PCIEPORTBUS, HOTPLUG_PCI_PCIE, HOTPLUG_PCI.

From Albert Zhou

#4 lore raw

Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig

Hi,

Quoted 12 lines · Albert Zhou
Quoted 11 lines · Mika Westerberg

drivers/pci/hotplug/Kconfig line 14

Quoted 7 lines
drivers/pci/hotplug/Kconfig +3 -1
+	default y if USB4
  	help
  	  Say Y here if you have a motherboard with a PCI Hotplug controller.
  	  This allows you to add and remove PCI cards while the machine is
-	  powered up and running.
+	  powered up and running. Thunderbolt and USB4 PCI cards require
+	  Hotplug.

I would not say they "require" this. PCIe is completely optional in USB4 systems and it is perfectly fine to have host controllers or add-in-cards that don't have a single PCIe adapter.

Quoted 5 lines
Quoted 3 lines

Not objeting the patch, though. For Linux I guess it makes sense to have this like what you are suggesting. Just perhaps changing the wordirng 😉

How about “Thunderbolt and USB4 use Hotplug”

Or

"Thunderbolt/USB4 PCIe tunneling needs Native PCIe Hotplug to be enabled"

Quoted 1 line

Do you agree with the “default y if USB4” for PCIEPORTBUS, HOTPLUG_PCI_PCIE, HOTPLUG_PCI.

Yes, I think for Linux perspective it makes sense to have them enabled by default.

#5 lore raw

PATCH v2 2/2 pci: pcie: add dependency info to Kconfig

In reply to Albert Zhou

Thunderbolt and USB4 PCIe cards require the hotplug feature. This is now recorded in the help message for HOTPLUG_PCI_PCIE. Further, PCIEPORTBUS and HOTPLUG_PCI_PCIE are defaulted to Y if USB4 is selected.

---
 drivers/pci/pcie/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pci/pcie/Kconfig +3 -2
index 788ac8df3f9d..6c54a4512e2b 100644
@@ -4,20 +4,21 @@
 #
 config PCIEPORTBUS
 	bool "PCI Express Port Bus support"
+	default y if USB4
 	help
 	  This enables PCI Express Port Bus support. Users can then enable
 	  support for Native Hot-Plug, Advanced Error Reporting, Power
 	  Management Events, and Downstream Port Containment.
-
 #
 # Include service Kconfig here
 #
 config HOTPLUG_PCI_PCIE
 	bool "PCI Express Hotplug driver"
 	depends on HOTPLUG_PCI && PCIEPORTBUS
+	default y if USB4
 	help
 	  Say Y here if you have a motherboard that supports PCI Express Native
-	  Hotplug
+	  Hotplug. Thunderbolt and USB4 PCIe cards require Hotplug.
 
 	  When in doubt, say N.
 
Signature · 1 line
2.34.1