Skip to contentSkip to conversation

ASoC: Intel: avs: Add missing audio amplifier for KBL

PATCH In review Alicja Michalska 4 participants 6 messages Nov 22, 2022 – Nov 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: avs: Add missing audio amplifier for KBL

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

sound/soc/intel/avs/board_selection.c +8 -0
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
 		},
 		.tplg_filename = "max98373-tplg.bin",
 	},
+	{
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
 	{
 		.id = "DLGS7219",
 		.drv_name = "avs_da7219",
---
 sound/soc/intel/avs/board_selection.c | 8 ++++++++
 1 file changed, 8 insertions(+)
sound/soc/intel/avs/board_selection.c +8 -0
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
 		},
 		.tplg_filename = "max98373-tplg.bin",
 	},
+	{
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
 	{
 		.id = "DLGS7219",
 		.drv_name = "avs_da7219",
Signature · 1 line
2.38.1
#1 lore raw
Quoted 4 lines · Alicja Michalska

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

Nami isn't a production device, it was a design, I think you mean "Nautilus"

sound/soc/intel/avs/board_selection.c static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { · line 139

Quoted 9 lines
        },
sound/soc/intel/avs/board_selection.c +8 -0
+       {
+               .id = "MX98357A",
+               .drv_name = "avs_max98357a",
+               .mach_params = {
+                       .i2s_link_mask = AVS_SSP(0),
+               },
+               .tplg_filename = "max98357a-tplg.bin",
+       },

Cezary/Lukasz did we check nautilus? From what I can see in coreboot it should need this.

maintainer
#2 lore raw
Quoted 18 lines · Curtis Malainey
Quoted 4 lines · Alicja Michalska

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

Nami isn't a production device, it was a design, I think you mean "Nautilus"

sound/soc/intel/avs/board_selection.c static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { · line 139

Quoted 9 lines
         },
sound/soc/intel/avs/board_selection.c +8 -0
+       {
+               .id = "MX98357A",
+               .drv_name = "avs_max98357a",
+               .mach_params = {
+                       .i2s_link_mask = AVS_SSP(0),
+               },
+               .tplg_filename = "max98357a-tplg.bin",
+       },
Quoted 2 lines

Cezary/Lukasz did we check nautilus? From what I can see in coreboot it should need this.

A bit surprised this entry was not there to begin with.

We have checked several dozen of configurations but I admit, don't remember if this concrete one was. Max98357a was first launched with APL with the avs-driver, then we moved on to Chell and Lars. As I'm not aware of any differences, this should work out of the box with the entry appended.

Regards,
Czarek

maintainer
#3 lore raw
In reply to Alicja Michalska
Quoted 39 lines · Alicja Michalska

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

sound/soc/intel/avs/board_selection.c +8 -1
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
  		},
  		.tplg_filename = "max98373-tplg.bin",
  	},
+	{
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
  	{
  		.id = "DLGS7219",
  		.drv_name = "avs_da7219",
---
  sound/soc/intel/avs/board_selection.c | 8 ++++++++
  1 file changed, 8 insertions(+)
sound/soc/intel/avs/board_selection.c +1 -0
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
  		},
  		.tplg_filename = "max98373-tplg.bin",
  	},
+	{

sound/soc/intel/avs/board_selection.c static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { · line 142

Quoted 10 lines
sound/soc/intel/avs/board_selection.c +7 -0
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
  	{
  		.id = "DLGS7219",
  		.drv_name = "avs_da7219",

Any reason why diff is repeated twice? It seems that the first copy of diff is part of the commit message.

#4 lore raw

Hello Czarek, trying to re-send that mail from my workstation since email client on my phone didn't cc properly.

No, I've got no idea why it's been duplicated. It's my first time contributing to mainline, so sorry about that. Will double-check my patches in the future.

Quoted 53 lines · Cezary Rojewski
Quoted 39 lines · Alicja Michalska

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

sound/soc/intel/avs/board_selection.c +8 -1
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
            },
            .tplg_filename = "max98373-tplg.bin",
        },
+    {
+        .id = "MX98357A",
+        .drv_name = "avs_max98357a",
+        .mach_params = {
+            .i2s_link_mask = AVS_SSP(0),
+        },
+        .tplg_filename = "max98357a-tplg.bin",
+    },
        {
            .id = "DLGS7219",
            .drv_name = "avs_da7219",
---

   sound/soc/intel/avs/board_selection.c | 8 ++++++++

   1 file changed, 8 insertions(+)
sound/soc/intel/avs/board_selection.c +1 -0
index 87f9c18be238..650faebb33ef 100644
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
            },
            .tplg_filename = "max98373-tplg.bin",
        },
+    {

sound/soc/intel/avs/board_selection.c static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { · line 142

Quoted 10 lines
sound/soc/intel/avs/board_selection.c +7 -0
+        .id = "MX98357A",
+        .drv_name = "avs_max98357a",
+        .mach_params = {
+            .i2s_link_mask = AVS_SSP(0),
+        },
+        .tplg_filename = "max98357a-tplg.bin",
+    },
        {
            .id = "DLGS7219",
            .drv_name = "avs_da7219",

Any reason why diff is repeated twice? It seems that the first copy of diff is part of the commit message.

maintainer
#5 lore raw
In reply to Alicja Michalska
Quoted 8 lines · Alicja Michalska

KBL platform is missing the definition of 'max98357a' audio amplifier. This amplifier is used on many KBL Chromebooks, for instance variant 'nami' of 'Google/poppy' baseboard.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: avs: Add missing audio amplifier for KBL

      commit: 0848e94c3954051e1a52bb088240ed63758b309b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark