libpng: Enable NEON for aarch64 to enensure consistency with arm32.
PATCH v2 1/1 libpng: Enable NEON for aarch64 to enensure consistency with arm32.
NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added enable_hardware_optimizations option for aarch64.
--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +3 -1
@@ -22,7 +22,9 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON:aarch64 = "--enable-hardware-optimizations=on" +EXTRA_OECONF += "${ARMNEON}" PACKAGES =+ "${PN}-tools"
Signature · 1 line
1.8.3.1
v1 has already been applied and you didn't specify what changed since then. Can you rebase?
Quoted 37 lines · leimaohui
NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added
enable_hardware_optimizationsoption for aarch64.Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.39.bb +3
-1@@ -22,7 +22,9 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON:aarch64 = "--enable-hardware-optimizations=on" +EXTRA_OECONF += "${ARMNEON}" PACKAGES =+ "${PN}-tools"Signature · 11 lines
1.8.3.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#175704): https://lists.openembedded.org/g/openembedded-core/message/175704 Mute This Topic: https://lists.openembedded.org/mt/96170221/3617179 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 2 lines · Alexandre Belloni
v1 has already been applied and you didn't specify what changed since then. Can you rebase?
I'm mistaken, I'll handle this patch.
Quoted 45 lines · leimaohui
Quoted 37 lines
NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added
enable_hardware_optimizationsoption for aarch64.Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.39.bb +3
-1@@ -22,7 +22,9 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +ARMNEON:aarch64 = "--enable-hardware-optimizations=on" +EXTRA_OECONF += "${ARMNEON}" PACKAGES =+ "${PN}-tools"Signature · 11 lines
1.8.3.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#175704): https://lists.openembedded.org/g/openembedded-core/message/175704 Mute This Topic: https://lists.openembedded.org/mt/96170221/3617179 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Lei,
Quoted 5 lines · leimaohui
NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added
enable_hardware_optimizationsoption for aarch64.Signed-off-by Lei Maohui <[email protected]>
Many thanks for your contributions to the project!
However, for future commits, we'd need you to do add one thing to your git configuration, so that your patches are given an "Author" field which matches your "Signed-off-by" information. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity for details.
Don't hesitate to send a patch test directly to me, if you wish. Thanks in advance
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com