Skip to contentSkip to conversation

Make it possible to reserve memory on 64bit platform

PATCH In review Wesley Zhao 2 participants 6 messages Jan 22, 2021 Library code

lore
Share & tools
lore
#0 lore raw

v3 cover Make it possible to reserve memory on 64bit platform

I was trying to reserve some memory to save logs incase that Android panic or hang and then I can read the logs from QNX side from the memory reserved before on the Qualcomm 8155 hypervisor platform, and I find the "reserve=" parameter only support 32bit,so I made some change and send these patches.

I run the cmdline_kunit.c and got these:

[    1.663048] 1..1
[    1.663107]     # Subtest: cmdline
[    1.663145]     1..3
[    1.663795]     ok 1 - cmdline_test_noint
[    1.664139]     ok 2 - cmdline_test_lead_int
[    1.664553]     ok 3 - cmdline_test_tail_int
[    1.664788] ok 1 - cmdline

Additionaly:

	I test on the qemu with some cmdline like[qemu-system-x86_64 -kernel linux-next/arch/x86_64/boot/bzImage
	-hda ubuntu-system.ext4 -append "root=/dev/sda init=/bin/bash console=ttyS0 reserve=0x180000000,0x123456"
	-nographic] and check the /proc/iomem with 180000000-180123455 : reserved.
	And some other tests with the get_option with the parameter(-12345678) and so on

Wesley Zhao (2):
lib/cmdline: add new function get_option_ull()
resource: Make it possible to reserve memory on 64bit platform

 include/linux/kernel.h |  2 ++
 kernel/resource.c      |  6 ++--
 lib/cmdline.c          | 94 ++++++++++++++++++++++++++++++++++++++++++--------
 3 files changed, 85 insertions(+), 17 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/2 lib/cmdline: add new function get_option_ull()

In the future we would pass the unsigned long long parameter like(0x123456781234) in cmdline on the 64bit platform, so add a new option parse function get_option_ull()

---
 include/linux/kernel.h |  2 ++
 lib/cmdline.c          | 94 ++++++++++++++++++++++++++++++++++++++++++--------
 2 files changed, 82 insertions(+), 14 deletions(-)
include/linux/kernel.h +2 -0
index f7902d8c1048..eb1f0b14a0c5 100644
@@ -348,6 +348,8 @@ extern __scanf(2, 0)
 int vsscanf(const char *, const char *, va_list);
 
 extern int get_option(char **str, int *pint);
+extern int get_option_ll(char **str, long long *pll);
+extern int get_option_ull(char **str, unsigned long long *pull);
 extern char *get_options(const char *str, int nints, int *ints);
 extern unsigned long long memparse(const char *ptr, char **retptr);
 extern bool parse_option_str(const char *str, const char *option);
lib/cmdline.c +80 -14

112 lines not on this page · raw message

Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH v3 1/2] lib/cmdline: add new function get_option_ull()

Quoted 3 lines · Wesley Zhao

In the future we would pass the unsigned long long parameter like(0x123456781234) in cmdline on the 64bit platform, so add a new option parse function get_option_ull()

You missed period at the end of phrase.

Overall this patch is not needed at all.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
In reply to Wesley Zhao
Quoted 3 lines · Wesley Zhao

I was trying to reserve some memory to save logs incase that Android panic or hang and then I can read the logs from QNX side from the memory reserved before on the Qualcomm 8155 hypervisor platform, and I find the "reserve=" parameter only support 32bit,so I made some change and send these patches.

This part is okay.

Quoted 8 lines

I run the cmdline_kunit.c and got these:

[    1.663048] 1..1
[    1.663107]     # Subtest: cmdline
[    1.663145]     1..3
[    1.663795]     ok 1 - cmdline_test_noint
[    1.664139]     ok 2 - cmdline_test_lead_int
[    1.664553]     ok 3 - cmdline_test_tail_int
[    1.664788] ok 1 - cmdline

This is not okay, you have to have test cases to be added for your new API. Besides the fact that you don't need it at all. See my further comments.

Quoted 5 lines

Additionaly:

	I test on the qemu with some cmdline like[qemu-system-x86_64 -kernel linux-next/arch/x86_64/boot/bzImage
	-hda ubuntu-system.ext4 -append "root=/dev/sda init=/bin/bash console=ttyS0 reserve=0x180000000,0x123456"
	-nographic] and check the /proc/iomem with 180000000-180123455 : reserved.
	And some other tests with the get_option with the parameter(-12345678) and so on
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

PATCH v3 2/2 resource: Make it possible to reserve memory on 64bit platform

In reply to Wesley Zhao

For now "reserve=" is limitied to 32bit,not available on 64bit platform,so we change the get_option() to get_option_ull(added in
patch: commit 4b6bfe96265e ("lib/cmdline: add new function get_option_ull()"))

---
 kernel/resource.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/resource.c +3 -3
index 833394f9c608..ee2a0e5d196f 100644
@@ -1567,13 +1567,13 @@ static int __init reserve_setup(char *str)
 	static struct resource reserve[MAXRESERVE];
 
 	for (;;) {
-		unsigned int io_start, io_num;
+		unsigned long long io_start, io_num;
 		int x = reserved;
 		struct resource *parent;
 
-		if (get_option(&str, &io_start) != 2)
+		if (get_option_ull(&str, &io_start) != 2)
 			break;
-		if (get_option(&str, &io_num) == 0)
+		if (get_option_ull(&str, &io_num) == 0)
 			break;
 		if (x < MAXRESERVE) {
 			struct resource *res = reserve + x;
Signature · 1 line
2.7.4
#5 lore raw

Re: [PATCH v3 2/2] resource: Make it possible to reserve memory on 64bit platform

Quoted 4 lines · Wesley Zhao

For now "reserve=" is limitied to 32bit,not available on 64bit platform,so we change the get_option() to get_option_ull(added in
patch: commit 4b6bfe96265e ("lib/cmdline: add new function get_option_ull()"))

Do better grammar and punctuation.

"For now "reserve=" is limited to 32bit, and not available on 64bit platform, so we change the get_option() to get_option_ull() which is added in the previous patch."

But!

You don't need to alter cmdline.c at all, see memparse() for the details! And you have been told already, look at other options. You failed to mentioned in the cover letter what's wrong with recommended memmap= approach.

Signature · 2 lines
With Best Regards,
Andy Shevchenko