staging: media: zoran: reduce length of a line
Subsystems (2)
PATCH 1/1 staging: media: zoran: reduce length of a line
Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' Reported by checkpatch.
--- drivers/staging/media/zoran/zr36060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/media/zoran/zr36060.c +3 -1
@@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's ACstatic const char zr36060_decimation_h[8 ] = {2 ,1 ,1 ,0 ,0 ,0 ,0 ,0 };static const char zr36060_decimation_v[8 ] = {1 ,1 ,1 ,0 ,0 ,0 ,0 ,0 }; -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */ +/* SOF (start of frame) segment depends on width, +* height and sampling ratio of each color component +*/ static int zr36060_set_sof (struct zr36060 *ptr) {char sof_data[34 ];// max. size of register set
Signature · 1 line
2.30.2
Hi Mitali,
Something to improve:
Quoted 14 lines · Mitali Borkar
Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' Reported by checkpatch.
Signed-off-by Mitali Borkar <[email protected]>--- drivers/staging/media/zoran/zr36060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/staging/media/zoran/zr36060.c +0
-0
drivers/staging/media/zoran/zr36060.c static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC · line 254
Quoted 7 lines
drivers/staging/media/zoran/zr36060.c +3
-1@@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's ACstatic const char zr36060_decimation_h[8 ] = {2 ,1 ,1 ,0 ,0 ,0 ,0 ,0 };static const char zr36060_decimation_v[8 ] = {1 ,1 ,1 ,0 ,0 ,0 ,0 ,0 }; -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */ +/* SOF (start of frame) segment depends on width, +* height and sampling ratio of each color component +*/
See the coding style guidelines: the preferred style for long comments is:
/*
* text
* text
*/
Regards,
Hans
Quoted 4 lines
drivers/staging/media/zoran/zr36060.c +0
-0static int zr36060_set_sof (struct zr36060 *ptr) {char sof_data[34 ];// max. size of register set
Quoted 29 lines · Hans Verkuil
Hi Mitali,
Something to improve:
Quoted 14 lines · Mitali Borkar
Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' Reported by checkpatch.
Signed-off-by Mitali Borkar <[email protected]>--- drivers/staging/media/zoran/zr36060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/staging/media/zoran/zr36060.c +0
-0drivers/staging/media/zoran/zr36060.c static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC · line 254
Quoted 7 lines
drivers/staging/media/zoran/zr36060.c +3
-1@@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's ACstatic const char zr36060_decimation_h[8 ] = {2 ,1 ,1 ,0 ,0 ,0 ,0 ,0 };static const char zr36060_decimation_v[8 ] = {1 ,1 ,1 ,0 ,0 ,0 ,0 ,0 }; -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */ +/* SOF (start of frame) segment depends on width, +* height and sampling ratio of each color component +*/ See the coding style guidelines: the preferred style for long comments is:
Quoted 5 lines
/*
* text
* text
*/
I have sent v2 patch two days ago and I have not got reply till now, Should I resend this?
Quoted 9 lines
Regards,
Hans
Quoted 4 lines
drivers/staging/media/zoran/zr36060.c +0
-0static int zr36060_set_sof (struct zr36060 *ptr) {char sof_data[34 ];// max. size of register set