staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <[email protected]>,
PATCH v2 1/1 staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warningJoe Perches <[email protected]>,
Abheek Dhawan <[email protected]>,
Johannes Weiner <[email protected]>,
Romain Perier <[email protected]>,
Waiman Long <[email protected]>,
Allen Pais <[email protected]>,
Ivan Safonov <[email protected]>, [email protected],
[email protected]
Upon running sparse, "warning: incorrect type in argument 1 (different address spaces) is brought to notice for this file.let's correct data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of the patch, version 1 can be found at
https://lkml.org/lkml/2021/4/20/203
--- drivers/staging/wlan-ng/p80211ioctl.h | 2 +- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/p80211ioctl.h +1 -1
@@ -81,7 +81,7 @@struct p80211ioctl_req {char name[WLAN_DEVNAMELEN_MAX ]; -caddr_t data; +char __user *data;u32 magic;u16 len;u32 result;
drivers/staging/wlan-ng/p80211netdev.c +2 -2
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, goto bail; } - msgbuf =memdup_user ((void __user *)req->data, req->len); + msgbuf =memdup_user (req->data, req->len);if (IS_ERR (msgbuf)) { result =PTR_ERR (msgbuf); goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,if (result ==0 ) {if (copy_to_user - ((void __user *)req->data, msgbuf, req->len)) { + (req->data, msgbuf, req->len)) { result = -EFAULT ; } }
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 8 lines · Ashish Kalra
Abheek Dhawan <[email protected]>,
Johannes Weiner <[email protected]>,
Romain Perier <[email protected]>,
Waiman Long <[email protected]>,
Allen Pais <[email protected]>,
Ivan Safonov <[email protected]>,
[email protected],
[email protected]
Why is this here in the email body?
Quoted 5 lines
Upon running sparse, "warning: incorrect type in argument 1 (different address spaces) is brought to notice for this file.let's correct data type for variable data adding
__userto make it cleaner and silence the Sparse warning. This is version 2 of the patch, version 1 can be found at
https://lkml.org/lkml/2021/4/20/203
Always use lore.kernel.org links, not a random other site that we have no idea who runs it.
And no need to say this in that form, please list below the --- line what changed from v1.
thanks,
greg k-h