Input: pm8941-pwrkey - fix comma vs semicolon issue
Subsystems (3)
Dmitry Torokhov
maintainerPATCH 1/1 Input: pm8941-pwrkey - fix comma vs semicolon issue
There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.
--- drivers/input/misc/pm8941-pwrkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/pm8941-pwrkey.c +1 -1
@@ -284,7 +284,7 @@ static int pm8941_pwrkey_probe(struct platform_device *pdev) }if (pwrkey->data->supports_ps_hold_poff_config) { - pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify, + pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify; error =register_reboot_notifier (&pwrkey->reboot_notifier);if (error) { dev_err(&pdev->dev, "failed to register reboot notifier: %d\n",
Signature · 5 lines
2.32.0.432.gabb21c7263-goog -- Dmitry
Quoting Dmitry Torokhov (2021-07-23 12:39:02)
Quoted 5 lines
There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.
Signed-off-by Dmitry Torokhov <[email protected]>---
PON_HLOS PMIC peripheral")
Dmitry Torokhov
maintainerQuoted 9 lines · Stephen Boyd
Quoting Dmitry Torokhov (2021-07-23 12:39:02)
Quoted 5 lines
There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.
Signed-off-by Dmitry Torokhov <[email protected]>---
Fixes 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
PON_HLOSPMIC peripheral")
It actually predates this patch and also not really a fix as the original code ends up working properly, but looks weird.
Quoted 1 line
Reviewed-by Stephen Boyd <[email protected]>
Thanks!
Signature · 1 line
Dmitry
Quoting Dmitry Torokhov (2021-07-23 12:52:15)
Quoted 5 lines · Stephen Boyd
Quoted 4 lines
Quoting Dmitry Torokhov (2021-07-23 12:39:02)
Quoted 3 lines
There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Dmitry Torokhov <[email protected]>---
Fixes 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
PON_HLOSPMIC peripheral")It actually predates this patch and also not really a fix as the original code ends up working properly, but looks weird.
Alright.