Skip to contentSkip to conversation

Input: pm8941-pwrkey - fix comma vs semicolon issue

PATCH In review Dmitry Torokhov 2 participants 4 messages Jul 23, 2021

Subsystems (3)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: pm8941-pwrkey - fix comma vs semicolon issue

There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.

---
 drivers/input/misc/pm8941-pwrkey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/pm8941-pwrkey.c +1 -1
index 10e3fc0eac6e..33609603245d 100644
@@ -284,7 +284,7 @@ static int pm8941_pwrkey_probe(struct platform_device *pdev)
 	}
 
 	if (pwrkey->data->supports_ps_hold_poff_config) {
-		pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify,
+		pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify;
 		error = register_reboot_notifier(&pwrkey->reboot_notifier);
 		if (error) {
 			dev_err(&pdev->dev, "failed to register reboot notifier: %d\n",
Signature · 5 lines
2.32.0.432.gabb21c7263-goog


-- 
Dmitry
author maintainer
#2 lore raw
Quoted 9 lines · Stephen Boyd

Quoting Dmitry Torokhov (2021-07-23 12:39:02)

Quoted 5 lines

There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.

---

Fixes 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350

PON_HLOS PMIC peripheral")

It actually predates this patch and also not really a fix as the original code ends up working properly, but looks weird.

Quoted 1 line

Thanks!

Signature · 1 line
Dmitry
#3 lore raw

Quoting Dmitry Torokhov (2021-07-23 12:52:15)

Quoted 5 lines · Stephen Boyd
Quoted 4 lines

Quoting Dmitry Torokhov (2021-07-23 12:39:02)

Quoted 3 lines

There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

---

Fixes 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350

PON_HLOS PMIC peripheral")

It actually predates this patch and also not really a fix as the original code ends up working properly, but looks weird.

Alright.