Skip to contentSkip to conversation

drm/panel/tianma-tl057fvxp01: add panel for Motorola Moto G6

PATCH In review Julian Braha 2 participants 3 messages Aug 8, 2021 – Oct 18, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/panel/tianma-tl057fvxp01: add panel for Motorola Moto G6

This is a 5.7" 2160x1080 panel found on the Motorola Moto G6. There may be other smartphones using it, as well.

---
 drivers/gpu/drm/panel/Kconfig                 |   7 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-tianma-tl057fvxp01.c  | 262 ++++++++++++++++++
 3 files changed, 270 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c
drivers/gpu/drm/panel/Kconfig +7 -0
index beb581b96ecd..9e8a5fffa626 100644
@@ -557,6 +557,13 @@ config DRM_PANEL_TDO_TL070WSH30
 	  24 bit RGB per pixel. It provides a MIPI DSI interface to
 	  the host, a built-in LED backlight and touch controller.
 
+config DRM_PANEL_TIANMA_TL057FVXP01
+	tristate "Tianma TL057FVXP01 panel"
+	select DRM_PANEL_MIPI_DSI_COMMON
+	help
+	  Say Y here if you want to enable support for the Tianma TL057FVXP01
+	  2160x1080 5.7" panel (found on the Motorola Moto G6).
+
 config DRM_PANEL_TPO_TD028TTEC1
 	tristate "Toppoly (TPO) TD028TTEC1 panel driver"
 	depends on OF && SPI
drivers/gpu/drm/panel/Makefile +1 -0
index c8132050bcec..9bdc2a12e719 100644
@@ -57,6 +57,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
 obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o
+obj-$(CONFIG_DRM_PANEL_TIANMA_TL057FVXP01) += panel-tianma-tl057fvxp01.o
 obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o
 obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o
 obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o
drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c new file +262 -0

262 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

Hi Julian,

Quoted 4 lines · Julian Braha

This is a 5.7" 2160x1080 panel found on the Motorola Moto G6. There may be other smartphones using it, as well.

Sorry for coming back so late. Driver looks good and is almost ready to apply. One detail you need to fix, see below.

Sam

drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c line 247

Quoted 6 lines

---

drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c new file +5 -0
+
+static const struct of_device_id tianma_tl057fvxp01_of_match[] = {
+	{ .compatible = "tianma,tl057fvxp01" },
+	{ /* sentinel */ }
+};

The compatible needs to be documented before I can include the driver in the kernel. Please add a patch that document the compatible - maybe as a new binding file but preferably as part of one of the existing binding files.

Sam

#2 lore raw
Quoted 24 lines · EDT Sam Ravnborg

Hi Julian,

Quoted 4 lines · Julian Braha

This is a 5.7" 2160x1080 panel found on the Motorola Moto G6. There may be other smartphones using it, as well.

Sorry for coming back so late. Driver looks good and is almost ready to apply. One detail you need to fix, see below.

Sam

drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c line 247

Quoted 6 lines

---

drivers/gpu/drm/panel/panel-tianma-tl057fvxp01.c new file +5 -0
+
+static const struct of_device_id tianma_tl057fvxp01_of_match[] = {
+	{ .compatible = "tianma,tl057fvxp01" },
+	{ /* sentinel */ }
+};

The compatible needs to be documented before I can include the driver in the kernel. Please add a patch that document the compatible - maybe as a new binding file but preferably as part of one of the existing binding files.

Quoted 2 lines

Sam

Hi Sam,

Thanks for your feedback! I've submitted a second patch for the bindings.

- Julian Braha