Skip to contentSkip to conversation

firmware: Update Kconfig help text for Google firmware

PATCH Applied Ben Hutchings 4 participants 4 messages Jun 18, 2018 – Dec 21, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 firmware: Update Kconfig help text for Google firmware

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, many of the drivers dependent on it are also useful on Chromebooks or on any platform using coreboot.

Update the help text to reflect this double duty.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")

---
v2: Mention coreboot, and don't touch GSMI help text

 drivers/firmware/google/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/google/Kconfig +3 -3
index f16b381a569c..ca049ecf5cfd 100644
@@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
 	bool "Google Firmware Drivers"
 	default n
 	help
-	  These firmware drivers are used by Google's servers.  They are
-	  only useful if you are working directly on one of their
-	  proprietary servers.  If in doubt, say "N".
+	  These firmware drivers are used by Google servers,
+	  Chromebooks and other devices using coreboot firmware.
+	  If in doubt, say "N".
 
 if GOOGLE_FIRMWARE
 
Reviewed-by on v2 1/1
#1 lore raw

LGTM

Quoted 33 lines · Ben Hutchings

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, many of the drivers dependent on it are also useful on Chromebooks or on any platform using coreboot.

Update the help text to reflect this double duty.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")

---
v2: Mention coreboot, and don't touch GSMI help text

 drivers/firmware/google/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/google/Kconfig +3 -3
index f16b381a569c..ca049ecf5cfd 100644
@@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
        bool "Google Firmware Drivers"
        default n
        help
-         These firmware drivers are used by Google's servers.  They are
-         only useful if you are working directly on one of their
-         proprietary servers.  If in doubt, say "N".
+         These firmware drivers are used by Google servers,
+         Chromebooks and other devices using coreboot firmware.
+         If in doubt, say "N".
 
 if GOOGLE_FIRMWARE
 
#2 lore raw
In reply to Ben Hutchings

Hi,

Quoted 21 lines · Ben Hutchings

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, many of the drivers dependent on it are also useful on Chromebooks or on any platform using coreboot.

Update the help text to reflect this double duty.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")

---
v2: Mention coreboot, and don't touch GSMI help text

 drivers/firmware/google/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/google/Kconfig +0 -0
index f16b381a569c..ca049ecf5cfd 100644
@@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
 	bool "Google Firmware Drivers"

drivers/firmware/google/Kconfig menuconfig GOOGLE_FIRMWARE · line 9

Quoted 10 lines
drivers/firmware/google/Kconfig +3 -3
 	default n
 	help
-	  These firmware drivers are used by Google's servers.  They are
-	  only useful if you are working directly on one of their
-	  proprietary servers.  If in doubt, say "N".
+	  These firmware drivers are used by Google servers,
+	  Chromebooks and other devices using coreboot firmware.
+	  If in doubt, say "N".
 
 if GOOGLE_FIRMWARE

Prompted by a question downstream in Debian it looks that this patch never go applied.

Is there anything missing for having it applied?

Do you want a fresh resent of it?

Regards,
Salvatore

#3 lore raw
Quoted 33 lines · Salvatore Bonaccorso

Hi,

Quoted 30 lines · Ben Hutchings

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, many of the drivers dependent on it are also useful on Chromebooks or on any platform using coreboot.

Update the help text to reflect this double duty.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")

---
v2: Mention coreboot, and don't touch GSMI help text

 drivers/firmware/google/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/google/Kconfig +3 -3
index f16b381a569c..ca049ecf5cfd 100644
@@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
 	bool "Google Firmware Drivers"
 	default n
 	help
-	  These firmware drivers are used by Google's servers.  They are
-	  only useful if you are working directly on one of their
-	  proprietary servers.  If in doubt, say "N".
+	  These firmware drivers are used by Google servers,
+	  Chromebooks and other devices using coreboot firmware.
+	  If in doubt, say "N".
 
Quoted 8 lines

drivers/firmware/google/Kconfig menuconfig GOOGLE_FIRMWARE · line 9

Quoted 1 line
drivers/firmware/google/Kconfig +0 -0
 if GOOGLE_FIRMWARE

Prompted by a question downstream in Debian it looks that this patch never go applied.

Is there anything missing for having it applied?

Do you want a fresh resent of it?

I've picked it up now, thanks.

greg k-h