Skip to contentSkip to conversation

crypto: cleanup warning in qm_get_qos_value()

PATCH Superseded [email protected] 3 participants 4 messages Dec 21, 2021 – Dec 22, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: cleanup warning in qm_get_qos_value()

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value

        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

---
 drivers/crypto/hisilicon/qm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/qm.c +1 -1
index b1fe9c7b8cc89..c906f2e59277b 100644
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
 		return -EINVAL;
 
 	ret = qm_qos_value_init(val_buf, val);
-	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
 		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
 		return -EINVAL;
 	}
Signature · 1 line
2.26.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, Dec 21, 2021 at 12:59:53PM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

Quoted 8 lines

qm.c:4382:11: warning: The left operand of '==' is a garbage value

        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

Should this have a fixes tag?

Fixes 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
Quoted 20 lines
---
 drivers/crypto/hisilicon/qm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/qm.c +1 -1
index b1fe9c7b8cc89..c906f2e59277b 100644
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
 		return -EINVAL;
 
 	ret = qm_qos_value_init(val_buf, val);
-	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
 		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
 		return -EINVAL;
 	}
Signature · 1 line
2.26.3
author
#2 lore raw
Quoted 9 lines · Nathan Chancellor
Quoted 8 lines · On Tue, Dec 21, 2021 at 12:59:53PM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value

         if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
             ~~~~ ^
Quoted 7 lines
Quoted 4 lines

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

Should this have a fixes tag?

I was debating that, the existing if-check will catch this, just not as efficiently.

I'll add the line.

Tom

Quoted 23 lines
Fixes 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
Quoted 20 lines
---
  drivers/crypto/hisilicon/qm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/qm.c +1 -1
index b1fe9c7b8cc89..c906f2e59277b 100644
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
  		return -EINVAL;
 
  	ret = qm_qos_value_init(val_buf, val);
-	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
  		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
  		return -EINVAL;
  	}
Signature · 1 line
2.26.3
maintainer
#3 lore raw
In reply to [email protected]
Quoted 22 lines · 在 2021/12/22 4:59, [email protected] 写道:

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value

        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

---
 drivers/crypto/hisilicon/qm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/qm.c +0 -0
index b1fe9c7b8cc89..c906f2e59277b 100644

drivers/crypto/hisilicon/qm.c static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf, · line 4385

Quoted 8 lines
drivers/crypto/hisilicon/qm.c +1 -1
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
 		return -EINVAL;
 
 	ret = qm_qos_value_init(val_buf, val);
-	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
 		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
 		return -EINVAL;
 	}

Should check return firstly, thanks.

Zhou