Skip to contentSkip to conversation

dt-bindings: ata: convert ata/cortina,gemini-sata-bridge to yaml

PATCH Superseded Corentin Labbe 4 participants 10 messages Jan 29, 2022 – Feb 2, 2022

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: ata: convert ata/cortina,gemini-sata-bridge to yaml

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

---
 .../ata/cortina,gemini-sata-bridge.txt        |  55 ----------
 .../ata/cortina,gemini-sata-bridge.yaml       | 100 ++++++++++++++++++
 2 files changed, 100 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
 create mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt deleted +0 -55
deleted file mode 100644
index 1c3d3cc70051..000000000000
@@ -1,55 +0,0 @@
-* Cortina Systems Gemini SATA Bridge
-
-The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
-takes two Faraday Technology FTIDE010 PATA controllers and bridges
-them in different configurations to two SATA ports.
-
-Required properties:
-- compatible: should be
-  "cortina,gemini-sata-bridge"
-- reg: registers and size for the block
-- resets: phandles to the reset lines for both SATA bridges
-- reset-names: must be "sata0", "sata1"
-- clocks: phandles to the compulsory peripheral clocks
-- clock-names: must be "SATA0_PCLK", "SATA1_PCLK"
-- syscon: a phandle to the global Gemini system controller
-- cortina,gemini-ata-muxmode: tell the desired multiplexing mode for
-  the ATA controller and SATA bridges. Values 0..3:
-  Mode 0: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata0 slave interface brought out on IDE pads
-  Mode 1: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata1 slave interface brought out on IDE pads
-  Mode 2: ata1 master <-> sata1
-          ata1 slave  <-> sata0
-          ata0 master and slave interfaces brought out
-               on IDE pads
-  Mode 3: ata0 master <-> sata0
-          ata0 slave  <-> sata1
-          ata1 master and slave interfaces brought out
-               on IDE pads
-
-Optional boolean properties:
-- cortina,gemini-enable-ide-pins: enables the PATA to IDE connection.
-  The muxmode setting decides whether ATA0 or ATA1 is brought out,
-  and whether master, slave or both interfaces get brought out.
-- cortina,gemini-enable-sata-bridge: enables the PATA to SATA bridge
-  inside the Gemnini SoC. The Muxmode decides what PATA blocks will
-  be muxed out and how.
-
-Example:
-
-sata: sata@46000000 {
-	compatible = "cortina,gemini-sata-bridge";
-	reg = <0x46000000 0x100>;
-	resets = <&rcon 26>, <&rcon 27>;
-	reset-names = "sata0", "sata1";
-	clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
-		 <&gcc GEMINI_CLK_GATE_SATA1>;
-	clock-names = "SATA0_PCLK", "SATA1_PCLK";
-	syscon = <&syscon>;
-	cortina,gemini-ata-muxmode = <3>;
-	cortina,gemini-enable-ide-pins;
-	cortina,gemini-enable-sata-bridge;
-};
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +100 -0

100 lines not on this page · raw message

Signature · 1 line
2.34.1
#2 lore raw
Quoted 4 lines · Linus Walleij

Thanks for doing this Corentin!

On Sat, Jan 29, 2022 at 9:40 PM Corentin Labbe <[email protected]> wrote:

Quoted 8 lines
Quoted 3 lines

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

What do you mean ? I am doing my best here to maintain ata ! But I definitely do not have all the hardware supported for testing :)

That said, I am perfectly fine with Rob taking device tree patches if that is not a problem for him.

Quoted 3 lines

Yours,
Linus Walleij

Signature · 2 lines
Damien Le Moal
Western Digital Research
#3 lore raw
Quoted 7 lines · Damien Le Moal
Quoted 6 lines · Linus Walleij

Thanks for doing this Corentin!

Quoted 2 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

What do you mean ? I am doing my best here to maintain ata !

I am referring to the situation before
commit 5ac749a57e0ebb334b1b2c3d28d4d5b1ef85f8ed
I am happy that this is now solved!

Sorry for not being up-to-date.

Yours,
Linus Walleij

#4 lore raw
In reply to Damien Le Moal
Quoted 8 lines · Damien Le Moal
Quoted 8 lines

Thanks for doing this Corentin!

Quoted 3 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Quoted 7 lines
Quoted 4 lines

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

What do you mean ? I am doing my best here to maintain ata ! But I definitely do not have all the hardware supported for testing :)

I can probably help reviewing the PATA drivers if you want, just like Bart Z. did.
But I don't have much of the PATA hardware (what I have is in my old PCs I haven't booted in a long while)...

[...]

MBR, Sergey

#5 lore raw
Quoted 15 lines · Sergei Shtylyov
Quoted 13 lines · Damien Le Moal
Quoted 12 lines

Thanks for doing this Corentin!

Quoted 3 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

Quoted 6 lines
Quoted 2 lines

What do you mean ? I am doing my best here to maintain ata ! But I definitely do not have all the hardware supported for testing :)

I can probably help reviewing the PATA drivers if you want, just like Bart Z. did.
But I don't have much of the PATA hardware (what I have is in my old PCs I haven't booted in a long while)...

More reviews are always welcome ! Thanks !

Quoted 4 lines

[...]

MBR, Sergey

Signature · 2 lines
Damien Le Moal
Western Digital Research
#6 lore raw
Quoted 13 lines · Damien Le Moal
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines

Thanks for doing this Corentin!

Quoted 3 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

What do you mean ? I am doing my best here to maintain ata ! But I definitely do not have all the hardware supported for testing :)

I can probably help reviewing the PATA drivers if you want, just like Bart Z. did.
But I don't have much of the PATA hardware (what I have is in my old PCs I haven't booted in a long while)...

More reviews are always welcome ! Thanks !

How about me submitting an "official" PATA reviewer entry in MAINTAINERS?

[...]

MBR, Sergey

#7 lore raw
Quoted 18 lines · Sergei Shtylyov
Quoted 16 lines · Damien Le Moal
Quoted 16 lines
Quoted 15 lines
Quoted 4 lines

Thanks for doing this Corentin!

On Sat, Jan 29, 2022 at 9:40 PM Corentin Labbe <[email protected]> wrote:

Quoted 8 lines
Quoted 3 lines

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

Knowing that drivers/ata is a bit sparsely maintained I suggest that Rob apply this patch when he feels it looks good.

What do you mean ? I am doing my best here to maintain ata ! But I definitely do not have all the hardware supported for testing :)

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I can probably help reviewing the PATA drivers if you want, just like Bart Z. did.
But I don't have much of the PATA hardware (what I have is in my old PCs I haven't booted in a long while)...

More reviews are always welcome ! Thanks !

How about me submitting an "official" PATA reviewer entry in MAINTAINERS?

Sure. That works for me.

Quoted 4 lines

[...]

MBR, Sergey

Signature · 2 lines
Damien Le Moal
Western Digital Research
Acked-by on v1 1/1
#8 lore raw
In reply to Corentin Labbe
Quoted 106 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

---
 .../ata/cortina,gemini-sata-bridge.txt        |  55 ----------
 .../ata/cortina,gemini-sata-bridge.yaml       | 100 ++++++++++++++++++
 2 files changed, 100 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
 create mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt deleted +0 -55
deleted file mode 100644
index 1c3d3cc70051..000000000000
@@ -1,55 +0,0 @@
-* Cortina Systems Gemini SATA Bridge
-
-The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
-takes two Faraday Technology FTIDE010 PATA controllers and bridges
-them in different configurations to two SATA ports.
-
-Required properties:
-- compatible: should be
-  "cortina,gemini-sata-bridge"
-- reg: registers and size for the block
-- resets: phandles to the reset lines for both SATA bridges
-- reset-names: must be "sata0", "sata1"
-- clocks: phandles to the compulsory peripheral clocks
-- clock-names: must be "SATA0_PCLK", "SATA1_PCLK"
-- syscon: a phandle to the global Gemini system controller
-- cortina,gemini-ata-muxmode: tell the desired multiplexing mode for
-  the ATA controller and SATA bridges. Values 0..3:
-  Mode 0: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata0 slave interface brought out on IDE pads
-  Mode 1: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata1 slave interface brought out on IDE pads
-  Mode 2: ata1 master <-> sata1
-          ata1 slave  <-> sata0
-          ata0 master and slave interfaces brought out
-               on IDE pads
-  Mode 3: ata0 master <-> sata0
-          ata0 slave  <-> sata1
-          ata1 master and slave interfaces brought out
-               on IDE pads
-
-Optional boolean properties:
-- cortina,gemini-enable-ide-pins: enables the PATA to IDE connection.
-  The muxmode setting decides whether ATA0 or ATA1 is brought out,
-  and whether master, slave or both interfaces get brought out.
-- cortina,gemini-enable-sata-bridge: enables the PATA to SATA bridge
-  inside the Gemnini SoC. The Muxmode decides what PATA blocks will
-  be muxed out and how.
-
-Example:
-
-sata: sata@46000000 {
-	compatible = "cortina,gemini-sata-bridge";
-	reg = <0x46000000 0x100>;
-	resets = <&rcon 26>, <&rcon 27>;
-	reset-names = "sata0", "sata1";
-	clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
-		 <&gcc GEMINI_CLK_GATE_SATA1>;
-	clock-names = "SATA0_PCLK", "SATA1_PCLK";
-	syscon = <&syscon>;
-	cortina,gemini-ata-muxmode = <3>;
-	cortina,gemini-enable-ide-pins;
-	cortina,gemini-enable-sata-bridge;
-};
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +29 -0
new file mode 100644
index 000000000000..ff27e4884e21
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/cortina,gemini-sata-bridge.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cortina Systems Gemini SATA Bridge
+
+maintainers:
+  - Linus Walleij <[email protected]>
+
+description: |
+    The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
+    takes two Faraday Technology FTIDE010 PATA controllers and bridges
+    them in different configurations to two SATA ports.
+
+properties:
+  compatible:
+    const: "cortina,gemini-sata-bridge"
+  reg:
+    minItems: 1
+  resets:
+    minItems: 2
+    description: phandles to the reset lines for both SATA bridges
+  reset-names:
+    items:
+      - const: "sata0"
+      - const: "sata1"
+  clocks:

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 39

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+    minItems: 2
+    description: phandles to the compulsory peripheral clocks
+  clock-names:
+    items:
+      - const: "SATA0_PCLK"
+      - const: "SATA1_PCLK"
+  syscon:
+    minItems: 1
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: a phandle to the global Gemini system controller

s/a phandle/phandle ?

Saying "a phandle" seems to imply that there may be many. I am not sure here though.

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 48

Quoted 9 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +9 -0
+  cortina,gemini-ata-muxmode:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum:
+      - 0
+      - 1
+      - 2
+      - 3
+    description: |
+      tell the desired multiplexing mode for the ATA controller and SATA bridges. Values 0..3:

Nit: Start the sentence with an uppercase "Tell...".

Quoted 6 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +6 -0
+      Mode 0: ata0 master <-> sata0
+              ata1 master <-> sata1
+              ata0 slave interface brought out on IDE pads
+      Mode 1: ata0 master <-> sata0
+              ata1 master <-> sata1
+              ata1 slave interface brought out on IDE pads

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 64

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+      Mode 2: ata1 master <-> sata1
+              ata1 slave  <-> sata0
+              ata0 master and slave interfaces brought out on IDE pads
+      Mode 3: ata0 master <-> sata0
+              ata0 slave  <-> sata1
+              ata1 master and slave interfaces brought out on IDE pads
+
+  cortina,gemini-enable-ide-pins:
+    type: boolean
+    description: enables the PATA to IDE connection.

Same here.

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 69

Quoted 5 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +5 -0
+                 The muxmode setting decides whether ATA0 or ATA1 is brought out,
+                 and whether master, slave or both interfaces get brought out.
+  cortina,gemini-enable-sata-bridge:
+    type: boolean
+    description: enables the PATA to SATA bridge

Ditto. And the line break is a little early. The first line could be longer so that everything fits in 2 lines.

Quoted 21 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +21 -0
+                 inside the Gemnini SoC. The Muxmode decides what PATA blocks will
+                 be muxed out and how.
+
+required:
+  - clocks
+  - clock-names
+  - cortina,gemini-ata-muxmode
+  - resets
+  - reset-names
+  - compatible
+  - reg
+  - syscon
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/cortina,gemini-clock.h>
+    sata: sata@46000000 {
+      compatible = "cortina,gemini-sata-bridge";
+      reg = <0x46000000 0x100>;

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 100

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+      resets = <&rcon 26>, <&rcon 27>;
+      reset-names = "sata0", "sata1";
+      clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
+               <&gcc GEMINI_CLK_GATE_SATA1>;
+      clock-names = "SATA0_PCLK", "SATA1_PCLK";
+      syscon = <&syscon>;
+      cortina,gemini-ata-muxmode = <3>;
+      cortina,gemini-enable-ide-pins;
+      cortina,gemini-enable-sata-bridge;
+    };

With the above cosmetic nits addressed (if necessary):

Signature · 2 lines
Damien Le Moal
Western Digital Research
#9 lore raw
Quoted 196 lines · Damien Le Moal
Quoted 106 lines · Corentin Labbe

This patch converts ata/cortina,gemini-sata-bridge binding to yaml

---
 .../ata/cortina,gemini-sata-bridge.txt        |  55 ----------
 .../ata/cortina,gemini-sata-bridge.yaml       | 100 ++++++++++++++++++
 2 files changed, 100 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
 create mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt deleted +0 -55
deleted file mode 100644
index 1c3d3cc70051..000000000000
@@ -1,55 +0,0 @@
-* Cortina Systems Gemini SATA Bridge
-
-The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
-takes two Faraday Technology FTIDE010 PATA controllers and bridges
-them in different configurations to two SATA ports.
-
-Required properties:
-- compatible: should be
-  "cortina,gemini-sata-bridge"
-- reg: registers and size for the block
-- resets: phandles to the reset lines for both SATA bridges
-- reset-names: must be "sata0", "sata1"
-- clocks: phandles to the compulsory peripheral clocks
-- clock-names: must be "SATA0_PCLK", "SATA1_PCLK"
-- syscon: a phandle to the global Gemini system controller
-- cortina,gemini-ata-muxmode: tell the desired multiplexing mode for
-  the ATA controller and SATA bridges. Values 0..3:
-  Mode 0: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata0 slave interface brought out on IDE pads
-  Mode 1: ata0 master <-> sata0
-          ata1 master <-> sata1
-          ata1 slave interface brought out on IDE pads
-  Mode 2: ata1 master <-> sata1
-          ata1 slave  <-> sata0
-          ata0 master and slave interfaces brought out
-               on IDE pads
-  Mode 3: ata0 master <-> sata0
-          ata0 slave  <-> sata1
-          ata1 master and slave interfaces brought out
-               on IDE pads
-
-Optional boolean properties:
-- cortina,gemini-enable-ide-pins: enables the PATA to IDE connection.
-  The muxmode setting decides whether ATA0 or ATA1 is brought out,
-  and whether master, slave or both interfaces get brought out.
-- cortina,gemini-enable-sata-bridge: enables the PATA to SATA bridge
-  inside the Gemnini SoC. The Muxmode decides what PATA blocks will
-  be muxed out and how.
-
-Example:
-
-sata: sata@46000000 {
-	compatible = "cortina,gemini-sata-bridge";
-	reg = <0x46000000 0x100>;
-	resets = <&rcon 26>, <&rcon 27>;
-	reset-names = "sata0", "sata1";
-	clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
-		 <&gcc GEMINI_CLK_GATE_SATA1>;
-	clock-names = "SATA0_PCLK", "SATA1_PCLK";
-	syscon = <&syscon>;
-	cortina,gemini-ata-muxmode = <3>;
-	cortina,gemini-enable-ide-pins;
-	cortina,gemini-enable-sata-bridge;
-};
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +29 -0
new file mode 100644
index 000000000000..ff27e4884e21
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/cortina,gemini-sata-bridge.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cortina Systems Gemini SATA Bridge
+
+maintainers:
+  - Linus Walleij <[email protected]>
+
+description: |
+    The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
+    takes two Faraday Technology FTIDE010 PATA controllers and bridges
+    them in different configurations to two SATA ports.
+
+properties:
+  compatible:
+    const: "cortina,gemini-sata-bridge"
+  reg:
+    minItems: 1
+  resets:
+    minItems: 2
+    description: phandles to the reset lines for both SATA bridges
+  reset-names:
+    items:
+      - const: "sata0"
+      - const: "sata1"
+  clocks:

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 39

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+    minItems: 2
+    description: phandles to the compulsory peripheral clocks
+  clock-names:
+    items:
+      - const: "SATA0_PCLK"
+      - const: "SATA1_PCLK"
+  syscon:
+    minItems: 1
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: a phandle to the global Gemini system controller

s/a phandle/phandle ?

Saying "a phandle" seems to imply that there may be many. I am not sure here though.

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 48

Quoted 9 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +9 -0
+  cortina,gemini-ata-muxmode:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum:
+      - 0
+      - 1
+      - 2
+      - 3
+    description: |
+      tell the desired multiplexing mode for the ATA controller and SATA bridges. Values 0..3:

Nit: Start the sentence with an uppercase "Tell...".

Quoted 6 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +6 -0
+      Mode 0: ata0 master <-> sata0
+              ata1 master <-> sata1
+              ata0 slave interface brought out on IDE pads
+      Mode 1: ata0 master <-> sata0
+              ata1 master <-> sata1
+              ata1 slave interface brought out on IDE pads

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 64

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+      Mode 2: ata1 master <-> sata1
+              ata1 slave  <-> sata0
+              ata0 master and slave interfaces brought out on IDE pads
+      Mode 3: ata0 master <-> sata0
+              ata0 slave  <-> sata1
+              ata1 master and slave interfaces brought out on IDE pads
+
+  cortina,gemini-enable-ide-pins:
+    type: boolean
+    description: enables the PATA to IDE connection.

Same here.

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 69

Quoted 5 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +5 -0
+                 The muxmode setting decides whether ATA0 or ATA1 is brought out,
+                 and whether master, slave or both interfaces get brought out.
+  cortina,gemini-enable-sata-bridge:
+    type: boolean
+    description: enables the PATA to SATA bridge

Ditto. And the line break is a little early. The first line could be longer so that everything fits in 2 lines.

Quoted 21 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +21 -0
+                 inside the Gemnini SoC. The Muxmode decides what PATA blocks will
+                 be muxed out and how.
+
+required:
+  - clocks
+  - clock-names
+  - cortina,gemini-ata-muxmode
+  - resets
+  - reset-names
+  - compatible
+  - reg
+  - syscon
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/cortina,gemini-clock.h>
+    sata: sata@46000000 {
+      compatible = "cortina,gemini-sata-bridge";
+      reg = <0x46000000 0x100>;

Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml line 100

Quoted 10 lines
Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml new file +10 -0
+      resets = <&rcon 26>, <&rcon 27>;
+      reset-names = "sata0", "sata1";
+      clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
+               <&gcc GEMINI_CLK_GATE_SATA1>;
+      clock-names = "SATA0_PCLK", "SATA1_PCLK";
+      syscon = <&syscon>;
+      cortina,gemini-ata-muxmode = <3>;
+      cortina,gemini-enable-ide-pins;
+      cortina,gemini-enable-sata-bridge;
+    };

With the above cosmetic nits addressed (if necessary):

Quoted 2 lines

Hello

I will fix all thoses in v2.

Thanks!