IB/cma: Allow XRG INI QPs to set their local ACK timeout
PATCH 1/1 IB/cma: Allow XRG INI QPs to set their local ACK timeout
XRC INI QPs should be able to adjust their local ACK timeout.
---
To avoid excessive discussions around the *if (WARN_ON( ...* construct, just saying that it has been sanctioned by Jason here:
https://lore.kernel.org/linux-rdma/[email protected]/
--- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/cma.c +1 -1
@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout) {struct rdma_id_private *id_priv; -if (id->qp_type !=IB_QPT_RC ) +if (WARN_ON (id->qp_type !=IB_QPT_RC && id->qp_type !=IB_QPT_XRC_INI ))return -EINVAL ; id_priv = container_of(id, struct rdma_id_private, id);
Signature · 1 line
1.8.3.1
Quoted 6 lines · Håkon Bugge
XRC INI QPs should be able to adjust their local ACK timeout.
Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")Signed-off-by Håkon Bugge <[email protected]>Suggested-by Avneesh Pant <[email protected]>
Quoted 6 lines
---
To avoid excessive discussions around the *if (WARN_ON( ...* construct, just saying that it has been sanctioned by Jason here:
And I think that this is wrong, because it cane be triggered by user.
1. Create cm_id with any QP type you want - ucma_create_id()
2. Call to set option - ucma_set_option()
3. See WARN_ON.
Thanks
Quoted 20 lines
--- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/core/cma.c +1
-1@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout) {struct rdma_id_private *id_priv; -if (id->qp_type !=IB_QPT_RC ) +if (WARN_ON (id->qp_type !=IB_QPT_RC && id->qp_type !=IB_QPT_XRC_INI ))return -EINVAL ; id_priv = container_of(id, struct rdma_id_private, id);Signature · 1 line
1.8.3.1
Quoted 16 lines · Leon Romanovsky
Quoted 11 lines · Håkon Bugge
XRC INI QPs should be able to adjust their local ACK timeout.
Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")Signed-off-by Håkon Bugge <[email protected]>Suggested-by Avneesh Pant <[email protected]>---
To avoid excessive discussions around the *if (WARN_ON( ...* construct, just saying that it has been sanctioned by Jason here:
Quoted 6 lines
And I think that this is wrong, because it cane be triggered by user.
1. Createcm_idwith any QP type you want -ucma_create_id()
2. Call to set option -ucma_set_option()
3. SeeWARN_ON.
Yes, this one is callable from user-space. Right. Will send a v2.
Thxs, Håkon
Quoted 22 lines
Thanks
Quoted 19 lines
---
drivers/infiniband/core/cma.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/core/cma.c +1
-1@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout) {struct rdma_id_private *id_priv; -if (id->qp_type !=IB_QPT_RC ) +if (WARN_ON (id->qp_type !=IB_QPT_RC && id->qp_type !=IB_QPT_XRC_INI ))return -EINVAL ; id_priv = container_of(id, struct rdma_id_private, id);Signature · 1 line
1.8.3.1