Skip to contentSkip to conversation

x86: kvm Require const tsc for RT

PATCH Applied Sebastian Andrzej Siewior 2 participants 4 messages Mar 1, 2022 – Mar 15, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: kvm Require const tsc for RT

From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100

Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.

---
 arch/x86/kvm/x86.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/kvm/x86.c +6 -0
index 82a9dcd8c67fe..54d2090d04e7a 100644
@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque)
 		goto out;
 	}
 
+	if (IS_ENABLED(CONFIG_PREEMPT_RT) && !boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) {
+		pr_err("RT requires X86_FEATURE_CONSTANT_TSC\n");
+		r = -EOPNOTSUPP;
+		goto out;
+	}
+
 	r = -ENOMEM;
 
 	x86_emulator_cache = kvm_alloc_emulator_cache();
Signature · 1 line
2.35.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Sebastian Andrzej Siewior

From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100

Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.

---
  arch/x86/kvm/x86.c | 6 ++++++
  1 file changed, 6 insertions(+)
arch/x86/kvm/x86.c +0 -0
index 82a9dcd8c67fe..54d2090d04e7a 100644
@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque)
  		goto out;
  	}

arch/x86/kvm/x86.c int kvm_arch_init(void *opaque) · line 8837

Quoted 10 lines
arch/x86/kvm/x86.c +6 -0
 
+	if (IS_ENABLED(CONFIG_PREEMPT_RT) && !boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) {
+		pr_err("RT requires X86_FEATURE_CONSTANT_TSC\n");
+		r = -EOPNOTSUPP;
+		goto out;
+	}
+
  	r = -ENOMEM;
 
  	x86_emulator_cache = kvm_alloc_emulator_cache();

Thanks,

Paolo

#2 lore raw
In reply to Sebastian Andrzej Siewior
Quoted 10 lines · On 2022-03-01 18:55:51 [+0100], To [email protected] wrote:

From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100

Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.

ping.

Quoted 24 lines
---
 arch/x86/kvm/x86.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/kvm/x86.c +6 -0
index 82a9dcd8c67fe..54d2090d04e7a 100644
@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque)
 		goto out;
 	}
 
+	if (IS_ENABLED(CONFIG_PREEMPT_RT) && !boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) {
+		pr_err("RT requires X86_FEATURE_CONSTANT_TSC\n");
+		r = -EOPNOTSUPP;
+		goto out;
+	}
+
 	r = -ENOMEM;
 
 	x86_emulator_cache = kvm_alloc_emulator_cache();
Signature · 1 line
2.35.1
maintainer Applied
#3 lore raw
Quoted 9 lines · Sebastian Andrzej Siewior
Quoted 8 lines · On 2022-03-01 18:55:51 [+0100], To [email protected] wrote:

From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100

Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.

Quoted 4 lines
Quoted 2 lines

ping.

Queued, thanks.

Paolo