x86: kvm Require const tsc for RT
PATCH 1/1 x86: kvm Require const tsc for RT
From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100
Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.
--- arch/x86/kvm/x86.c | 6 ++++++ 1 file changed, 6 insertions(+)
arch/x86/kvm/x86.c +6 -0
@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque) goto out; } +if (IS_ENABLED (CONFIG_PREEMPT_RT ) && !boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) { +pr_err ("RT requires X86_FEATURE_CONSTANT_TSC\n" ); + r = -EOPNOTSUPP ; + goto out; + } + r = -ENOMEM ; x86_emulator_cache =kvm_alloc_emulator_cache ();
Signature · 1 line
2.35.1
Quoted 21 lines · Sebastian Andrzej Siewior
From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.
Signed-off-by Thomas Gleixner <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>--- arch/x86/kvm/x86.c | 6 ++++++ 1 file changed, 6 insertions(+)arch/x86/kvm/x86.c +0
-0@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque) goto out; }
arch/x86/kvm/x86.c int kvm_arch_init(void *opaque) · line 8837
Quoted 10 lines
arch/x86/kvm/x86.c +6
-0+if (IS_ENABLED (CONFIG_PREEMPT_RT ) && !boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) { +pr_err ("RT requires X86_FEATURE_CONSTANT_TSC\n" ); + r = -EOPNOTSUPP ; + goto out; + } + r = -ENOMEM ; x86_emulator_cache =kvm_alloc_emulator_cache ();
Thanks,
Paolo
Quoted 10 lines · On 2022-03-01 18:55:51 [+0100], To [email protected] wrote:
From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.
Signed-off-by Thomas Gleixner <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>
ping.
Quoted 24 lines
--- arch/x86/kvm/x86.c | 6 ++++++ 1 file changed, 6 insertions(+)arch/x86/kvm/x86.c +6
-0@@ -8826,6 +8826,12 @@ int kvm_arch_init(void *opaque) goto out; } +if (IS_ENABLED (CONFIG_PREEMPT_RT ) && !boot_cpu_has (X86_FEATURE_CONSTANT_TSC )) { +pr_err ("RT requires X86_FEATURE_CONSTANT_TSC\n" ); + r = -EOPNOTSUPP ; + goto out; + } + r = -ENOMEM ; x86_emulator_cache =kvm_alloc_emulator_cache ();Signature · 1 line
2.35.1
Quoted 9 lines · Sebastian Andrzej Siewior
Quoted 8 lines · On 2022-03-01 18:55:51 [+0100], To [email protected] wrote:
From: Thomas Gleixner <[email protected]>
Date: Sun, 6 Nov 2011 12:26:18 +0100Non constant TSC is a nightmare on bare metal already, but with virtualization it becomes a complete disaster because the workarounds are horrible latency wise. That's also a preliminary for running RT in a guest on top of a RT host.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Thomas Gleixner <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>ping.
Queued, thanks.
Paolo