mfd/power/regulators: dt-bindings: max14577: convert to dtschema
Subsystems (6)
v3 cover mfd/power/regulators: dt-bindings: max14577: convert to dtschema
Hi,
Changes since v2
================
1. Add tags.
2. Drop DTS patch (applied).
3. mfd: Fix indentation in bindings example.
4. regulator: Drop regulator-name requirement and use unevaluatedProperties.
Changes since v1
================
1. MFD: Use absolute path to schemas
2. Regulator: mention all allowed properties, additionalProperties=false, add min/max values for voltages and current, don't use patternProperties when not needed.
Dependencies
============
1. DTS patch 1/4: nothing depends on it, sending here so Rob's automatic checker won't complain about DTS.
I will take it via Samsung SoC tree.
2. Final MFD patch (4/4) depends on regulator and power, so the last patches (2+3+4) should go via same tree.
Best regards,
Krzysztof
Krzysztof Kozlowski (3):
dt-bindings: power: supply: maxim,max14577: convert to dtschema
regulator: dt-bindings: maxim,max14577: convert to dtschema
dt-bindings: mfd: maxim,max14577: convert to dtschema
.../devicetree/bindings/mfd/max14577.txt | 147 ------------- .../bindings/mfd/maxim,max14577.yaml | 195 ++++++++++++++++++ .../bindings/power/supply/maxim,max14577.yaml | 84 ++++++++ .../bindings/regulator/maxim,max14577.yaml | 78 +++++++ MAINTAINERS | 3 +- 5 files changed, 359 insertions(+), 148 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
Signature · 1 line
2.32.0
PATCH v3 1/3 dt-bindings: power: supply: maxim,max14577: convert to dtschema
Convert the Charger bindings of Maxim MAX14577/MAX77836 MUIC to DT schema format. The existing bindings were defined in ../bindings/mfd/max14577.txt.
--- .../bindings/power/supply/maxim,max14577.yaml | 84 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml
Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml new file +84 -0
@@ -0,0 +1,84 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/maxim,max14577.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX14577/MAX77836 MicroUSB and Companion Power Management IC Charger + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: | + This is a part of device tree bindings for Maxim MAX14577/MAX77836 MicroUSB + Integrated Circuit (MUIC). + + See also Documentation/devicetree/bindings/mfd/maxim,max14577.yaml for + additional information and example. + +properties: + compatible: + enum: + - maxim,max14577-charger + - maxim,max77836-charger + + maxim,constant-uvolt: + description: + Battery Constant Voltage in uV + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 4000000 + maximum: 4350000 + + maxim,eoc-uamp: + description: | + Current in uA for End-Of-Charge mode. + MAX14577: 50000-20000 + MAX77836: 5000-100000 + $ref: /schemas/types.yaml#/definitions/uint32 + + maxim,fast-charge-uamp: + description: | + Current in uA for Fast Charge + MAX14577: 90000-950000 + MAX77836: 45000-475000 + $ref: /schemas/types.yaml#/definitions/uint32 + + maxim,ovp-uvolt: + description: + OverVoltage Protection Threshold in uV; In an overvoltage condition, INT + asserts and charging stops. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [6000000, 6500000, 7000000, 7500000] + +required: + - compatible + - maxim,constant-uvolt + - maxim,eoc-uamp + - maxim,fast-charge-uamp + - maxim,ovp-uvolt + +allOf: + - if: + properties: + compatible: + contains: + const: maxim,max14577-charger + then: + properties: + maxim,eoc-uamp: + minimum: 50000 + maximum: 200000 + maxim,fast-charge-uamp: + minimum: 90000 + maximum: 950000 + else: + # max77836 + properties: + maxim,eoc-uamp: + minimum: 5000 + maximum: 100000 + maxim,fast-charge-uamp: + minimum: 45000 + maximum: 475000 + +additionalProperties: false
MAINTAINERS +1 -0
@@ -11840,6 +11840,7 @@ M: Krzysztof Kozlowski <[email protected]> M: Bartlomiej Zolnierkiewicz <[email protected]> L: [email protected] S: Supported +F: Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml F: Documentation/devicetree/bindings/power/supply/maxim,max77693.yaml F: drivers/power/supply/max14577_charger.c F: drivers/power/supply/max77693_charger.c
Signature · 1 line
2.32.0
Lee Jones
AppliedRe: [PATCH v3 1/3] dt-bindings: power: supply: maxim,max14577: convert to dtschema
Quoted 4 lines · Krzysztof Kozlowski
Convert the Charger bindings of Maxim MAX14577/MAX77836 MUIC to DT schema format. The existing bindings were defined in
../bindings/mfd/max14577.txt.
Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>--- .../bindings/power/supply/maxim,max14577.yaml | 84 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v3 2/3 regulator: dt-bindings: maxim,max14577: convert to dtschema
In reply to Krzysztof KozlowskiConvert the regulator bindings of Maxim MAX14577/MAX77835 MUIC to DT schema format. The existing bindings were defined in ../bindings/mfd/max14577.txt.
--- .../bindings/regulator/maxim,max14577.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
Documentation/devicetree/bindings/regulator/maxim,max14577.yaml new file +78 -0
@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/maxim,max14577.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX14577/MAX77836 MicroUSB and Companion Power Management IC regulators + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: | + This is a part of device tree bindings for Maxim MAX14577/MAX77836 MicroUSB + Integrated Circuit (MUIC). + + See also Documentation/devicetree/bindings/mfd/maxim,max14577.yaml for + additional information and example. + +properties: + compatible: + enum: + - maxim,max14577-regulator + - maxim,max77836-regulator + + CHARGER: + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: | + Current regulator. + + properties: + regulator-min-microvolt: false + regulator-max-microvolt: false + + SAFEOUT: + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: | + Safeout LDO regulator (fixed voltage). + + properties: + regulator-min-microamp: false + regulator-max-microamp: false + regulator-min-microvolt: + const: 4900000 + regulator-max-microvolt: + const: 4900000 + +patternProperties: + "^LDO[12]$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: | + Current regulator. + + properties: + regulator-min-microamp: false + regulator-max-microamp: false + regulator-min-microvolt: + minimum: 800000 + regulator-max-microvolt: + maximum: 3950000 + +allOf: + - if: + properties: + compatible: + contains: + const: maxim,max14577-regulator + then: + properties: + LDO1: false + LDO2: false + +additionalProperties: false
Signature · 1 line
2.32.0
Re: [PATCH v3 2/3] regulator: dt-bindings: maxim,max14577: convert to dtschema
Quoted 6 lines · Krzysztof Kozlowski
Convert the regulator bindings of Maxim MAX14577/MAX77835 MUIC to DT schema format. The existing bindings were defined in
../bindings/mfd/max14577.txt.Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>
Lee Jones
AppliedRe: [PATCH v3 2/3] regulator: dt-bindings: maxim,max14577: convert to dtschema
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
Convert the regulator bindings of Maxim MAX14577/MAX77835 MUIC to DT schema format. The existing bindings were defined in
../bindings/mfd/max14577.txt.Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>--- .../bindings/regulator/maxim,max14577.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v3 3/3 dt-bindings: mfd: maxim,max14577: convert to dtschema
In reply to Krzysztof KozlowskiConvert the MFD part of Maxim MAX14577/MAX77836 MUIC to DT schema format. The example DTS was copied from existing DTS (exynos3250-rinato.dts), so keep the license as GPL-2.0-only.
--- .../devicetree/bindings/mfd/max14577.txt | 147 ------------- .../bindings/mfd/maxim,max14577.yaml | 195 ++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 196 insertions(+), 148 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml
Documentation/devicetree/bindings/mfd/max14577.txt deleted +0 -147
@@ -1,147 +0,0 @@ -Maxim MAX14577/77836 Multi-Function Device - -MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ -Battery Charger and SFOUT LDO output for powering USB devices. It is -interfaced to host controller using I2C. - -MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. -For the description of Fuel Gauge low SOC alert interrupt see: -../power/supply/max17040_battery.txt - - -Required properties: -- compatible : Must be "maxim,max14577" or "maxim,max77836". -- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) -- interrupts : IRQ line for the chip. - - -Required nodes: - - charger : - Node for configuring the charger driver. - Required properties: - - compatible : "maxim,max14577-charger" - or "maxim,max77836-charger" - - maxim,fast-charge-uamp : Current in uA for Fast Charge; - Valid values: - - for max14577: 90000 - 950000; - - for max77836: 45000 - 475000; - - maxim,eoc-uamp : Current in uA for End-Of-Charge mode; - Valid values: - - for max14577: 50000 - 200000; - - for max77836: 5000 - 100000; - - maxim,ovp-uvolt : OverVoltage Protection Threshold in uV; - In an overvoltage condition, INT asserts and charging - stops. Valid values: - - 6000000, 6500000, 7000000, 7500000; - - maxim,constant-uvolt : Battery Constant Voltage in uV; - Valid values: - - 4000000 - 4280000 (step by 20000); - - 4350000; - - -Optional nodes: -- max14577-muic/max77836-muic : - Node used only by extcon consumers. - Required properties: - - compatible : "maxim,max14577-muic" or "maxim,max77836-muic" - -- regulators : - Required properties: - - compatible : "maxim,max14577-regulator" - or "maxim,max77836-regulator" - - May contain a sub-node per regulator from the list below. Each - sub-node should contain the constraints and initialization information - for that regulator. See regulator.txt for a description of standard - properties for these sub-nodes. - - List of valid regulator names: - - for max14577: CHARGER, SAFEOUT. - - for max77836: CHARGER, SAFEOUT, LDO1, LDO2. - - The SAFEOUT is a fixed voltage regulator so there is no need to specify - voltages for it. - - -Example: - -#include <dt-bindings/interrupt-controller/irq.h> - -max14577@25 { - compatible = "maxim,max14577"; - reg = <0x25>; - interrupt-parent = <&gpx1>; - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; - - muic: max14577-muic { - compatible = "maxim,max14577-muic"; - }; - - regulators { - compatible = "maxim,max14577-regulator"; - - SAFEOUT { - regulator-name = "SAFEOUT"; - }; - CHARGER { - regulator-name = "CHARGER"; - regulator-min-microamp = <90000>; - regulator-max-microamp = <950000>; - regulator-boot-on; - }; - }; - - charger { - compatible = "maxim,max14577-charger"; - - maxim,constant-uvolt = <4350000>; - maxim,fast-charge-uamp = <450000>; - maxim,eoc-uamp = <50000>; - maxim,ovp-uvolt = <6500000>; - }; -}; - - -max77836@25 { - compatible = "maxim,max77836"; - reg = <0x25>; - interrupt-parent = <&gpx1>; - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; - - muic: max77836-muic { - compatible = "maxim,max77836-muic"; - }; - - regulators { - compatible = "maxim,max77836-regulator"; - - SAFEOUT { - regulator-name = "SAFEOUT"; - }; - CHARGER { - regulator-name = "CHARGER"; - regulator-min-microamp = <90000>; - regulator-max-microamp = <950000>; - regulator-boot-on; - }; - LDO1 { - regulator-name = "LDO1"; - regulator-min-microvolt = <2700000>; - regulator-max-microvolt = <2700000>; - }; - LDO2 { - regulator-name = "LDO2"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <3950000>; - }; - }; - - charger { - compatible = "maxim,max77836-charger"; - - maxim,constant-uvolt = <4350000>; - maxim,fast-charge-uamp = <225000>; - maxim,eoc-uamp = <7500>; - maxim,ovp-uvolt = <6500000>; - }; -};
Documentation/devicetree/bindings/mfd/maxim,max14577.yaml new file +195 -0
195 lines not on this page · raw message
MAINTAINERS +1 -1
@@ -11851,11 +11851,11 @@ M: Krzysztof Kozlowski <[email protected]> M: Bartlomiej Zolnierkiewicz <[email protected]> L: [email protected] S: Supported +F: Documentation/devicetree/bindings/*/maxim,max14577.yaml F: Documentation/devicetree/bindings/*/maxim,max77686.yaml F: Documentation/devicetree/bindings/*/maxim,max77693.yaml F: Documentation/devicetree/bindings/*/maxim,max77843.yaml F: Documentation/devicetree/bindings/clock/maxim,max77686.txt -F: Documentation/devicetree/bindings/mfd/max14577.txt F: drivers/*/*max77843.c F: drivers/*/max14577*.c F: drivers/*/max77686*.c
Signature · 1 line
2.32.0
Lee Jones
AppliedRe: [PATCH v3 3/3] dt-bindings: mfd: maxim,max14577: convert to dtschema
Quoted 6 lines · Krzysztof Kozlowski
Convert the MFD part of Maxim MAX14577/MAX77836 MUIC to DT schema format. The example DTS was copied from existing DTS (
exynos3250-rinato.dts), so keep the license as GPL-2.0-only.Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>
Quoted 7 lines
--- .../devicetree/bindings/mfd/max14577.txt | 147 ------------- .../bindings/mfd/maxim,max14577.yaml | 195 ++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 196 insertions(+), 148 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 2 lines · Krzysztof Kozlowski
Hi,
Hi Lee,
Mark reviewed regulator patch. Can you take entire set via MFD?
Best regards,
Krzysztof
Quoted 43 lines
Changes since v2
================
1. Add tags.
2. Drop DTS patch (applied).
3. mfd: Fix indentation in bindings example.
4. regulator: Drop regulator-name requirement and use unevaluatedProperties.Changes since v1
================
1. MFD: Use absolute path to schemas
2. Regulator: mention all allowed properties, additionalProperties=false, add min/max values for voltages and current, don't use patternProperties when not needed.Dependencies
============
1. DTS patch 1/4: nothing depends on it, sending here so Rob's automatic checker won't complain about DTS.
I will take it via Samsung SoC tree.2. Final MFD patch (4/4) depends on regulator and power, so the last patches (2+3+4) should go via same tree.
Best regards,
KrzysztofKrzysztof Kozlowski (3):
dt-bindings: power: supply: maxim,max14577: convert to dtschema
regulator: dt-bindings: maxim,max14577: convert to dtschema
dt-bindings: mfd: maxim,max14577: convert to dtschema.../devicetree/bindings/mfd/max14577.txt | 147 ------------- .../bindings/mfd/maxim,max14577.yaml | 195 ++++++++++++++++++ .../bindings/power/supply/maxim,max14577.yaml | 84 ++++++++ .../bindings/regulator/maxim,max14577.yaml | 78 +++++++ MAINTAINERS | 3 +- 5 files changed, 359 insertions(+), 148 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
[GIT PULL] Immutable branch between MFD, SPI and DT due for the v5.18 merge window
In reply to Krzysztof KozlowskiEnjoy!
The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:
Linux 5.17-rc1 (2022-01-23 10:12:53 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-spi-dt-v5.18
for you to fetch changes up to 172e611b54e813c49a35b6b74bccaa99f27bf566:
dt-bindings: mfd: maxim,max77802: Convert to dtschema (2022-03-07 12:55:59 +0000)
----------------------------------------------------------------
Immutable branch between MFD, SPI and DT due for the v5.18 merge window
----------------------------------------------------------------
Krzysztof Kozlowski (13):
dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings
regulator: dt-bindings: maxim,max77843: Add MAX77843 bindings
dt-bindings: mfd: maxim,max77843: Add MAX77843 bindings
MAINTAINERS: mfd: Cover MAX77843 by Maxim PMIC/MUIC for Exynos boards entry
spi: dt-bindings: samsung: Convert to dtschema
mfd: dt-bindings: google,cros-ec: Reference Samsung SPI bindings
mfd: dt-bindings: google,cros-ec: Fix indentation in example
spi: s3c64xx: Allow controller-data to be optional
dt-bindings: power: supply: maxim,max14577: Convert to dtschema
regulator: dt-bindings: maxim,max14577: Convert to dtschema
dt-bindings: mfd: maxim,max14577: Convert to dtschema
regulator: dt-bindings: maxim,max77802: Convert to dtschema
dt-bindings: mfd: maxim,max77802: Convert to dtschema
.../devicetree/bindings/extcon/maxim,max77843.yaml | 40 +++++ .../devicetree/bindings/mfd/google,cros-ec.yaml | 31 ++-- Documentation/devicetree/bindings/mfd/max14577.txt | 147 ---------------- Documentation/devicetree/bindings/mfd/max77802.txt | 25 --- .../devicetree/bindings/mfd/maxim,max14577.yaml | 195 +++++++++++++++++++++ .../devicetree/bindings/mfd/maxim,max77802.yaml | 194 ++++++++++++++++++++ .../devicetree/bindings/mfd/maxim,max77843.yaml | 144 +++++++++++++++ .../bindings/power/supply/maxim,max14577.yaml | 84 +++++++++ .../devicetree/bindings/regulator/max77802.txt | 111 ------------ .../bindings/regulator/maxim,max14577.yaml | 78 +++++++++ .../bindings/regulator/maxim,max77802.yaml | 85 +++++++++ .../bindings/regulator/maxim,max77843.yaml | 65 +++++++ .../bindings/soc/samsung/exynos-usi.yaml | 2 +- .../bindings/spi/samsung,spi-peripheral-props.yaml | 33 ++++ .../devicetree/bindings/spi/samsung,spi.yaml | 187 ++++++++++++++++++++ .../bindings/spi/spi-peripheral-props.yaml | 1 + .../devicetree/bindings/spi/spi-samsung.txt | 122 ------------- MAINTAINERS | 9 +- drivers/spi/spi-s3c64xx.c | 14 +- 19 files changed, 1136 insertions(+), 431 deletions(-) create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml delete mode 100644 Documentation/devicetree/bindings/regulator/max77802.txt create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77802.yaml create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi.yaml delete mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog