Skip to contentSkip to conversation

net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register

PATCH Superseded Miaoqian Lin 2 participants 2 messages May 26, 2022

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register

of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. This function missing of_node_put() in an error path. Add missing of_node_put() to avoid refcount leak.

Fixes a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")

---
changes in v2:
- Add Fixes tag.
v1 link: https://lore.kernel.org/r/[email protected]/

---
 drivers/net/dsa/mv88e6xxx/chip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/dsa/mv88e6xxx/chip.c +3 -1
index 5d2c57a7c708..0726df6aeb1f 100644
@@ -3960,8 +3960,10 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
 	 */
 	child = of_get_child_by_name(np, "mdio");
 	err = mv88e6xxx_mdio_register(chip, child, false);
-	if (err)
+	if (err) {
+		of_node_put(child);
 		return err;
+	}
 
 	/* Walk the device tree, and see if there are any other nodes
 	 * which say they are compatible with the external mdio
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 4 lines · Miaoqian Lin

of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. This function missing of_node_put() in an error path. Add missing of_node_put() to avoid refcount leak.

What about releasing the reference on the non error case? Where is that.

Andrew