net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register
Subsystems (4)
PATCH v2 1/1 net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. This function missing of_node_put() in an error path. Add missing of_node_put() to avoid refcount leak.
Fixes a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
Signed-off-by Miaoqian Lin <[email protected]>
---
changes in v2:
- Add Fixes tag.
v1 link: https://lore.kernel.org/r/[email protected]/
--- drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/dsa/mv88e6xxx/chip.c +3 -1
@@ -3960,8 +3960,10 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,*/ child =of_get_child_by_name (np,"mdio" ); err =mv88e6xxx_mdio_register (chip, child, false); -if (err) +if (err) { +of_node_put (child);return err; + }/* Walk the device tree, and see if there are any other nodes * which say they are compatible with the external mdio
Signature · 1 line
2.25.1
Andrew Lunn
maintainerQuoted 4 lines · Miaoqian Lin
of_get_child_by_name()returns a node pointer with refcount incremented, we should useof_node_put()on it when done. This function missingof_node_put()in an error path. Add missingof_node_put()to avoid refcount leak.
What about releasing the reference on the non error case? Where is that.
Andrew