ASOC: amd: acp: Add Machine driver changes for
Subsystems (3)
v2 cover ASOC: amd: acp: Add Machine driver changes for
Add Machine driver support for nau8825, max98560 and rt5682s,rt1019 combination
This patch set depends on:
--gpio patch
--https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/
--https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/V sujith kumar Reddy (2):
ASoC: amd: acp: Add support for nau8825 and max98360 card
ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs
instance
sound/soc/amd/acp-config.c | 30 ++++ sound/soc/amd/acp/Kconfig | 1 + sound/soc/amd/acp/acp-mach-common.c | 228 +++++++++++++++++++++++++--- sound/soc/amd/acp/acp-mach.h | 3 + sound/soc/amd/acp/acp-sof-mach.c | 30 ++++ sound/soc/amd/mach-config.h | 1 + 6 files changed, 276 insertions(+), 17 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/2 ASoC: amd: acp: Add support for nau8825 and max98360 card
We have new platform with nau8825 as a primary codec and max98360 as an amp codec. Add machine struct to register sof audio based sound card on such Chrome machine.
--- sound/soc/amd/acp-config.c | 21 ++++ sound/soc/amd/acp/Kconfig | 1 + sound/soc/amd/acp/acp-mach-common.c | 159 ++++++++++++++++++++++++++-- sound/soc/amd/acp/acp-mach.h | 3 + sound/soc/amd/acp/acp-sof-mach.c | 15 +++ sound/soc/amd/mach-config.h | 1 + 6 files changed, 194 insertions(+), 6 deletions(-)
sound/soc/amd/acp-config.c +21 -0
@@ -130,4 +130,25 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[] = { };EXPORT_SYMBOL (snd_soc_acpi_amd_sof_machines); +struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[] = { + { + .id ="AMDI1019" , + .drv_name ="rmb-dsp" , + .pdata = (void *)&acp_quirk_data, + .fw_filename ="sof-rmb.ri" , + .sof_tplg_filename ="sof-acp-rmb.tplg" , + }, + { + .id ="10508825" , + .drv_name ="nau8825-max" , + .pdata = (void *)&acp_quirk_data, + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_max, + .fw_filename ="sof-rmb.ri" , + .sof_tplg_filename ="sof-acp-rmb.tplg" , + }, + {}, +}; +EXPORT_SYMBOL (snd_soc_acpi_amd_rmb_sof_machines); +MODULE_LICENSE ("Dual BSD/GPL" );
sound/soc/amd/acp/Kconfig +1 -0
@@ -49,6 +49,7 @@ config SND_SOC_AMD_MACH_COMMON select SND_SOC_RT1019 select SND_SOC_MAX98357A select SND_SOC_RT5682S + select SND_SOC_NAU8825 help This option enables common Machine driver module for ACP.
sound/soc/amd/acp/acp-mach-common.c +153 -6
207 lines not on this page · raw message
sound/soc/amd/acp/acp-mach.h +3 -0
@@ -26,6 +26,7 @@ enum be_id {enum cpu_endpoints {NONE =0 , +I2S_HS ,I2S_SP ,I2S_BT ,DMIC ,
@@ -37,6 +38,7 @@ enum codec_endpoints {RT1019 ,MAX98360A ,RT5682S , + NAU8825, }; struct acp_card_drvdata {
@@ -49,6 +51,7 @@ struct acp_card_drvdata {unsigned int dai_fmt;struct clk *wclk;struct clk *bclk; +bool soc_mclk; };int acp_sofdsp_dai_links_create (struct snd_soc_card *card);
sound/soc/amd/acp/acp-sof-mach.c +15 -0
@@ -56,6 +56,16 @@ static struct acp_card_drvdata sof_rt5682s_max_data = { .dmic_codec_id = DMIC, }; +static struct acp_card_drvdata sof_nau8825_data = { + .hs_cpu_id =I2S_HS , + .amp_cpu_id =I2S_HS , + .dmic_cpu_id =DMIC , + .hs_codec_id =NAU8825 , + .amp_codec_id =MAX98360A , + .dmic_codec_id =DMIC , + .soc_mclk = true, +}; +static const struct snd_kcontrol_new acp_controls[] = {SOC_DAPM_PIN_SWITCH ("Headphone Jack" ),SOC_DAPM_PIN_SWITCH ("Headset Mic" ),
@@ -124,6 +134,10 @@ static const struct platform_device_id board_ids[] = { .name = "rt5682s-rt1019", .driver_data = (kernel_ulong_t)&sof_rt5682s_rt1019_data }, + { + .name = "nau8825-max", + .driver_data = (kernel_ulong_t)&sof_nau8825_data + }, { } };static struct platform_driver acp_asoc_audio = {
@@ -143,4 +157,5 @@ MODULE_ALIAS("platform:rt5682-rt1019");MODULE_ALIAS ("platform:rt5682-max" );MODULE_ALIAS ("platform:rt5682s-max" );MODULE_ALIAS ("platform:rt5682s-rt1019" ); +MODULE_ALIAS ("platform:nau8825-max" );MODULE_LICENSE ("GPL v2" );
sound/soc/amd/mach-config.h +1 -0
@@ -19,6 +19,7 @@#define ACP_PCI_DEV_ID 0x15E2extern struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[];struct config_entry {u32 flags;
Signature · 1 line
2.25.1
Mark Brown
maintainerRe: [PATCH v2 1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card
Quoted 3 lines · V sujith kumar Reddy
We have new platform with nau8825 as a primary codec and max98360 as an amp codec. Add machine struct to register sof audio based sound card on such Chrome machine.
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c: In function ‘acp_card_nau8825_init’:
/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:479:15: error: too many arguments to function ‘snd_soc_card_jack_new’
479 | ret = snd_soc_card_jack_new(card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:20:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:288: sound/soc/amd/acp/acp-mach-common.o] Error 1
make[5]: Target '__build' not remade because of errors.
make[4]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/amd/acp] Error 2
make[4]: Target '__build' not remade because of errors.
make[3]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/amd] Error 2
make[3]: Target '__build' not remade because of errors.
make[2]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [/build/stage/linux/Makefile:1834: sound] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=14 O=/tmp/build-work INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=/tmp/build-work/modinstall ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- modules_install
sed: can't read modules.order: No such file or directory
make[1]: *** [/build/stage/linux/Makefile:1467: __modinst_pre] Error 2
make[1]: Target 'modules_install' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.
PATCH v2 2/2 ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instance
In reply to V sujith kumar ReddyWe have new platform with rt5682s as a primary codec and rt1019 as an amp codec. Add machine struct to register sof audio based sound card on such Chrome machine.
Here we are configuring as a soc mclk master and codec slave.
--- sound/soc/amd/acp-config.c | 9 ++++ sound/soc/amd/acp/acp-mach-common.c | 69 ++++++++++++++++++++++++----- sound/soc/amd/acp/acp-sof-mach.c | 15 +++++++ 3 files changed, 82 insertions(+), 11 deletions(-)
sound/soc/amd/acp-config.c +9 -0
@@ -147,6 +147,15 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[] = { .fw_filename = "sof-rmb.ri", .sof_tplg_filename = "sof-acp-rmb.tplg", }, + { + .id = "RTL5682", + .drv_name = "rt5682s-hs-rt1019", + .pdata = (void *)&acp_quirk_data, + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_rt1019, + .fw_filename = "sof-rmb.ri", + .sof_tplg_filename = "sof-acp-rmb.tplg", + }, {}, };EXPORT_SYMBOL (snd_soc_acpi_amd_rmb_sof_machines);
sound/soc/amd/acp/acp-mach-common.c +58 -11
124 lines not on this page · raw message
sound/soc/amd/acp/acp-sof-mach.c +15 -0
@@ -66,6 +66,16 @@ static struct acp_card_drvdata sof_nau8825_data = { .soc_mclk = true, }; +static struct acp_card_drvdata sof_rt5682s_hs_rt1019_data = { + .hs_cpu_id =I2S_HS , + .amp_cpu_id =I2S_HS , + .dmic_cpu_id =DMIC , + .hs_codec_id =RT5682S , + .amp_codec_id =RT1019 , + .dmic_codec_id =DMIC , + .soc_mclk = true, +}; +static const struct snd_kcontrol_new acp_controls[] = {SOC_DAPM_PIN_SWITCH ("Headphone Jack" ),SOC_DAPM_PIN_SWITCH ("Headset Mic" ),
@@ -138,6 +148,10 @@ static const struct platform_device_id board_ids[] = { .name = "nau8825-max", .driver_data = (kernel_ulong_t)&sof_nau8825_data }, + { + .name = "rt5682s-hs-rt1019", + .driver_data = (kernel_ulong_t)&sof_rt5682s_hs_rt1019_data + }, { } };static struct platform_driver acp_asoc_audio = {
@@ -158,4 +172,5 @@ MODULE_ALIAS("platform:rt5682-max");MODULE_ALIAS ("platform:rt5682s-max" );MODULE_ALIAS ("platform:rt5682s-rt1019" );MODULE_ALIAS ("platform:nau8825-max" ); +MODULE_ALIAS ("platform:rt5682s-hs-rt1019" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 9 lines · V sujith kumar Reddy
Add Machine driver support for nau8825, max98560 and rt5682s,rt1019 combination
This patch set depends on:
--gpio patch --https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/ --https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card
commit: 0439eb4d94e0fc17c6dd3829fabd88c11773381d
[2/2] ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instance
commit: 4dc6737cfe882765d914fcb88b5eaa14551ffdddAll being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark